[builtins] Don't pass unused receiver to interceptor/accessor callbacks [v8/v8 : main]
0 views
Skip to first unread message
Igor Sheludko (Gerrit)
Jan 14, 2026, 12:21:56 PM (6 days ago) Jan 14
to Toon Verwaest, cbruni...@chromium.org, devtools-...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
Attention needed from Toon Verwaest
Igor Sheludko voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Toon Verwaest
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Jan 15, 2026, 10:10:46 AM (5 days ago) Jan 15
to Igor Sheludko, V8 LUCI CQ, Toon Verwaest, cbruni...@chromium.org, devtools-...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
Attention needed from Igor Sheludko and Toon Verwaest
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m4-mini-perf/speedometer3 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/148f18dfb10000
Related details
Attention is currently required from:
- Igor Sheludko
- Toon Verwaest
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Jan 15, 2026, 10:28:25 AM (5 days ago) Jan 15
to Igor Sheludko, V8 LUCI CQ, Toon Verwaest, cbruni...@chromium.org, devtools-...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
Attention needed from Igor Sheludko and Toon Verwaest
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m4-mini-perf/speedometer2 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/11e7f414710000
Related details
Attention is currently required from:
- Igor Sheludko
- Toon Verwaest
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Jan 16, 2026, 5:45:33 AM (4 days ago) Jan 16
to Igor Sheludko, V8 LUCI CQ, Toon Verwaest, cbruni...@chromium.org, devtools-...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
Attention needed from Igor Sheludko and Toon Verwaest
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m4-mini-perf/speedometer2 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/10854412710000
Related details
Attention is currently required from:
- Igor Sheludko
- Toon Verwaest
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Jan 16, 2026, 5:45:38 AM (4 days ago) Jan 16
to Igor Sheludko, V8 LUCI CQ, Toon Verwaest, cbruni...@chromium.org, devtools-...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
Attention needed from Igor Sheludko and Toon Verwaest
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m4-mini-perf/speedometer3 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/12600a7c710000
Related details
Attention is currently required from:
- Igor Sheludko
- Toon Verwaest
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Toon Verwaest (Gerrit)
Jan 19, 2026, 11:15:33 AM (19 hours ago) Jan 19
to Igor Sheludko, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, cbruni...@chromium.org, devtools-...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
Attention needed from Igor Sheludko
Toon Verwaest voted and added 1 comment![]( "Open in Gerrit")
Votes added by Toon Verwaest
| Code-Review | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Igor Sheludko (Gerrit)
2:43 AM (3 hours ago) 2:43 AM
to Toon Verwaest, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, cbruni...@chromium.org, devtools-...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
Igor Sheludko voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
2:46 AM (3 hours ago) 2:46 AM
to Igor Sheludko, Toon Verwaest, chrom...@appspot.gserviceaccount.com, cbruni...@chromium.org, devtools-...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[builtins] Don't pass unused receiver to interceptor/accessor callbacks
... as a part of v8::PropertyCallbackInfo<T> data set.
CallApiGetter builtin on Arm64 has slightly different calling
convention in order to minimize complexity maintaining stack
alignment: both holder and callback info are passed on the stack
while for other architectures the callback info is passed in register
(it's slightly more convenient since the builtin needs to load the
C++ callback function pointer and property name from it).
Drive-by: rename ApiGetterDescriptor to CallApiGetterDescriptor.
Bug: 455600234
Change-Id: I9f8444aa32a1ce91500111ef708969fe8b0117c4
Reviewed-by: Toon Verwaest <verw...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104780}
Files:
- M include/v8-function-callback.h
- M src/api/api-arguments-inl.h
- M src/api/api-arguments.h
- M src/builtins/arm/builtins-arm.cc
- M src/builtins/arm64/builtins-arm64.cc
- M src/builtins/builtins-definitions.h
- M src/builtins/ia32/builtins-ia32.cc
- M src/builtins/loong64/builtins-loong64.cc
- M src/builtins/mips64/builtins-mips64.cc
- M src/builtins/ppc/builtins-ppc.cc
- M src/builtins/riscv/builtins-riscv.cc
- M src/builtins/s390/builtins-s390.cc
- M src/builtins/x64/builtins-x64.cc
- M src/codegen/arm/interface-descriptors-arm-inl.h
- M src/codegen/arm64/interface-descriptors-arm64-inl.h
- M src/codegen/ia32/interface-descriptors-ia32-inl.h
- M src/codegen/interface-descriptors-inl.h
- M src/codegen/interface-descriptors.h
- M src/codegen/loong64/interface-descriptors-loong64-inl.h
- M src/codegen/mips64/interface-descriptors-mips64-inl.h
- M src/codegen/ppc/interface-descriptors-ppc-inl.h
- M src/codegen/riscv/interface-descriptors-riscv-inl.h
- M src/codegen/s390/interface-descriptors-s390-inl.h
- M src/codegen/x64/interface-descriptors-x64-inl.h
- M src/debug/debug.cc
- M src/debug/debug.h
- M src/diagnostics/objects-printer.cc
- M src/execution/frame-constants.h
- M src/execution/frames-inl.h
- M src/execution/frames.cc
- M src/execution/frames.h
- M src/ic/accessor-assembler.cc
- M src/ic/ic.cc
- M src/objects/js-objects.cc
- M src/objects/keys.cc
- M src/objects/keys.h
- M src/objects/objects.cc
Change size: L
Delta: 37 files changed, 182 insertions(+), 301 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Toon Verwaest
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages