Move kEventReportingCdpAttribution to enterprise_connectors and add privacy_tier param [chromium/src : main]

0 views
Skip to first unread message

Daniel Qian (Gerrit)

unread,
Oct 21, 2026, 9:50:21 PM (16 hours ago) Oct 21
to Chrome Enterprise Premium Reviews, Chromium LUCI CQ, Nibir Nawfil Afif, Alex Rudenko, Andrey Kosyakov, Danil Somsikov, Shanthanu Bhardwaj, chromium...@chromium.org, devtools...@chromium.org
Attention needed from Alex Rudenko, Andrey Kosyakov, Chrome Enterprise Premium Reviews, Danil Somsikov and Nibir Nawfil Afif

Daniel Qian voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alex Rudenko
  • Andrey Kosyakov
  • Chrome Enterprise Premium Reviews
  • Danil Somsikov
  • Nibir Nawfil Afif
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I44a50c2bf948a63d99892b6fae50344175e5cbf5
Gerrit-Change-Number: 8625928
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Qian <qi...@google.com>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Chrome Enterprise Premium Reviews <cep-r...@google.com>
Gerrit-Reviewer: Daniel Qian <qi...@google.com>
Gerrit-Reviewer: Nibir Nawfil Afif <nan...@google.com>
Gerrit-CC: Andrey Kosyakov <ca...@chromium.org>
Gerrit-CC: Danil Somsikov <d...@chromium.org>
Gerrit-CC: Shanthanu Bhardwaj <xa...@google.com>
Gerrit-Attention: Chrome Enterprise Premium Reviews <cep-r...@google.com>
Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Attention: Nibir Nawfil Afif <nan...@google.com>
Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
Gerrit-Attention: Danil Somsikov <d...@chromium.org>
Gerrit-Comment-Date: Thu, 22 Oct 2026 01:50:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Oct 21, 2026, 9:51:36 PM (16 hours ago) Oct 21
to Daniel Qian, Chrome Enterprise Premium Reviews, Haihan Chen, Chromium LUCI CQ, Nibir Nawfil Afif, Alex Rudenko, Andrey Kosyakov, Danil Somsikov, Shanthanu Bhardwaj, chromium...@chromium.org, devtools...@chromium.org
Attention needed from Alex Rudenko, Andrey Kosyakov, Danil Somsikov, Haihan Chen and Nibir Nawfil Afif

Message from gwsq

Reviewer source(s):
hai...@google.com is from context(chrome/enterprise/gwsq/cep-review.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Alex Rudenko
  • Andrey Kosyakov
  • Danil Somsikov
  • Haihan Chen
  • Nibir Nawfil Afif
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I44a50c2bf948a63d99892b6fae50344175e5cbf5
Gerrit-Change-Number: 8625928
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Qian <qi...@google.com>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Daniel Qian <qi...@google.com>
Gerrit-Reviewer: Haihan Chen <hai...@google.com>
Gerrit-Reviewer: Nibir Nawfil Afif <nan...@google.com>
Gerrit-CC: Andrey Kosyakov <ca...@chromium.org>
Gerrit-CC: Chrome Enterprise Premium Reviews <cep-r...@google.com>
Gerrit-CC: Danil Somsikov <d...@chromium.org>
Gerrit-CC: Shanthanu Bhardwaj <xa...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Attention: Nibir Nawfil Afif <nan...@google.com>
Gerrit-Attention: Haihan Chen <hai...@google.com>
Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
Gerrit-Attention: Danil Somsikov <d...@chromium.org>
Gerrit-Comment-Date: Thu, 22 Oct 2026 01:51:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Alex Rudenko (Gerrit)

unread,
2:25 AM (12 hours ago) 2:25 AM
to Daniel Qian, Chrome Enterprise Premium Reviews, Haihan Chen, Chromium LUCI CQ, Nibir Nawfil Afif, Andrey Kosyakov, Danil Somsikov, Shanthanu Bhardwaj, chromium...@chromium.org, devtools...@chromium.org
Attention needed from Andrey Kosyakov, Daniel Qian, Danil Somsikov, Haihan Chen and Nibir Nawfil Afif

Alex Rudenko voted Code-Review+1 on change 8625928

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Andrey Kosyakov
  • Daniel Qian
  • Danil Somsikov
  • Haihan Chen
  • Nibir Nawfil Afif
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I44a50c2bf948a63d99892b6fae50344175e5cbf5
      Gerrit-Change-Number: 8625928
      Gerrit-PatchSet: 4
      Gerrit-Owner: Daniel Qian <qi...@google.com>
      Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
      Gerrit-Reviewer: Daniel Qian <qi...@google.com>
      Gerrit-Reviewer: Haihan Chen <hai...@google.com>
      Gerrit-Reviewer: Nibir Nawfil Afif <nan...@google.com>
      Gerrit-CC: Andrey Kosyakov <ca...@chromium.org>
      Gerrit-CC: Chrome Enterprise Premium Reviews <cep-r...@google.com>
      Gerrit-CC: Danil Somsikov <d...@chromium.org>
      Gerrit-CC: Shanthanu Bhardwaj <xa...@google.com>
      Gerrit-CC: gwsq
      Gerrit-Attention: Daniel Qian <qi...@google.com>
      Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
      Gerrit-Attention: Nibir Nawfil Afif <nan...@google.com>
      Gerrit-Attention: Haihan Chen <hai...@google.com>
      Gerrit-Attention: Danil Somsikov <d...@chromium.org>
      Gerrit-Comment-Date: Thu, 22 Oct 2026 06:25:35 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Danil Somsikov (Gerrit)

      unread,
      5:44 AM (9 hours ago) 5:44 AM
      to Daniel Qian, Alex Rudenko, Chrome Enterprise Premium Reviews, Haihan Chen, Chromium LUCI CQ, Nibir Nawfil Afif, Andrey Kosyakov, Shanthanu Bhardwaj, chromium...@chromium.org, devtools...@chromium.org
      Attention needed from Andrey Kosyakov, Daniel Qian, Haihan Chen and Nibir Nawfil Afif

      Danil Somsikov added 1 comment on change 8625928

      File components/enterprise/connectors/core/features.cc
      Line 95, Patchset 4 (Latest): &kCdpAttributionPrivacyTierOptions);
      Danil Somsikov . unresolved

      Should we remove the & to pass the array directly?
      Passing &kCdpAttributionPrivacyTierOptions takes the address of the array (yielding Option (*)[2]), which does not implicitly decay to a pointer or span.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Andrey Kosyakov
      • Daniel Qian
      • Haihan Chen
      • Nibir Nawfil Afif
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement is not satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement is not satisfiedNo-Unresolved-Comments
          • requirement satisfiedReview-Enforcement
          Gerrit-Comment-Date: Thu, 22 Oct 2026 09:43:43 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy
          Reply all
          Reply to author
          Forward
          0 new messages