[a11y] Correct role and label for devtools-switch [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Ergün Erdoğmuş (Gerrit)
Sep 23, 2025, 7:59:26 AM (3 days ago) Sep 23
to Kateryna Prokopenko, devtools-rev...@chromium.org
Attention needed from Kateryna Prokopenko
Ergün Erdoğmuş voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Kateryna Prokopenko
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kateryna Prokopenko (Gerrit)
Sep 23, 2025, 9:57:01 AM (2 days ago) Sep 23
to Ergün Erdoğmuş, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Ergün Erdoğmuş
Kateryna Prokopenko voted and added 2 comments![]( "Open in Gerrit")
Votes added by Kateryna Prokopenko
| Code-Review | +1 |
2 comments
Patchset-level comments
File front_end/panels/security/CookieControlsView.ts
Line 189, Patchset 1 (Latest):
.label=${'Temporarily limit third-party cookies, only when DevTools is open'}Kateryna Prokopenko . unresolved
Do we not want to translate this?
Related details
Attention is currently required from:
- Ergün Erdoğmuş
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ergün Erdoğmuş (Gerrit)
Sep 23, 2025, 10:18:42 AM (2 days ago) Sep 23
to Kateryna Prokopenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Kateryna Prokopenko
Ergün Erdoğmuş voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ergün Erdoğmuş
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
File front_end/panels/security/CookieControlsView.ts
Line 189, Patchset 1:
.label=${'Temporarily limit third-party cookies, only when DevTools is open'}Kateryna Prokopenko . resolved
Do we not want to translate this?
Attention is currently required from:
- Kateryna Prokopenko
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kateryna Prokopenko (Gerrit)
Sep 23, 2025, 10:24:22 AM (2 days ago) Sep 23
to Ergün Erdoğmuş, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Ergün Erdoğmuş
Kateryna Prokopenko voted and added 2 comments![]( "Open in Gerrit")
Votes added by Kateryna Prokopenko
| Code-Review | +1 |
2 comments
Patchset-level comments
File front_end/panels/security/CookieControlsView.ts
Line 189, Patchset 1:
.label=${'Temporarily limit third-party cookies, only when DevTools is open'}Kateryna Prokopenko . resolved
Ergün ErdoğmuşDo we not want to translate this?
I think we want to, let me do it in a separate CL :)
Attention is currently required from:
- Ergün Erdoğmuş
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ergün Erdoğmuş (Gerrit)
Sep 23, 2025, 11:34:37 AM (2 days ago) Sep 23
to Kateryna Prokopenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Kateryna Prokopenko
Ergün Erdoğmuş voted![]( "Open in Gerrit")
Attention is currently required from:
- Kateryna Prokopenko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikolay Vitkov (Gerrit)
Sep 23, 2025, 11:38:21 AM (2 days ago) Sep 23
to Ergün Erdoğmuş, Kateryna Prokopenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Ergün Erdoğmuş and Kateryna Prokopenko
Nikolay Vitkov voted![]( "Open in Gerrit")
Attention is currently required from:
- Ergün Erdoğmuş
- Kateryna Prokopenko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
Sep 23, 2025, 3:16:05 PM (2 days ago) Sep 23
to Ergün Erdoğmuş, Nikolay Vitkov, Kateryna Prokopenko, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[a11y] Correct role and label for devtools-switch
This change addresses an accessibility issue in the `<devtools-switch>`
component where screen readers would announce a double role ("button" and
"checkbox") and a double label ("Keep me updated, unticked, keep me
updated, group").
The root causes were:
1. A `<label>` element with a redundant `role="button"` wrapping the
inner `<input>`.
2. An `aria-label` on the host element (`<devtools-switch>`) causing it
to be announced as a separate entity from its inner checkbox.
This commit fixes the issue by:
- Removing the `role="button"` from the label.
- Introducing a `label` property on the `Switch` component to set the
accessible name.
- Applying the label directly to the inner `<input type="checkbox">`
instead of the host element.
This ensures the switch is announced with a single, correct role and
label.
Fixed: 446672060
Change-Id: I09bc6b4133a04c46ab8e482b33a9e0275ddf15d3
Auto-Submit: Ergün Erdoğmuş <erg...@chromium.org>
Reviewed-by: Nikolay Vitkov <nvi...@chromium.org>
Commit-Queue: Ergün Erdoğmuş <erg...@chromium.org>
Commit-Queue: Nikolay Vitkov <nvi...@chromium.org>
Files:
- M front_end/panels/common/GdpSignUpDialog.ts
- M front_end/panels/security/CookieControlsView.ts
- M front_end/panels/settings/AISettingsTab.ts
- M front_end/ui/components/switch/SwitchImpl.ts
- M test/e2e_non_hosted/ai_assistance/ai_assistance_test.ts
- M test/e2e_non_hosted/security/privacy_test.ts
Change size: S
Delta: 6 files changed, 20 insertions(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nikolay Vitkov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages