Migrate node attributes to lit [devtools/devtools-frontend : main]

[Alex Rudenko (Gerrit)]

Alex Rudenko added 2 comments

File front_end/panels/elements/ElementsTreeElement.ts

Line 858, Patchset 1 (Latest): // FIXME: we should compute the aria label in a more eff

Alex Rudenko . unresolved

Typo: "eff" should probably be "efficient".

Line 2153, Patchset 1 (Latest): const attr = container;

Alex Rudenko . unresolved

`Lit.render` renders the template *inside* `container`. By assigning `container` to `attr`, you are using the temporary wrapper `<span>` as the attribute element. This results in an extra `<span>` in the DOM, and the styles on the next lines are applied to this wrapper instead of the actual attribute element.

This should probably be:
```ts
const attr = container.firstElementChild as HTMLElement;
```

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: devtools/devtools-frontend

Gerrit-Branch: main

Gerrit-Change-Id: Icbebe0879c3e14746c9fe8606c2cc63520b674ff

Gerrit-Change-Number: 7562054

Gerrit-PatchSet: 1

Gerrit-Owner: Alex Rudenko <alexr...@chromium.org>

Gerrit-Comment-Date: Tue, 10 Feb 2026 13:13:00 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Alex Rudenko (Gerrit)]

Alex Rudenko added 2 comments

File front_end/panels/elements/ElementsTreeElement.ts

Line 858, Patchset 1: // FIXME: we should compute the aria label in a more eff

Alex Rudenko . resolved

Typo: "eff" should probably be "efficient".

Alex Rudenko

Done

Line 2153, Patchset 1: const attr = container;

Alex Rudenko . resolved

`Lit.render` renders the template *inside* `container`. By assigning `container` to `attr`, you are using the temporary wrapper `<span>` as the attribute element. This results in an extra `<span>` in the DOM, and the styles on the next lines are applied to this wrapper instead of the actual attribute element.

This should probably be:
```ts
const attr = container.firstElementChild as HTMLElement;
```

Alex Rudenko

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: devtools/devtools-frontend

Gerrit-Branch: main

Gerrit-Change-Id: Icbebe0879c3e14746c9fe8606c2cc63520b674ff

Gerrit-Change-Number: 7562054

Gerrit-PatchSet: 2

Gerrit-Owner: Alex Rudenko <alexr...@chromium.org>

Gerrit-Comment-Date: Tue, 10 Feb 2026 13:35:40 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Alex Rudenko <alexr...@chromium.org>

[Alex Rudenko (Gerrit)]

Attention needed from Philip Pfaffe

Alex Rudenko added 1 comment

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Alex Rudenko . resolved

PTAL (this needs a thorough review)

Open in Gerrit

Related details

Attention is currently required from:

• Philip Pfaffe

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: devtools/devtools-frontend

Gerrit-Branch: main

Gerrit-Change-Id: Icbebe0879c3e14746c9fe8606c2cc63520b674ff

Gerrit-Change-Number: 7562054

Gerrit-PatchSet: 7

Gerrit-Owner: Alex Rudenko <alexr...@chromium.org>

Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>

Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>

Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Philip Pfaffe <pfa...@chromium.org>

Gerrit-Comment-Date: Tue, 10 Feb 2026 15:49:03 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No