AI: disable computed style widget resizing [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Jack Franklin (Gerrit)

unread,
Mar 23, 2026, 1:49:10 PM (18 hours ago) Mar 23
to Alina Varkki, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Alina Varkki

Jack Franklin voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alina Varkki
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I86d45cf3b8dc876d8738b2ac03cb748db552881c
Gerrit-Change-Number: 7693613
Gerrit-PatchSet: 1
Gerrit-Owner: Jack Franklin <jacktf...@chromium.org>
Gerrit-Reviewer: Alina Varkki <alina...@chromium.org>
Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Alina Varkki <alina...@chromium.org>
Gerrit-Comment-Date: Mon, 23 Mar 2026 17:49:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Alina Varkki (Gerrit)

unread,
5:44 AM (3 hours ago) 5:44 AM
to Jack Franklin, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Jack Franklin

Alina Varkki voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Jack Franklin
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I86d45cf3b8dc876d8738b2ac03cb748db552881c
Gerrit-Change-Number: 7693613
Gerrit-PatchSet: 1
Gerrit-Owner: Jack Franklin <jacktf...@chromium.org>
Gerrit-Reviewer: Alina Varkki <alina...@chromium.org>
Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Jack Franklin <jacktf...@chromium.org>
Gerrit-Comment-Date: Tue, 24 Mar 2026 09:44:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,
5:46 AM (3 hours ago) 5:46 AM
to Jack Franklin, Alina Varkki, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:
AI: disable computed style widget resizing

Due to how the widgets are rendered and the various layers of flex box
etc going on, within the AI Assistance panel once the computed style
widget goes into its narrow mode it will not come back out of it when
you resize the parent.

I am trying to find a way to avoid this, but as a short term fix this CL
disables the resizing behaviour completely. This is OK in the AI
Assistance as we don't expect people to have the walkthrough at such a
narrow view.
Bug: 495429549
Change-Id: I86d45cf3b8dc876d8738b2ac03cb748db552881c
Commit-Queue: Alina Varkki <alina...@chromium.org>
Reviewed-by: Alina Varkki <alina...@chromium.org>
Auto-Submit: Jack Franklin <jacktf...@chromium.org>
Files:
  • M front_end/panels/ai_assistance/components/ChatMessage.ts
  • M front_end/panels/elements/ComputedStyleWidget.test.ts
  • M front_end/panels/elements/ComputedStyleWidget.ts
Change size: M
Delta: 3 files changed, 49 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Alina Varkki
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I86d45cf3b8dc876d8738b2ac03cb748db552881c
Gerrit-Change-Number: 7693613
Gerrit-PatchSet: 2
Gerrit-Owner: Jack Franklin <jacktf...@chromium.org>
Gerrit-Reviewer: Alina Varkki <alina...@chromium.org>
Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages