Revert "[webauthn] Expose null signature counter to CDP" [chromium/src : main]

0 views
Skip to first unread message

luci-bisection@appspot.gserviceaccount.com (Gerrit)

unread,
Jul 24, 2026, 4:51:26 PM (2 days ago) Jul 24
to Chromium LUCI CQ, Andrey Kosyakov, Nina Satragno, devtools...@chromium.org, chromium...@chromium.org
Attention needed from Andrey Kosyakov and Nina Satragno

luci-bi...@appspot.gserviceaccount.com has uploaded the change for review

luci-bi...@appspot.gserviceaccount.com would like Chromium LUCI CQ, Andrey Kosyakov and Nina Satragno to review this change.

Commit message

Revert "[webauthn] Expose null signature counter to CDP"

This reverts commit e8f81421fb31319114aab7b3d5ffaf1677b6449f.

Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/6032648548909056

Sample build with failed test: https://ci.chromium.org/b/8675369182410018225
Affected test(s):
[://\:chrome_wpt_tests!webtest::external/wpt/webdriver/tests/classic/external/webauthn/add_credential#invalid.py](https://ci.chromium.org/ui/test/chromium/:%2F%2F%5C:chrome_wpt_tests%21webtest::external%2Fwpt%2Fwebdriver%2Ftests%2Fclassic%2Fexternal%2Fwebauthn%2Fadd_credential%23invalid.py?q=VHash%3A0bc243e3f1e70338)

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F6032648548909056&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F8138482&type=BUG

Original change's description:
> [webauthn] Expose null signature counter to CDP
>
> Expand WebAuthn virtual authenticator CDP commands to support setting a
> null signature counter, and add support for modifying an existing
> signature counter. This will be used to support an upgrade to the
> WebAuthn webdriver commands.
>
> Since CDP doesn't seem to support differentiating between an
> integer value being missing or null, use -1 as a sentinel value to
> indicate a counter missing. Webdriver will map null to -1.
>
> See https://github.com/w3c/webauthn/pull/2382
>
> TAG=agy
> CONV=8a5aa474-7c70-4d3f-9d13-59d4a45e6971
>
> Bug: 533056772
> Change-Id: I18e8f9b58181274caef89ec3963a221fbc80c40e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8138482
> Commit-Queue: Nina Satragno <nsat...@chromium.org>
> Reviewed-by: Andrey Kosyakov <ca...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1668046}
>
Bug: 533056772
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I5b38a569c7d6ab9891d1cfb992880dfadf026f21

Change diff


Change information

Files:
  • M content/browser/devtools/protocol/webauthn_handler.cc
  • M content/browser/devtools/protocol/webauthn_handler.h
  • M third_party/blink/public/devtools_protocol/domains/WebAuthn.pdl
  • M third_party/blink/web_tests/http/tests/inspector-protocol/webauthn/resources/webauthn-test.https.html
  • M third_party/blink/web_tests/http/tests/inspector-protocol/webauthn/webauthn-add-credential-errors-expected.txt
  • M third_party/blink/web_tests/http/tests/inspector-protocol/webauthn/webauthn-add-credential-errors.js
  • M third_party/blink/web_tests/http/tests/inspector-protocol/webauthn/webauthn-add-credential-expected.txt
  • M third_party/blink/web_tests/http/tests/inspector-protocol/webauthn/webauthn-get-credentials-expected.txt
  • D third_party/blink/web_tests/http/tests/inspector-protocol/webauthn/webauthn-sign-count-expected.txt
  • D third_party/blink/web_tests/http/tests/inspector-protocol/webauthn/webauthn-sign-count.js
Change size: M
Delta: 10 files changed, 14 insertions(+), 165 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Andrey Kosyakov
  • Nina Satragno
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5b38a569c7d6ab9891d1cfb992880dfadf026f21
Gerrit-Change-Number: 8144521
Gerrit-PatchSet: 1
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Nina Satragno <nsat...@chromium.org>
Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Attention: Nina Satragno <nsat...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

luci-bisection@appspot.gserviceaccount.com (Gerrit)

unread,
Jul 24, 2026, 4:51:43 PM (2 days ago) Jul 24
to Stefan Zager, Slobodan Pejic, rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Andrey Kosyakov, Nina Satragno, devtools...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, devtools-re...@chromium.org
Attention needed from Andrey Kosyakov, Nina Satragno, Slobodan Pejic and Stefan Zager

Message from luci-bi...@appspot.gserviceaccount.com

LUCI Bisection could not automatically submit this revert because LUCI Bisection has not yet support auto-commit of revert CL for test failure.

Open in Gerrit

Related details

Attention is currently required from:
  • Andrey Kosyakov
  • Nina Satragno
  • Slobodan Pejic
  • Stefan Zager
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5b38a569c7d6ab9891d1cfb992880dfadf026f21
Gerrit-Change-Number: 8144521
Gerrit-PatchSet: 1
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Nina Satragno <nsat...@chromium.org>
Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Attention: Stefan Zager <sza...@google.com>
Gerrit-Attention: Nina Satragno <nsat...@chromium.org>
Gerrit-Attention: Slobodan Pejic <slob...@google.com>
Gerrit-Comment-Date: Fri, 24 Jul 2026 20:51:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

rubber-stamper@appspot.gserviceaccount.com (Gerrit)

unread,
Jul 24, 2026, 4:52:19 PM (2 days ago) Jul 24
to luci-bi...@appspot.gserviceaccount.com, Stefan Zager, Slobodan Pejic, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Andrey Kosyakov, Nina Satragno, devtools...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, devtools-re...@chromium.org
Attention needed from Andrey Kosyakov, Nina Satragno, Slobodan Pejic and Stefan Zager

Related details

Attention is currently required from:
  • Andrey Kosyakov
  • Nina Satragno
  • Slobodan Pejic
  • Stefan Zager
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I5b38a569c7d6ab9891d1cfb992880dfadf026f21
    Gerrit-Change-Number: 8144521
    Gerrit-PatchSet: 1
    Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Nina Satragno <nsat...@chromium.org>
    Gerrit-Reviewer: Slobodan Pejic <slob...@google.com>
    Gerrit-Reviewer: Stefan Zager <sza...@google.com>
    Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
    Gerrit-Attention: Stefan Zager <sza...@google.com>
    Gerrit-Attention: Nina Satragno <nsat...@chromium.org>
    Gerrit-Attention: Slobodan Pejic <slob...@google.com>
    Gerrit-Comment-Date: Fri, 24 Jul 2026 20:52:09 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Slobodan Pejic (Gerrit)

    unread,
    Jul 24, 2026, 4:55:42 PM (2 days ago) Jul 24
    to luci-bi...@appspot.gserviceaccount.com, rubber-...@appspot.gserviceaccount.com, Stefan Zager, Slobodan Pejic, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Andrey Kosyakov, Nina Satragno, devtools...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, devtools-re...@chromium.org
    Attention needed from Andrey Kosyakov, Nina Satragno, Slobodan Pejic and Stefan Zager

    Slobodan Pejic voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Andrey Kosyakov
    • Nina Satragno
    • Slobodan Pejic
    • Stefan Zager
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I5b38a569c7d6ab9891d1cfb992880dfadf026f21
    Gerrit-Change-Number: 8144521
    Gerrit-PatchSet: 1
    Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Nina Satragno <nsat...@chromium.org>
    Gerrit-Reviewer: Slobodan Pejic <slob...@chromium.org>
    Gerrit-Reviewer: Slobodan Pejic <slob...@google.com>
    Gerrit-Reviewer: Stefan Zager <sza...@google.com>
    Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
    Gerrit-Attention: Stefan Zager <sza...@google.com>
    Gerrit-Attention: Nina Satragno <nsat...@chromium.org>
    Gerrit-Attention: Slobodan Pejic <slob...@google.com>
    Gerrit-Comment-Date: Fri, 24 Jul 2026 20:55:33 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Andrey Kosyakov (Gerrit)

    unread,
    Jul 24, 2026, 5:01:45 PM (2 days ago) Jul 24
    to luci-bi...@appspot.gserviceaccount.com, Slobodan Pejic, rubber-...@appspot.gserviceaccount.com, Stefan Zager, Slobodan Pejic, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Nina Satragno, devtools...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, devtools-re...@chromium.org
    Attention needed from Nina Satragno, Slobodan Pejic, Slobodan Pejic and Stefan Zager

    Andrey Kosyakov voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Nina Satragno
    • Slobodan Pejic
    • Slobodan Pejic
    • Stefan Zager
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I5b38a569c7d6ab9891d1cfb992880dfadf026f21
    Gerrit-Change-Number: 8144521
    Gerrit-PatchSet: 1
    Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Nina Satragno <nsat...@chromium.org>
    Gerrit-Reviewer: Slobodan Pejic <slob...@chromium.org>
    Gerrit-Reviewer: Slobodan Pejic <slob...@google.com>
    Gerrit-Reviewer: Stefan Zager <sza...@google.com>
    Gerrit-Attention: Slobodan Pejic <slob...@chromium.org>
    Gerrit-Attention: Stefan Zager <sza...@google.com>
    Gerrit-Attention: Nina Satragno <nsat...@chromium.org>
    Gerrit-Attention: Slobodan Pejic <slob...@google.com>
    Gerrit-Comment-Date: Fri, 24 Jul 2026 21:01:38 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Stefan Zager (Gerrit)

    unread,
    Jul 24, 2026, 6:28:16 PM (2 days ago) Jul 24
    to luci-bi...@appspot.gserviceaccount.com, Andrey Kosyakov, Slobodan Pejic, rubber-...@appspot.gserviceaccount.com, Stefan Zager, Slobodan Pejic, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Nina Satragno, devtools...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, devtools-re...@chromium.org
    Attention needed from Nina Satragno, Slobodan Pejic, Slobodan Pejic and Stefan Zager

    Stefan Zager voted Commit-Queue+2

    Commit-Queue+2
    Gerrit-Reviewer: Stefan Zager <sza...@chromium.org>
    Gerrit-Reviewer: Stefan Zager <sza...@google.com>
    Gerrit-Attention: Slobodan Pejic <slob...@chromium.org>
    Gerrit-Attention: Stefan Zager <sza...@google.com>
    Gerrit-Attention: Nina Satragno <nsat...@chromium.org>
    Gerrit-Attention: Slobodan Pejic <slob...@google.com>
    Gerrit-Comment-Date: Fri, 24 Jul 2026 22:28:07 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jul 24, 2026, 6:28:43 PM (2 days ago) Jul 24
    to luci-bi...@appspot.gserviceaccount.com, Stefan Zager, Andrey Kosyakov, Slobodan Pejic, rubber-...@appspot.gserviceaccount.com, Stefan Zager, Slobodan Pejic, android-bu...@system.gserviceaccount.com, Nina Satragno, devtools...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, devtools-re...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Reviewed-by: Andrey Kosyakov <ca...@chromium.org>
    Commit-Queue: Stefan Zager <sza...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1668201}
    Files:
    • M content/browser/devtools/protocol/webauthn_handler.cc
    • M content/browser/devtools/protocol/webauthn_handler.h
    • M third_party/blink/public/devtools_protocol/domains/WebAuthn.pdl
    • M third_party/blink/web_tests/http/tests/inspector-protocol/webauthn/resources/webauthn-test.https.html
    • M third_party/blink/web_tests/http/tests/inspector-protocol/webauthn/webauthn-add-credential-errors-expected.txt
    • M third_party/blink/web_tests/http/tests/inspector-protocol/webauthn/webauthn-add-credential-errors.js
    • M third_party/blink/web_tests/http/tests/inspector-protocol/webauthn/webauthn-add-credential-expected.txt
    • M third_party/blink/web_tests/http/tests/inspector-protocol/webauthn/webauthn-get-credentials-expected.txt
    • D third_party/blink/web_tests/http/tests/inspector-protocol/webauthn/webauthn-sign-count-expected.txt
    • D third_party/blink/web_tests/http/tests/inspector-protocol/webauthn/webauthn-sign-count.js
    Change size: M
    Delta: 10 files changed, 14 insertions(+), 165 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I5b38a569c7d6ab9891d1cfb992880dfadf026f21
    Gerrit-Change-Number: 8144521
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages