RPP: deal with ID reuse when pairing async events [devtools/devtools-frontend : chromium/7390]
0 views
Skip to first unread message
Connor Clark (Gerrit)
Sep 23, 2025, 1:42:27 PM (3 days ago) Sep 23
to Jack Franklin, Paul Irish, Devtools-frontend LUCI CQ, AyeAye, devtools-rev...@chromium.org
Attention needed from Paul Irish
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Paul Irish
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Irish (Gerrit)
Sep 23, 2025, 2:07:55 PM (3 days ago) Sep 23
to Connor Clark, Jack Franklin, Devtools-frontend LUCI CQ, AyeAye, devtools-rev...@chromium.org
Attention needed from Connor Clark
Paul Irish voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Connor Clark
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Connor Clark (Gerrit)
Sep 23, 2025, 3:08:18 PM (2 days ago) Sep 23
to Jack Franklin, Paul Irish, Devtools-frontend LUCI CQ, AyeAye, devtools-rev...@chromium.org
Connor Clark voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
Sep 23, 2025, 3:10:17 PM (2 days ago) Sep 23
to Connor Clark, Jack Franklin, Paul Irish, AyeAye, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
RPP: deal with ID reuse when pairing async events
This CL is the more generic fix that first landed specifically for
performance.measure calls in crrev.com/c/6965589.
In July 2025 this change in Perfetto:
https://chromium.googlesource.com/external/github.com/google/perfetto.git/+/aef636b27ffbf379fd722e7798030da2c5c4d699
had the side-effect of meaning that Perfetto can and will reuse IDs for
trace events if it can. This means that begin & end event pairs that do
not overlap may have the same ID.
Our logic to pair `begin` and `end` events together (along with async
instant events too) does not account for this, and is causing bugs like
the one attached to this CL where events get dropped if there are ID
collisions.
The fix is to walk th events in timestamp order; collecting begin &
instant events by ID, and then grouping them when we find an end event.
If we have two groups with the same ID, we know they must not overlap,
so we know that by the time we hit the begin event of the second group,
we know the first must have been collected by now.
Bug: 445614711
Fixed: 446602467
Change-Id: I0b14aefe2408d9cb24394ad2fb6b93a87064669a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6969008
Auto-Submit: Jack Franklin <jacktf...@chromium.org>
Commit-Queue: Jack Franklin <jacktf...@chromium.org>
Reviewed-by: Finnur Thorarinsson <fin...@chromium.org>
(cherry picked from commit 5ab40b5970e13339d4481ecf11de51b82285a106)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6976651
Reviewed-by: Paul Irish <paul...@chromium.org>
Commit-Queue: Connor Clark <cja...@chromium.org>
Files:
- M front_end/models/trace/handlers/UserTimingsHandler.ts
- M front_end/models/trace/helpers/Trace.test.ts
- M front_end/models/trace/helpers/Trace.ts
- M front_end/models/trace/types/TraceEvents.ts
Change size: L
Delta: 4 files changed, 229 insertions(+), 44 deletions(-)
Branch: refs/heads/chromium/7390
Submit Requirements:
Code-Review: +1 by Paul Irish
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages