[Cxx extension e2e] Disable DevToolsAiPromptApi [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Wolfgang Beyer (Gerrit)
12:08 PM (11 hours ago) 12:08 PM
to Philip Pfaffe, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Philip Pfaffe
Wolfgang Beyer voted and added 1 comment![]( "Open in Gerrit")
Votes added by Wolfgang Beyer
| Auto-Submit | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Wolfgang Beyer . resolved
Philip, PTAL.
There are crashes when running e2e-tests for the Cxx extensions. I can reproduce the crash locally and managed to track the reason down to the `window.LanguageModel.availability()` function call in https://crsrc.org/c/third_party/devtools-frontend/src/front_end/models/ai_assistance/BuiltInAi.ts;l=38.
However, gating behind a `if (window.LanguageModel?.availability)...` did not help. I could not repro the crash outside of e2e tests. Since I'm running out of ideas, I would like to simply disable the Prompt API for the tests, at least until https://crbug.com/456671382, which could be related, is fixed.
Related details
Attention is currently required from:
- Philip Pfaffe
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Pfaffe (Gerrit)
12:12 PM (11 hours ago) 12:12 PM
to Wolfgang Beyer, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Wolfgang Beyer
Philip Pfaffe voted![]( "Open in Gerrit")
Attention is currently required from:
- Wolfgang Beyer
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
1:23 PM (10 hours ago) 1:23 PM
to Wolfgang Beyer, Philip Pfaffe, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Cxx extension e2e] Disable DevToolsAiPromptApi
Bug: none
Change-Id: I264c1fcbfecd1df70750f28bea3f020495f5ecdf
Commit-Queue: Wolfgang Beyer <wo...@chromium.org>
Commit-Queue: Philip Pfaffe <pfa...@chromium.org>
Auto-Submit: Wolfgang Beyer <wo...@chromium.org>
Reviewed-by: Philip Pfaffe <pfa...@chromium.org>
Files:
- M extensions/cxx_debugging/e2e/MochaRootHooks.ts
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Philip Pfaffe
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages