Remove hover effect for title help keyboard accessibility in metric card [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Sylvester Elorm Coch (Gerrit)
Feb 25, 2026, 4:50:46 PM (6 days ago) Feb 25
to Adam Raine, devtools-rev...@chromium.org
Attention needed from Adam Raine
Sylvester Elorm Coch added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Adam Raine
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sylvester Elorm Coch (Gerrit)
Mar 1, 2026, 9:39:32 PM (2 days ago) Mar 1
to Wolfgang Beyer, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Wolfgang Beyer
Sylvester Elorm Coch added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Sylvester Elorm Coch . resolved
Attention is currently required from:
- Wolfgang Beyer
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Wolfgang Beyer (Gerrit)
Mar 2, 2026, 4:03:03 AM (yesterday) Mar 2
to Sylvester Elorm Coch, Jack Franklin, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Jack Franklin and Sylvester Elorm Coch
Wolfgang Beyer added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Wolfgang Beyer . unresolved
It seems that this was originally added on purpose, maybe Jack has more context.
Related details
Attention is currently required from:
- Jack Franklin
- Sylvester Elorm Coch
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sylvester Elorm Coch (Gerrit)
Mar 2, 2026, 12:49:51 PM (yesterday) Mar 2
to Jack Franklin, Wolfgang Beyer, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Jack Franklin and Wolfgang Beyer
Sylvester Elorm Coch added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Wolfgang Beyer . unresolved
It seems that this was originally added on purpose, maybe Jack has more context.
Sylvester Elorm Coch
Yes this was added in a CL that shows the help button only on hover - https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5983127.
This however creates an accessibility issue where without hovering the button is inaccessible via the keyboard. My proposal is to always show this to resolve the a11y issue if that's fine.
Related details
Attention is currently required from:
- Jack Franklin
- Wolfgang Beyer
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jack Franklin (Gerrit)
7:19 AM (7 hours ago) 7:19 AM
to Sylvester Elorm Coch, Wolfgang Beyer, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Sylvester Elorm Coch and Wolfgang Beyer
Jack Franklin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jack Franklin
| Code-Review | +1 |
1 comment
Patchset-level comments
Wolfgang Beyer . resolved
Sylvester Elorm CochIt seems that this was originally added on purpose, maybe Jack has more context.
Yes this was added in a CL that shows the help button only on hover - https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5983127.
This however creates an accessibility issue where without hovering the button is inaccessible via the keyboard. My proposal is to always show this to resolve the a11y issue if that's fine.
Attention is currently required from:
- Sylvester Elorm Coch
- Wolfgang Beyer
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Wolfgang Beyer (Gerrit)
8:05 AM (7 hours ago) 8:05 AM
to Sylvester Elorm Coch, Jack Franklin, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Sylvester Elorm Coch
Wolfgang Beyer voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Sylvester Elorm Coch
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sylvester Elorm Coch (Gerrit)
1:00 PM (2 hours ago) 1:00 PM
to Wolfgang Beyer, Jack Franklin, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Sylvester Elorm Coch voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
1:40 PM (1 hour ago) 1:40 PM
to Sylvester Elorm Coch, Wolfgang Beyer, Jack Franklin, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove hover effect for title help keyboard accessibility in metric card
Before:
The .title-help button is only keyboard accessible when the card is hovered. For users who don't rely on the mouse, this is not accessible.
After:
We always show this button so it's accessible via the keyboard.
Bug: 487613506
Change-Id: I3e3920f445874378aaa0b916866d13544af8dba3
Reviewed-by: Jack Franklin <jacktf...@chromium.org>
Commit-Queue: Sylvester Elorm Coch <elor...@microsoft.com>
Reviewed-by: Wolfgang Beyer <wo...@chromium.org>
Files:
- M front_end/panels/timeline/components/metricCard.css
Change size: XS
Delta: 1 file changed, 0 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Wolfgang Beyer, +1 by Jack Franklin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages