Remove direct-sockets-private permission policy [chromium/src : main]

[Bhaskar Sharma (Gerrit)]

Bhaskar Sharma added 1 comment

File services/network/public/mojom/permissions_policy/permissions_policy_feature.mojom

Line 273, Patchset 6 (Parent): kDirectSocketsPrivate = 126,

Andrew Rayskiy . resolved

Look at `kClientHintUAFull` -- the rule of thumb is to leave a comment instead of fully removing!

Bhaskar Sharma

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ic2cac25c8a22e749b48ea65b63dd32cefa7e0fca

Gerrit-Change-Number: 7845254

Gerrit-PatchSet: 8

Gerrit-Owner: Bhaskar Sharma <bhaska...@google.com>

Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>

Gerrit-Reviewer: Bhaskar Sharma <bhaska...@google.com>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Thu, 11 Jun 2026 17:42:32 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Andrew Rayskiy <green...@google.com>

[gwsq (Gerrit)]

Attention needed from Ari Chivukula, Danil Somsikov, Mike West, Nasko Oskov and Simon Hangl

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
Shadow: ari...@chromium.org; IPC: mk...@chromium.org, na...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

Shadow IPC reviewer(s): ari...@chromium.org. Please conduct an IPC review and CR+1 when satisfied. Remember to add the main reviewers to the attention set if needed.

Main IPC reviewer(s): mk...@chromium.org, na...@chromium.org. Please wait for the shadowed IPC reviewer to CR+1 before reviewing.

Reviewer source(s):
mk...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

• Ari Chivukula
• Danil Somsikov
• Mike West
• Nasko Oskov
• Simon Hangl

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ic2cac25c8a22e749b48ea65b63dd32cefa7e0fca

Gerrit-Change-Number: 7845254

Gerrit-PatchSet: 8

Gerrit-Owner: Bhaskar Sharma <bhaska...@google.com>

Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>

Gerrit-Reviewer: Ari Chivukula <ari...@chromium.org>

Gerrit-Reviewer: Bhaskar Sharma <bhaska...@google.com>

Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>

Gerrit-Reviewer: Mike West <mk...@chromium.org>

Gerrit-Reviewer: Nasko Oskov <na...@chromium.org>

Gerrit-Reviewer: Simon Hangl <sim...@google.com>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Nasko Oskov <na...@chromium.org>

Gerrit-Attention: Simon Hangl <sim...@google.com>

Gerrit-Attention: Mike West <mk...@chromium.org>

Gerrit-Attention: Ari Chivukula <ari...@chromium.org>

Gerrit-Attention: Danil Somsikov <d...@chromium.org>

Gerrit-Comment-Date: Thu, 11 Jun 2026 19:09:56 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Ari Chivukula (Gerrit)]

Attention needed from Bhaskar Sharma, Danil Somsikov, Mike West, Nasko Oskov and Simon Hangl

Ari Chivukula voted and added 2 comments

Votes added by Ari Chivukula

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 8 (Latest):

Ari Chivukula . resolved

(shadow) IPC LGTM

File services/network/public/mojom/permissions_policy/permissions_policy_feature.mojom

Line 271, Patchset 8 (Latest): // kDirectSocketsPrivate = 126, Removed in M151.

Ari Chivukula . unresolved

nit: link this CL

Open in Gerrit

Related details

Attention is currently required from:

• Bhaskar Sharma

• Danil Somsikov
• Mike West
• Nasko Oskov
• Simon Hangl

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ic2cac25c8a22e749b48ea65b63dd32cefa7e0fca

Gerrit-Change-Number: 7845254

Gerrit-PatchSet: 8

Gerrit-Owner: Bhaskar Sharma <bhaska...@google.com>

Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>

Gerrit-Reviewer: Ari Chivukula <ari...@chromium.org>

Gerrit-Reviewer: Bhaskar Sharma <bhaska...@google.com>

Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>

Gerrit-Reviewer: Mike West <mk...@chromium.org>

Gerrit-Reviewer: Nasko Oskov <na...@chromium.org>

Gerrit-Reviewer: Simon Hangl <sim...@google.com>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Bhaskar Sharma <bhaska...@google.com>

Gerrit-Attention: Nasko Oskov <na...@chromium.org>

Gerrit-Attention: Simon Hangl <sim...@google.com>

Gerrit-Attention: Mike West <mk...@chromium.org>

Gerrit-Attention: Danil Somsikov <d...@chromium.org>

Gerrit-Comment-Date: Thu, 11 Jun 2026 19:13:01 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Nasko Oskov (Gerrit)]

Attention needed from Bhaskar Sharma, Danil Somsikov, Mike West and Simon Hangl

Nasko Oskov voted and added 3 comments

Votes added by Nasko Oskov

Code-Review

+1

3 comments

Patchset-level comments

File-level comment, Patchset 8 (Latest):

Nasko Oskov . resolved

LGTM with a nit.

File content/public/browser/direct_sockets_delegate.h

Line 38, Patchset 8 (Latest): // direct-sockets-multicast permissions policies will be ignored; providing a

Nasko Oskov . unresolved

nit: Doesn't this fit on the previous line?

File services/network/public/mojom/permissions_policy/permissions_policy_feature.mojom

Line 271, Patchset 8 (Latest): // kDirectSocketsPrivate = 126, Removed in M151.

Ari Chivukula . unresolved

nit: link this CL

Nasko Oskov

I'm kinda curious what would that link accomplish. None of the other removals have a link to CL.

Open in Gerrit

Related details

Attention is currently required from:

• Bhaskar Sharma
• Danil Somsikov
• Mike West

• Simon Hangl

Gerrit-Attention: Simon Hangl <sim...@google.com>

Gerrit-Attention: Mike West <mk...@chromium.org>

Gerrit-Attention: Danil Somsikov <d...@chromium.org>

Gerrit-Comment-Date: Thu, 11 Jun 2026 23:14:12 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Ari Chivukula <ari...@chromium.org>

[Vlad Krot (Gerrit)]

Attention needed from Bhaskar Sharma, Danil Somsikov, Mike West and Simon Hangl

Vlad Krot voted Code-Review+1

Code-Review

+1

Gerrit-Comment-Date: Fri, 12 Jun 2026 10:04:17 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Bhaskar Sharma (Gerrit)]

Attention needed from Danil Somsikov and Simon Hangl

Bhaskar Sharma added 2 comments

File content/public/browser/direct_sockets_delegate.h

Line 38, Patchset 8: // direct-sockets-multicast permissions policies will be ignored; providing a

Nasko Oskov . resolved

nit: Doesn't this fit on the previous line?

Bhaskar Sharma

Done

File services/network/public/mojom/permissions_policy/permissions_policy_feature.mojom

Line 271, Patchset 8: // kDirectSocketsPrivate = 126, Removed in M151.

Ari Chivukula . resolved

nit: link this CL

Nasko Oskov

I'm kinda curious what would that link accomplish. None of the other removals have a link to CL.

Bhaskar Sharma

Done

Open in Gerrit

Related details

Attention is currently required from:

• Danil Somsikov
• Simon Hangl

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ic2cac25c8a22e749b48ea65b63dd32cefa7e0fca

Gerrit-Change-Number: 7845254

Gerrit-PatchSet: 9

Gerrit-Owner: Bhaskar Sharma <bhaska...@google.com>

Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>

Gerrit-Reviewer: Ari Chivukula <ari...@chromium.org>

Gerrit-Reviewer: Bhaskar Sharma <bhaska...@google.com>

Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>

Gerrit-Reviewer: Nasko Oskov <na...@chromium.org>

Gerrit-Reviewer: Simon Hangl <sim...@google.com>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Simon Hangl <sim...@google.com>

Gerrit-Attention: Danil Somsikov <d...@chromium.org>

Gerrit-Comment-Date: Fri, 12 Jun 2026 14:20:54 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Nasko Oskov <na...@chromium.org>

Comment-In-Reply-To: Ari Chivukula <ari...@chromium.org>

[Danil Somsikov (Gerrit)]

Attention needed from Bhaskar Sharma and Simon Hangl

Danil Somsikov voted and added 1 comment

Votes added by Danil Somsikov

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 9 (Latest):

Danil Somsikov . resolved

DevTools LGTM

Open in Gerrit

Related details

Attention is currently required from:

• Bhaskar Sharma
• Simon Hangl

Gerrit-Attention: Bhaskar Sharma <bhaska...@google.com>

Gerrit-Attention: Simon Hangl <sim...@google.com>

Gerrit-Comment-Date: Fri, 12 Jun 2026 14:49:09 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Simon Hangl (Gerrit)]

Attention needed from Bhaskar Sharma

Simon Hangl voted and added 1 comment

Votes added by Simon Hangl

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 9 (Latest):

Simon Hangl . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:

• Bhaskar Sharma

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ic2cac25c8a22e749b48ea65b63dd32cefa7e0fca

Gerrit-Change-Number: 7845254

Gerrit-PatchSet: 9

Gerrit-Owner: Bhaskar Sharma <bhaska...@google.com>

Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>

Gerrit-Reviewer: Ari Chivukula <ari...@chromium.org>

Gerrit-Reviewer: Bhaskar Sharma <bhaska...@google.com>

Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>

Gerrit-Reviewer: Nasko Oskov <na...@chromium.org>

Gerrit-Reviewer: Simon Hangl <sim...@google.com>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Bhaskar Sharma <bhaska...@google.com>

Gerrit-Comment-Date: Fri, 12 Jun 2026 15:27:43 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Bhaskar Sharma (Gerrit)]

Bhaskar Sharma voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Gerrit-Comment-Date: Fri, 12 Jun 2026 16:39:56 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Change information

Commit message:

Remove direct-sockets-private permission policy

This CL removes "direct-sockets-private" permission policy along with
its default unpacking to "local-network" and "loopback-network"
permission policies.

Fixed: 492476083

Change-Id: Ic2cac25c8a22e749b48ea65b63dd32cefa7e0fca

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7845254

Reviewed-by: Vlad Krot <vk...@google.com>

Reviewed-by: Danil Somsikov <d...@chromium.org>

Reviewed-by: Nasko Oskov <na...@chromium.org>

Reviewed-by: Andrew Rayskiy <green...@google.com>

Reviewed-by: Ari Chivukula <ari...@chromium.org>

Reviewed-by: Simon Hangl <sim...@google.com>

Commit-Queue: Bhaskar Sharma <bhaska...@google.com>

Cr-Commit-Position: refs/heads/main@{#1646037}

Files:

• M chrome/browser/ash/app_mode/test/kiosk_iwa_permissions_browsertest.cc
• M chrome/browser/devtools/protocol/devtools_protocol_browsertest.cc
• M chrome/browser/direct_sockets/direct_sockets_apitest.cc
• M chrome/browser/web_applications/isolated_web_apps/isolated_web_app_browsertest.cc
• M chrome/browser/web_applications/isolated_web_apps/isolated_web_app_entitlements_browsertest.cc
• M chrome/browser/web_applications/isolated_web_apps/isolated_web_app_permissions_policy_browsertest.cc
• M chrome/browser/web_applications/isolated_web_apps/iwa_permissions_policy_cache.cc
• M chrome/browser/web_applications/isolated_web_apps/key_distribution/preload/key_distribution.textproto
• M chrome/browser/web_applications/isolated_web_apps/key_distribution/proto/key_distribution.proto
• M chrome/browser/web_applications/isolated_web_apps/runtime_data/iwa_entitlements.cc
• M chrome/browser/web_applications/isolated_web_apps/runtime_data/iwa_entitlements_unittest.cc
• M content/browser/direct_sockets/direct_sockets_service_impl.cc
• M content/browser/direct_sockets/direct_sockets_udp_browsertest.cc
• M content/browser/direct_sockets/firewall_hole_browsertest.cc
• M content/public/browser/direct_sockets_delegate.h
• M services/network/public/cpp/permissions_policy/permissions_policy_features.json5
• M services/network/public/cpp/permissions_policy/permissions_policy_features_unittest.cc
• M services/network/public/mojom/permissions_policy/permissions_policy_feature.mojom
• M third_party/blink/public/devtools_protocol/domains/Page.pdl
• M third_party/blink/web_tests/http/tests/inspector-protocol/network/direct-sockets/resources/socket-default.php
• M third_party/blink/web_tests/http/tests/inspector-protocol/network/direct-sockets/resources/udp-socket-success.php
• M third_party/blink/web_tests/wpt_internal/isolated-permissions-policy-stable/permissions_policy.https.html
• M third_party/blink/web_tests/wpt_internal/isolated-permissions-policy/permissions_policy.https.html

Change size: L

Delta: 23 files changed, 39 insertions(+), 288 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Andrew Rayskiy, +1 by Danil Somsikov, +1 by Ari Chivukula, +1 by Nasko Oskov, +1 by Vlad Krot, +1 by Simon Hangl

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ic2cac25c8a22e749b48ea65b63dd32cefa7e0fca

Gerrit-Change-Number: 7845254

Gerrit-PatchSet: 10

Gerrit-Owner: Bhaskar Sharma <bhaska...@google.com>

Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>

Gerrit-Reviewer: Ari Chivukula <ari...@chromium.org>

Gerrit-Reviewer: Bhaskar Sharma <bhaska...@google.com>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>

Gerrit-Reviewer: Nasko Oskov <na...@chromium.org>

Gerrit-Reviewer: Simon Hangl <sim...@google.com>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>