DevTools: Support screen.orientation.lock() in device emulation [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Helmut Januschka (Gerrit)

unread,
Feb 16, 2026, 3:03:16 AMFeb 16
to Helmut Januschka, Mathias Bynens, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Mathias Bynens

Helmut Januschka added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Helmut Januschka . resolved

hello reviewers, thanks in advance for your time, this is the frontend part for
https://chromium-review.googlesource.com/c/chromium/src/+/7580113

see bug: https://issues.chromium.org/issues/40807290#comment19 for a video of the feature.

please let me know if you want me to address anything!

Open in Gerrit

Related details

Attention is currently required from:
  • Mathias Bynens
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I0f9f1531d3c1e7ef52bcfa4255b6d68b128b9d34
Gerrit-Change-Number: 7580093
Gerrit-PatchSet: 1
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Mathias Bynens <mat...@chromium.org>
Gerrit-Comment-Date: Mon, 16 Feb 2026 08:03:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Philip Pfaffe (Gerrit)

unread,
Feb 16, 2026, 4:07:43 AMFeb 16
to Helmut Januschka, Changhao Han, Mathias Bynens, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Changhao Han and Helmut Januschka

Philip Pfaffe added 2 comments

Patchset-level comments
Philip Pfaffe . resolved

Thanks for the CL, looks good overall! Would be great if you could cover the device toolbar updates with tests.

File front_end/panels/emulation/DeviceModeToolbar.ts
Line 818, Patchset 1 (Latest): // When unlocked, restore the button to its normal state.
Philip Pfaffe . unresolved

Could you add tests covering this?

Open in Gerrit

Related details

Attention is currently required from:
  • Changhao Han
  • Helmut Januschka
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: devtools/devtools-frontend
    Gerrit-Branch: main
    Gerrit-Change-Id: I0f9f1531d3c1e7ef52bcfa4255b6d68b128b9d34
    Gerrit-Change-Number: 7580093
    Gerrit-PatchSet: 1
    Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
    Gerrit-Reviewer: Changhao Han <chang...@google.com>
    Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
    Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
    Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-CC: Mathias Bynens <mat...@chromium.org>
    Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
    Gerrit-Attention: Changhao Han <chang...@google.com>
    Gerrit-Comment-Date: Mon, 16 Feb 2026 09:07:38 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    open
    diffy

    Helmut Januschka (Gerrit)

    unread,
    Feb 17, 2026, 7:07:34 PM (14 days ago) Feb 17
    to Helmut Januschka, Philip Pfaffe, Changhao Han, Mathias Bynens, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
    Attention needed from Changhao Han and Philip Pfaffe

    Helmut Januschka added 1 comment

    File front_end/panels/emulation/DeviceModeToolbar.ts
    Line 818, Patchset 1: // When unlocked, restore the button to its normal state.
    Philip Pfaffe . resolved

    Could you add tests covering this?

    Helmut Januschka

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Changhao Han
    • Philip Pfaffe
    Submit Requirements:
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: devtools/devtools-frontend
      Gerrit-Branch: main
      Gerrit-Change-Id: I0f9f1531d3c1e7ef52bcfa4255b6d68b128b9d34
      Gerrit-Change-Number: 7580093
      Gerrit-PatchSet: 2
      Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
      Gerrit-Reviewer: Changhao Han <chang...@google.com>
      Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
      Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
      Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-CC: Mathias Bynens <mat...@chromium.org>
      Gerrit-Attention: Philip Pfaffe <pfa...@chromium.org>
      Gerrit-Attention: Changhao Han <chang...@google.com>
      Gerrit-Comment-Date: Wed, 18 Feb 2026 00:07:29 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Philip Pfaffe <pfa...@chromium.org>
      unsatisfied_requirement
      open
      diffy

      Philip Pfaffe (Gerrit)

      unread,
      Feb 18, 2026, 4:22:38 AM (13 days ago) Feb 18
      to Helmut Januschka, Alex Rudenko, Changhao Han, Mathias Bynens, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
      Attention needed from Alex Rudenko and Helmut Januschka

      Philip Pfaffe voted and added 5 comments

      Votes added by Philip Pfaffe

      Code-Review+1

      5 comments

      File front_end/panels/emulation/DeviceModeToolbar.test.ts
      Line 40, Patchset 3 (Latest): beforeEach(() => {
      Philip Pfaffe . unresolved

      Can you use stubNoopSettings?

      Line 72, Patchset 3 (Latest): const buttons = toolbar.element().querySelectorAll('devtools-button.toolbar-button');
      Philip Pfaffe . unresolved

      querySelectorAll<Buttons.Button.Button> accepts a type argument, means you don't need to cast below.

      Line 79, Patchset 3 (Latest): throw new Error('Could not find rotate button');
      Philip Pfaffe . unresolved

      Assert on the result instead?

      Line 94, Patchset 3 (Latest): emulationModel!.screenOrientationLockChanged({
      Philip Pfaffe . unresolved

      Superfluous non-null assertion, also below.

      File third_party/blink/public/devtools_protocol/domains/Emulation.pdl
      File-level comment, Patchset 3 (Latest):
      Philip Pfaffe . unresolved

      No need to include these changes in this CL, they get autorolled from chromium. Once that happens, you can rebase the CL to get rid of them.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Alex Rudenko
      • Helmut Januschka
      Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: devtools/devtools-frontend
      Gerrit-Branch: main
      Gerrit-Change-Id: I0f9f1531d3c1e7ef52bcfa4255b6d68b128b9d34
      Gerrit-Change-Number: 7580093
      Gerrit-PatchSet: 3
      Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
      Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
      Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
      Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
      Gerrit-CC: Changhao Han <chang...@chromium.org>
      Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-CC: Mathias Bynens <mat...@chromium.org>
      Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
      Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
      Gerrit-Comment-Date: Wed, 18 Feb 2026 09:22:34 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Alex Rudenko (Gerrit)

      unread,
      Feb 18, 2026, 4:35:34 AM (13 days ago) Feb 18
      to Helmut Januschka, Philip Pfaffe, Changhao Han, Mathias Bynens, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
      Attention needed from Helmut Januschka

      Alex Rudenko added 2 comments

      File front_end/core/sdk/EmulationModel.ts
      Line 45, Patchset 3 (Latest): target.registerEmulationDispatcher(this);
      Alex Rudenko . unresolved

      nit: let's move to the end of the constructor to be safer in case registerEmulationDispatcher dispatches events?

      File front_end/models/emulation/DeviceModeModel.ts
      Line 466, Patchset 3 (Latest): this.#screenOrientationLocked = false;
      Alex Rudenko . unresolved

      I think we might need to dispatched the Updated event here?

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Helmut Januschka
      Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: devtools/devtools-frontend
      Gerrit-Branch: main
      Gerrit-Change-Id: I0f9f1531d3c1e7ef52bcfa4255b6d68b128b9d34
      Gerrit-Change-Number: 7580093
      Gerrit-PatchSet: 3
      Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
      Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
      Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
      Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
      Gerrit-CC: Changhao Han <chang...@chromium.org>
      Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-CC: Mathias Bynens <mat...@chromium.org>
      Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
      Gerrit-Comment-Date: Wed, 18 Feb 2026 09:35:30 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Helmut Januschka (Gerrit)

      unread,
      Feb 18, 2026, 5:04:39 PM (13 days ago) Feb 18
      to Helmut Januschka, Alex Rudenko, Philip Pfaffe, Changhao Han, Mathias Bynens, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
      Attention needed from Alex Rudenko and Philip Pfaffe

      Helmut Januschka added 7 comments

      File front_end/core/sdk/EmulationModel.ts
      Line 45, Patchset 3: target.registerEmulationDispatcher(this);
      Alex Rudenko . resolved

      nit: let's move to the end of the constructor to be safer in case registerEmulationDispatcher dispatches events?

      Helmut Januschka

      Done

      File front_end/models/emulation/DeviceModeModel.ts
      Line 466, Patchset 3: this.#screenOrientationLocked = false;
      Alex Rudenko . resolved

      I think we might need to dispatched the Updated event here?

      Helmut Januschka

      Done. Added `this.dispatchEventToListeners(Events.UPDATED)` after resetting `#screenOrientationLocked`, matching the pattern in `onScreenOrientationLockChanged`.

      File front_end/panels/emulation/DeviceModeToolbar.test.ts
      Line 40, Patchset 3: beforeEach(() => {
      Philip Pfaffe . resolved

      Can you use stubNoopSettings?

      Helmut Januschka

      Done

      Line 72, Patchset 3: const buttons = toolbar.element().querySelectorAll('devtools-button.toolbar-button');
      Philip Pfaffe . resolved

      querySelectorAll<Buttons.Button.Button> accepts a type argument, means you don't need to cast below.

      Helmut Januschka

      Done

      Line 79, Patchset 3: throw new Error('Could not find rotate button');
      Philip Pfaffe . resolved

      Assert on the result instead?

      Helmut Januschka

      Done

      Line 94, Patchset 3: emulationModel!.screenOrientationLockChanged({
      Philip Pfaffe . resolved

      Superfluous non-null assertion, also below.

      Helmut Januschka

      Done

      File third_party/blink/public/devtools_protocol/domains/Emulation.pdl
      File-level comment, Patchset 3:
      Philip Pfaffe . resolved

      No need to include these changes in this CL, they get autorolled from chromium. Once that happens, you can rebase the CL to get rid of them.

      Helmut Januschka

      Done

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Alex Rudenko
      • Philip Pfaffe
      Submit Requirements:
        • requirement satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: devtools/devtools-frontend
        Gerrit-Branch: main
        Gerrit-Change-Id: I0f9f1531d3c1e7ef52bcfa4255b6d68b128b9d34
        Gerrit-Change-Number: 7580093
        Gerrit-PatchSet: 4
        Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
        Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
        Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
        Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
        Gerrit-CC: Changhao Han <chang...@chromium.org>
        Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-CC: Mathias Bynens <mat...@chromium.org>
        Gerrit-Attention: Philip Pfaffe <pfa...@chromium.org>
        Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
        Gerrit-Comment-Date: Wed, 18 Feb 2026 22:04:34 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Comment-In-Reply-To: Philip Pfaffe <pfa...@chromium.org>
        Comment-In-Reply-To: Alex Rudenko <alexr...@chromium.org>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Alex Rudenko (Gerrit)

        unread,
        Feb 19, 2026, 4:46:43 AM (12 days ago) Feb 19
        to Helmut Januschka, Philip Pfaffe, Changhao Han, Mathias Bynens, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
        Attention needed from Helmut Januschka and Philip Pfaffe

        Alex Rudenko added 1 comment

        Patchset-level comments
        File-level comment, Patchset 4 (Latest):
        Alex Rudenko . resolved

        it appears there are some test failures?

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Helmut Januschka
        • Philip Pfaffe
        Submit Requirements:
        • requirement satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: devtools/devtools-frontend
        Gerrit-Branch: main
        Gerrit-Change-Id: I0f9f1531d3c1e7ef52bcfa4255b6d68b128b9d34
        Gerrit-Change-Number: 7580093
        Gerrit-PatchSet: 4
        Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
        Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
        Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
        Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
        Gerrit-CC: Changhao Han <chang...@chromium.org>
        Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-CC: Mathias Bynens <mat...@chromium.org>
        Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
        Gerrit-Attention: Philip Pfaffe <pfa...@chromium.org>
        Gerrit-Comment-Date: Thu, 19 Feb 2026 09:46:38 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Philip Pfaffe (Gerrit)

        unread,
        Feb 19, 2026, 7:55:01 AM (12 days ago) Feb 19
        to Helmut Januschka, Alex Rudenko, Changhao Han, Mathias Bynens, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
        Attention needed from Helmut Januschka

        Philip Pfaffe voted and added 1 comment

        Votes added by Philip Pfaffe

        Code-Review+1

        1 comment

        Patchset-level comments
        Philip Pfaffe . unresolved

        Still LGTM! Any ideas about the tests?

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Helmut Januschka
        Submit Requirements:
          • requirement satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedNo-Unresolved-Comments
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: devtools/devtools-frontend
          Gerrit-Branch: main
          Gerrit-Change-Id: I0f9f1531d3c1e7ef52bcfa4255b6d68b128b9d34
          Gerrit-Change-Number: 7580093
          Gerrit-PatchSet: 4
          Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
          Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
          Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
          Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
          Gerrit-CC: Changhao Han <chang...@chromium.org>
          Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-CC: Mathias Bynens <mat...@chromium.org>
          Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
          Gerrit-Comment-Date: Thu, 19 Feb 2026 12:54:56 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Philip Pfaffe (Gerrit)

          unread,
          Feb 20, 2026, 7:29:30 AM (11 days ago) Feb 20
          to Helmut Januschka, Alex Rudenko, Changhao Han, Mathias Bynens, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
          Attention needed from Helmut Januschka

          Philip Pfaffe voted and added 1 comment

          Votes added by Philip Pfaffe

          Code-Review+1

          1 comment

          Patchset-level comments
          File-level comment, Patchset 4:
          Philip Pfaffe . resolved

          Still LGTM! Any ideas about the tests?

          Philip Pfaffe

          Done

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Helmut Januschka
          Submit Requirements:
            • requirement satisfiedCode-Owners
            • requirement is not satisfiedCode-Review
            • requirement is not satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: devtools/devtools-frontend
            Gerrit-Branch: main
            Gerrit-Change-Id: I0f9f1531d3c1e7ef52bcfa4255b6d68b128b9d34
            Gerrit-Change-Number: 7580093
            Gerrit-PatchSet: 5
            Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
            Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
            Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
            Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
            Gerrit-CC: Changhao Han <chang...@chromium.org>
            Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
            Gerrit-CC: Mathias Bynens <mat...@chromium.org>
            Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
            Gerrit-Comment-Date: Fri, 20 Feb 2026 12:29:26 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: Yes
            Comment-In-Reply-To: Philip Pfaffe <pfa...@chromium.org>
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy

            Alex Rudenko (Gerrit)

            unread,
            Feb 27, 2026, 6:57:05 AM (4 days ago) Feb 27
            to Helmut Januschka, Philip Pfaffe, Changhao Han, Mathias Bynens, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
            Attention needed from Helmut Januschka

            Alex Rudenko voted Code-Review+1

            Code-Review+1
            Open in Gerrit

            Related details

            Attention is currently required from:
            • Helmut Januschka
            Submit Requirements:
            • requirement satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: devtools/devtools-frontend
            Gerrit-Branch: main
            Gerrit-Change-Id: I0f9f1531d3c1e7ef52bcfa4255b6d68b128b9d34
            Gerrit-Change-Number: 7580093
            Gerrit-PatchSet: 5
            Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
            Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
            Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
            Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
            Gerrit-CC: Changhao Han <chang...@chromium.org>
            Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
            Gerrit-CC: Mathias Bynens <mat...@chromium.org>
            Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
            Gerrit-Comment-Date: Fri, 27 Feb 2026 11:56:59 +0000
            Gerrit-HasComments: No
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            open
            diffy

            Helmut Januschka (Gerrit)

            unread,
            Feb 27, 2026, 10:44:55 AM (4 days ago) Feb 27
            to Helmut Januschka, Alex Rudenko, Philip Pfaffe, Changhao Han, Mathias Bynens, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
            Attention needed from Alex Rudenko and Philip Pfaffe

            Helmut Januschka added 1 comment

            Patchset-level comments
            File-level comment, Patchset 6:
            Helmut Januschka . resolved

            sadly rebase revoked cr+1

            Open in Gerrit

            Related details

            Attention is currently required from:
            • Alex Rudenko
            • Philip Pfaffe
            Submit Requirements:
            • requirement satisfiedCode-Owners
            • requirement is not satisfiedCode-Review
            • requirement is not satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: devtools/devtools-frontend
            Gerrit-Branch: main
            Gerrit-Change-Id: I0f9f1531d3c1e7ef52bcfa4255b6d68b128b9d34
            Gerrit-Change-Number: 7580093
            Gerrit-PatchSet: 7
            Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
            Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
            Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
            Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
            Gerrit-CC: Changhao Han <chang...@chromium.org>
            Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
            Gerrit-CC: Mathias Bynens <mat...@chromium.org>
            Gerrit-Attention: Philip Pfaffe <pfa...@chromium.org>
            Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
            Gerrit-Comment-Date: Fri, 27 Feb 2026 15:44:51 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: No
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy

            Alex Rudenko (Gerrit)

            unread,
            Mar 2, 2026, 2:12:06 AM (yesterday) Mar 2
            to Helmut Januschka, Philip Pfaffe, Changhao Han, Mathias Bynens, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
            Attention needed from Helmut Januschka and Philip Pfaffe

            Alex Rudenko voted Code-Review+1

            Code-Review+1
            Open in Gerrit

            Related details

            Attention is currently required from:
            • Helmut Januschka
            • Philip Pfaffe
            Submit Requirements:
            • requirement satisfiedCode-Owners
            • requirement is not satisfiedCode-Review
            • requirement is not satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: devtools/devtools-frontend
            Gerrit-Branch: main
            Gerrit-Change-Id: I0f9f1531d3c1e7ef52bcfa4255b6d68b128b9d34
            Gerrit-Change-Number: 7580093
            Gerrit-PatchSet: 7
            Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
            Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
            Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
            Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
            Gerrit-CC: Changhao Han <chang...@chromium.org>
            Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
            Gerrit-CC: Mathias Bynens <mat...@chromium.org>
            Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
            Gerrit-Attention: Philip Pfaffe <pfa...@chromium.org>
            Gerrit-Comment-Date: Mon, 02 Mar 2026 07:12:01 +0000
            Gerrit-HasComments: No
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy

            Philip Pfaffe (Gerrit)

            unread,
            Mar 2, 2026, 2:29:51 AM (yesterday) Mar 2
            to Helmut Januschka, Alex Rudenko, Changhao Han, Mathias Bynens, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
            Attention needed from Helmut Januschka

            Philip Pfaffe voted Code-Review+1

            Code-Review+1
            Open in Gerrit

            Related details

            Attention is currently required from:
            • Helmut Januschka
            Submit Requirements:
            • requirement satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: devtools/devtools-frontend
            Gerrit-Branch: main
            Gerrit-Change-Id: I0f9f1531d3c1e7ef52bcfa4255b6d68b128b9d34
            Gerrit-Change-Number: 7580093
            Gerrit-PatchSet: 7
            Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
            Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
            Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
            Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
            Gerrit-CC: Changhao Han <chang...@chromium.org>
            Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
            Gerrit-CC: Mathias Bynens <mat...@chromium.org>
            Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
            Gerrit-Comment-Date: Mon, 02 Mar 2026 07:29:47 +0000
            Gerrit-HasComments: No
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            open
            diffy

            Helmut Januschka (Gerrit)

            unread,
            11:34 AM (3 hours ago) 11:34 AM
            to Helmut Januschka, Philip Pfaffe, Alex Rudenko, Changhao Han, Mathias Bynens, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

            Helmut Januschka voted Commit-Queue+2

            Commit-Queue+2
            Open in Gerrit

            Related details

            Attention set is empty
            Submit Requirements:
            • requirement satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: devtools/devtools-frontend
            Gerrit-Branch: main
            Gerrit-Change-Id: I0f9f1531d3c1e7ef52bcfa4255b6d68b128b9d34
            Gerrit-Change-Number: 7580093
            Gerrit-PatchSet: 7
            Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
            Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
            Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
            Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
            Gerrit-CC: Changhao Han <chang...@chromium.org>
            Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
            Gerrit-CC: Mathias Bynens <mat...@chromium.org>
            Gerrit-Comment-Date: Tue, 03 Mar 2026 16:34:24 +0000
            Gerrit-HasComments: No
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            open
            diffy

            Devtools-frontend LUCI CQ (Gerrit)

            unread,
            12:50 PM (2 hours ago) 12:50 PM
            to Helmut Januschka, Philip Pfaffe, Alex Rudenko, Changhao Han, Mathias Bynens, devtools-rev...@chromium.org

            Devtools-frontend LUCI CQ submitted the change

            Change information

            Commit message:
            DevTools: Support screen.orientation.lock() in device emulation

            Handle the new CDP event Emulation.screenOrientationLockChanged to rotate
            the emulated device to match the locked orientation and disable the rotate
            button while the lock is active.
            Bug: 40807290
            Change-Id: I0f9f1531d3c1e7ef52bcfa4255b6d68b128b9d34
            Reviewed-by: Alex Rudenko <alexr...@chromium.org>
            Reviewed-by: Philip Pfaffe <pfa...@chromium.org>
            Commit-Queue: Helmut Januschka <hel...@januschka.com>
            Files:
            • M front_end/core/protocol_client/InspectorBackend.ts
            • M front_end/core/sdk/EmulationModel.test.ts
            • M front_end/core/sdk/EmulationModel.ts
            • M front_end/generated/InspectorBackendCommands.ts
            • M front_end/generated/protocol-mapping.d.ts
            • M front_end/generated/protocol-proxy-api.d.ts
            • M front_end/generated/protocol.ts
            • M front_end/models/emulation/DeviceModeModel.test.ts
            • M front_end/models/emulation/DeviceModeModel.ts
            • M front_end/panels/emulation/BUILD.gn
            • A front_end/panels/emulation/DeviceModeToolbar.test.ts
            • M front_end/panels/emulation/DeviceModeToolbar.ts
            • M third_party/blink/public/devtools_protocol/browser_protocol.json
            • M third_party/blink/public/devtools_protocol/domains/Emulation.pdl
            Change size: L
            Delta: 14 files changed, 419 insertions(+), 1 deletion(-)
            Branch: refs/heads/main
            Submit Requirements:
            • requirement satisfiedCode-Review: +1 by Philip Pfaffe, +1 by Alex Rudenko
            Open in Gerrit
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: merged
            Gerrit-Project: devtools/devtools-frontend
            Gerrit-Branch: main
            Gerrit-Change-Id: I0f9f1531d3c1e7ef52bcfa4255b6d68b128b9d34
            Gerrit-Change-Number: 7580093
            Gerrit-PatchSet: 8
            Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
            Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
            Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
            Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
            Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
            Gerrit-CC: Changhao Han <chang...@chromium.org>
            Gerrit-CC: Mathias Bynens <mat...@chromium.org>
            open
            diffy
            satisfied_requirement
            Reply all
            Reply to author
            Forward
            0 new messages