Introduce DBSC-SSO Error Codes and metrics. [chromium/src : main]
0 views
Skip to first unread message
Jan Wilken Dörrie (Gerrit)
Jul 2, 2026, 9:54:15 AM (2 days ago) Jul 2
to Lucas Santos, android-bu...@system.gserviceaccount.com, Mike West, Chromium IPC Reviews, Alex Ilin, Chromium Metrics Reviews, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, devtools...@chromium.org, asvitkine...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
Attention needed from Alex Ilin, Lucas Santos and Mike West
Jan Wilken Dörrie voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jan Wilken Dörrie
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Jan Wilken Dörrie . resolved
non-OWNERS LGTM. I probably caused merge conflicts for you 😐
Related details
Attention is currently required from:
- Alex Ilin
- Lucas Santos
- Mike West
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lucas Santos (Gerrit)
Jul 2, 2026, 11:11:09 AM (2 days ago) Jul 2
to Alex Rudenko, Jan Wilken Dörrie, android-bu...@system.gserviceaccount.com, Mike West, Chromium IPC Reviews, Alex Ilin, Chromium Metrics Reviews, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, devtools...@chromium.org, asvitkine...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
Attention needed from Alex Ilin, Alex Rudenko and Mike West
Lucas Santos added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4:
Lucas Santos . resolved
alexrudenko@ adding you because of content/browser/devtools/protocol/network_handler.cc changes.
Related details
Attention is currently required from:
- Alex Ilin
- Alex Rudenko
- Mike West
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Jul 3, 2026, 1:47:21 AM (yesterday) Jul 3
to Lucas Santos, Jan Wilken Dörrie, android-bu...@system.gserviceaccount.com, Mike West, Chromium IPC Reviews, Alex Ilin, Chromium Metrics Reviews, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, devtools...@chromium.org, asvitkine...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
Attention needed from Alex Ilin, Lucas Santos and Mike West
Alex Rudenko voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alex Ilin
- Lucas Santos
- Mike West
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lucas Santos (Gerrit)
Jul 3, 2026, 3:18:44 AM (yesterday) Jul 3
to Alex Rudenko, Jan Wilken Dörrie, android-bu...@system.gserviceaccount.com, Mike West, Chromium IPC Reviews, Alex Ilin, Chromium Metrics Reviews, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, devtools...@chromium.org, asvitkine...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
Attention needed from Alex Ilin and Mike West
Lucas Santos added 1 comment![]( "Open in Gerrit")
File services/network/public/mojom/device_bound_sessions.mojom
Line 213, Patchset 3:
kPreProvisionedKeyNotFound = 88,Mike West . resolved
Lucas Santosmojo enum additions lgtm.
marking as `Resolved`.
Related details
Attention is currently required from:
- Alex Ilin
- Mike West
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Ilin (Gerrit)
Jul 3, 2026, 6:32:39 AM (yesterday) Jul 3
to Lucas Santos, Alex Rudenko, Jan Wilken Dörrie, android-bu...@system.gserviceaccount.com, Mike West, Chromium IPC Reviews, Alex Ilin, Chromium Metrics Reviews, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, devtools...@chromium.org, asvitkine...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
Attention needed from Lucas Santos and Mike West
Alex Ilin added 2 comments![]( "Open in Gerrit")
File net/device_bound_sessions/session_error.h
Line 109, Patchset 5 (Latest):
kInvalidPreProvisionedKeyProviderKeyMissing = 84,Alex Ilin . unresolved
Looking at https://crrev.com/c/8031426, the presence of provider_key is a precondition for calling `FindPreProvisionedKey()` and initiating the SSO pre-provisioned key flow. So it looks like this error is impossible to trigger.
Moreover, the presence of provider_key requires provider_url to be present as well. If this condition isn't satisfied, the header parsing will fail earlier [1]
So it feels like `FindPreProvisionedKey()` should do `CHECK(param.provider_key()); CHECK(param.provider_url())` instead of returning these errors.
File tools/metrics/histograms/metadata/net/histograms.xml
Line 2438, Patchset 5 (Latest):
<histogram name="Net.DeviceBoundSessions.ProviderKeyMatchOutcome"Alex Ilin . unresolved
Please add a histogram and documentation in the same CL. It looks like the histogram addition can be made in a follow-up CL.
Related details
Attention is currently required from:
- Lucas Santos
- Mike West
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lucas Santos (Gerrit)
Jul 3, 2026, 9:04:38 AM (yesterday) Jul 3
to Alex Rudenko, Jan Wilken Dörrie, android-bu...@system.gserviceaccount.com, Mike West, Chromium IPC Reviews, Alex Ilin, Chromium Metrics Reviews, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, devtools...@chromium.org, asvitkine...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
Attention needed from Alex Ilin, Alex Rudenko, Jan Wilken Dörrie and Mike West
Lucas Santos added 2 comments![]( "Open in Gerrit")
File net/device_bound_sessions/session_error.h
Looking at https://crrev.com/c/8031426, the presence of provider_key is a precondition for calling `FindPreProvisionedKey()` and initiating the SSO pre-provisioned key flow. So it looks like this error is impossible to trigger.
Moreover, the presence of provider_key requires provider_url to be present as well. If this condition isn't satisfied, the header parsing will fail earlier [1]
So it feels like `FindPreProvisionedKey()` should do `CHECK(param.provider_key()); CHECK(param.provider_url())` instead of returning these errors.
Lucas Santos
Nice catch, thanks! Done.
File tools/metrics/histograms/metadata/net/histograms.xml
Line 2438, Patchset 5:
<histogram name="Net.DeviceBoundSessions.ProviderKeyMatchOutcome"Alex Ilin . resolved
Please add a histogram and documentation in the same CL. It looks like the histogram addition can be made in a follow-up CL.
Attention is currently required from:
- Alex Ilin
- Alex Rudenko
- Jan Wilken Dörrie
- Mike West
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Ilin (Gerrit)
Jul 3, 2026, 10:13:50 AM (yesterday) Jul 3
to Lucas Santos, Alex Ilin, Alex Rudenko, Jan Wilken Dörrie, android-bu...@system.gserviceaccount.com, Mike West, Chromium IPC Reviews, Chromium Metrics Reviews, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, devtools...@chromium.org, asvitkine...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
Attention needed from Alex Rudenko, Jan Wilken Dörrie, Lucas Santos and Mike West
Alex Ilin voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Alex Rudenko
- Jan Wilken Dörrie
- Lucas Santos
- Mike West
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Ilin (Gerrit)
Jul 3, 2026, 10:16:04 AM (yesterday) Jul 3
to Lucas Santos, Alex Ilin, Alex Rudenko, Jan Wilken Dörrie, android-bu...@system.gserviceaccount.com, Mike West, Chromium IPC Reviews, Chromium Metrics Reviews, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, devtools...@chromium.org, asvitkine...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
Attention needed from Alex Rudenko, Jan Wilken Dörrie, Lucas Santos and Mike West
Alex Ilin added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Alex Ilin . resolved
LGTM, thanks!
Alex Ilin
P.S. It seems like you need to resolve a merge conflict before this CL can be submitted.
Pull latest commits, rebase your CL on top of a new HEAD (resolving the conflicts along the way), and then re-upload it.
Alex Ilin (Gerrit)
Jul 3, 2026, 12:09:37 PM (yesterday) Jul 3
to Lucas Santos, Alex Ilin, Alex Rudenko, Jan Wilken Dörrie, android-bu...@system.gserviceaccount.com, Mike West, Chromium IPC Reviews, Chromium Metrics Reviews, chromium...@chromium.org, ddrone...@google.com, cc-...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, devtools...@chromium.org, asvitkine...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
Attention needed from Alex Rudenko, Jan Wilken Dörrie, Lucas Santos and Mike West
Alex Ilin voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Alex Rudenko
- Jan Wilken Dörrie
- Lucas Santos
- Mike West
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages