Remove dead code [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Nikolay Vitkov (Gerrit)

unread,
5:08 AM (3 hours ago) 5:08 AM
to Simon Zünd, devtools-rev...@chromium.org

Nikolay Vitkov voted and added 1 comment

Votes added by Nikolay Vitkov

Auto-Submit+1

1 comment

Commit Message
Line 7, Patchset 2:Remove death code
Simon Zünd . resolved

```suggestion
Remove dead code
```

Nikolay Vitkov

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: Ia578aaa3b409266f4ea9c4cf9948d01452bf2138
Gerrit-Change-Number: 7691250
Gerrit-PatchSet: 3
Gerrit-Owner: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
Gerrit-Comment-Date: Tue, 24 Mar 2026 09:08:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Simon Zünd <szu...@chromium.org>
satisfied_requirement
open
diffy

Nikolay Vitkov (Gerrit)

unread,
5:08 AM (3 hours ago) 5:08 AM
to Simon Zünd, devtools-rev...@chromium.org

Nikolay Vitkov voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: Ia578aaa3b409266f4ea9c4cf9948d01452bf2138
Gerrit-Change-Number: 7691250
Gerrit-PatchSet: 3
Gerrit-Owner: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
Gerrit-Comment-Date: Tue, 24 Mar 2026 09:08:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,
5:40 AM (3 hours ago) 5:40 AM
to Nikolay Vitkov, Simon Zünd, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Unreviewed changes

2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
Remove dead code

I search for this but this was never check in other places.
Nor the sub-classes that extend it extend anything that has this.
Bug: 454624251
Change-Id: Ia578aaa3b409266f4ea9c4cf9948d01452bf2138
Reviewed-by: Simon Zünd <szu...@chromium.org>
Auto-Submit: Nikolay Vitkov <nvi...@chromium.org>
Commit-Queue: Nikolay Vitkov <nvi...@chromium.org>
Files:
  • M front_end/panels/profiler/ProfileView.ts
Change size: XS
Delta: 1 file changed, 0 insertions(+), 9 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Simon Zünd
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: Ia578aaa3b409266f4ea9c4cf9948d01452bf2138
Gerrit-Change-Number: 7691250
Gerrit-PatchSet: 4
Gerrit-Owner: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages