[AI] Use response suggestions UX in performance agent [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Connor Clark (Gerrit)
Sep 19, 2025, 1:44:34 PM (6 days ago) Sep 19
to Paul Irish, devtools-rev...@chromium.org
Attention needed from Paul Irish
Connor Clark voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Paul Irish
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Connor Clark (Gerrit)
Sep 22, 2025, 1:22:15 PM (3 days ago) Sep 22
to Devtools-frontend LUCI CQ, Paul Irish, devtools-rev...@chromium.org
Attention needed from Paul Irish
Connor Clark voted Auto-Submit+0![]( "Open in Gerrit")
| Auto-Submit | +0 |
Related details
Attention is currently required from:
- Paul Irish
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Connor Clark (Gerrit)
Sep 22, 2025, 1:25:30 PM (3 days ago) Sep 22
to Alex Rudenko, Devtools-frontend LUCI CQ, Paul Irish, devtools-rev...@chromium.org
Attention needed from Alex Rudenko and Paul Irish
Connor Clark added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Connor Clark . unresolved
Alex: this seems to work most of the time, but often I see that "SUGGESTIONS" is not on its own line.
Which of these would you like to explore first?SUGGESTIONS: ["Tell me more about LCP render delay.", "Which resources are render blocking?", "What is IP Protect doing on the main thread?"]
<end of response>
Do you have an idea why that might be? I could just make the parser that gets SUGGESTIONS out of the response smarter, but I'm wondering if I'm doing something obviously wrong here.
Related details
Attention is currently required from:
- Alex Rudenko
- Paul Irish
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Irish (Gerrit)
Sep 22, 2025, 3:03:36 PM (2 days ago) Sep 22
to Connor Clark, Alex Rudenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Alex Rudenko and Connor Clark
Paul Irish voted and added 1 comment![]( "Open in Gerrit")
Votes added by Paul Irish
| Code-Review | +1 |
1 comment
File front_end/models/ai_assistance/agents/PerformanceAgent.test.ts
Line 545, Patchset 5 (Latest):
'devtools', 'devtools', 'devtools', 'devtools', 'devtools', 'devtools', 'devtools',Paul Irish . resolved
lol
Related details
Attention is currently required from:
- Alex Rudenko
- Connor Clark
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Connor Clark (Gerrit)
Sep 22, 2025, 8:33:56 PM (2 days ago) Sep 22
to Paul Irish, Alex Rudenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Alex Rudenko and Paul Irish
Connor Clark added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Alex: this seems to work most of the time, but often I see that "SUGGESTIONS" is not on its own line.
Which of these would you like to explore first?SUGGESTIONS: ["Tell me more about LCP render delay.", "Which resources are render blocking?", "What is IP Protect doing on the main thread?"]
<end of response>Do you have an idea why that might be? I could just make the parser that gets SUGGESTIONS out of the response smarter, but I'm wondering if I'm doing something obviously wrong here.
Connor Clark
I ended up adding extra code to just detect the unexpected edge case.
Related details
Attention is currently required from:
- Alex Rudenko
- Paul Irish
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Connor Clark (Gerrit)
Sep 22, 2025, 8:34:04 PM (2 days ago) Sep 22
to Paul Irish, Alex Rudenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Alex Rudenko and Paul Irish
Connor Clark voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Alex Rudenko
- Paul Irish
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Irish (Gerrit)
Sep 22, 2025, 8:36:57 PM (2 days ago) Sep 22
to Connor Clark, Alex Rudenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Alex Rudenko and Connor Clark
Paul Irish voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alex Rudenko
- Connor Clark
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Connor Clark (Gerrit)
Sep 22, 2025, 8:40:06 PM (2 days ago) Sep 22
to Paul Irish, Alex Rudenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Alex Rudenko
Connor Clark voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Alex Rudenko
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
Sep 22, 2025, 9:17:56 PM (2 days ago) Sep 22
to Connor Clark, Paul Irish, Alex Rudenko, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[AI] Use response suggestions UX in performance agent
Bug: 425270067
Change-Id: Ia7866ad0159ff8cfc4a32699ea6f3ae3d1625bd6
Auto-Submit: Connor Clark <cja...@chromium.org>
Reviewed-by: Paul Irish <paul...@chromium.org>
Commit-Queue: Connor Clark <cja...@chromium.org>
Files:
- M front_end/models/ai_assistance/agents/PerformanceAgent.ts
Change size: M
Delta: 1 file changed, 60 insertions(+), 9 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Paul Irish
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Sep 23, 2025, 2:06:16 AM (2 days ago) Sep 23
to Connor Clark, Devtools-frontend LUCI CQ, Paul Irish, devtools-rev...@chromium.org
Attention needed from Connor Clark
Alex Rudenko added 1 comment![]( "Open in Gerrit")
File front_end/models/ai_assistance/agents/PerformanceAgent.ts
Line 423, Patchset 7 (Latest):
#parseSuggestions(text: string): ParsedResponse {Alex Rudenko . unresolved
let's extract this to the base class and re-use in both performance and the styling agents.
Related details
Attention is currently required from:
- Connor Clark
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Connor Clark (Gerrit)
Sep 23, 2025, 2:58:55 PM (2 days ago) Sep 23
to Devtools-frontend LUCI CQ, Paul Irish, Alex Rudenko, devtools-rev...@chromium.org
Connor Clark added 1 comment![]( "Open in Gerrit")
File front_end/models/ai_assistance/agents/PerformanceAgent.ts
Line 423, Patchset 7 (Latest):
#parseSuggestions(text: string): ParsedResponse {Alex Rudenko . resolved
let's extract this to the base class and re-use in both performance and the styling agents.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages