CDP API and backend support for CSS navigation queries [chromium/src : main]
AI Code Reviewer (Gerrit)
AI Code Reviewer added 1 comment![]( "Open in Gerrit")
const String& selector,nit: Parameter names 'selector' and 'old_selector' are misleading for a navigation rule and inconsistent with the implementation. Consider renaming to 'text' and 'old_text' to match the implementation and semantics. (Blink Style Guide: Naming - Be Descriptive)
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason
_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your π feedback π to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
Related details
- Alex Rudenko
- Philip Pfaffe
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Pfaffe (Gerrit)
Philip Pfaffe voted and added 2 comments![]( "Open in Gerrit")
Votes added by Philip Pfaffe
| Code-Review | +1 |
2 comments
// Prefer ConditionTextInternal for internal use. (Avoids UseCounter).This does not match the implementation.
Related details
- Alex Rudenko
- Eric Leese
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eric Leese (Gerrit)
Eric Leese added 2 comments![]( "Open in Gerrit")
// Prefer ConditionTextInternal for internal use. (Avoids UseCounter).This does not match the implementation.
Good point. This is a standard interface used by other condition rules, and they typically have this comment, but I can remove the (Avoids UseCounter) part.
nit: Parameter names 'selector' and 'old_selector' are misleading for a navigation rule and inconsistent with the implementation. Consider renaming to 'text' and 'old_text' to match the implementation and semantics. (Blink Style Guide: Naming - Be Descriptive)
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason
_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your π feedback π to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
- Alex Rudenko
- Philip Pfaffe
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eric Leese (Gerrit)
Eric Leese added 1 comment![]( "Open in Gerrit")
// Prefer ConditionTextInternal for internal use. (Avoids UseCounter).Eric LeeseThis does not match the implementation.
Good point. This is a standard interface used by other condition rules, and they typically have this comment, but I can remove the (Avoids UseCounter) part.
Done
Related details
- Alex Rudenko
- Philip Pfaffe
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |