Remove skipped Dialog tests [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Alex Rudenko (Gerrit)
Jul 3, 2026, 9:20:49 AM (yesterday) Jul 3
to Nicholas Roscino, devtools-rev...@chromium.org
Attention needed from Nicholas Roscino
Alex Rudenko voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Nicholas Roscino
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Roscino (Gerrit)
Jul 3, 2026, 9:21:48 AM (yesterday) Jul 3
to Alex Rudenko, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Alex Rudenko
Nicholas Roscino voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nicholas Roscino
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Alex Rudenko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jul 3, 2026, 9:56:15 AM (yesterday) Jul 3
to Alex Rudenko, Nicholas Roscino, devtools-rev...@chromium.org
devtools-fro...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove skipped Dialog tests
It is unlikely that we prioritize fixing this test given that the Dialog
component is deprecated.
Fixed: 420924642
Change-Id: I3302888545cc1baa195e7eb5d45e77531223f485
Reviewed-by: Nicholas Roscino <nros...@chromium.org>
Auto-Submit: Alex Rudenko <alexr...@chromium.org>
Commit-Queue: Alex Rudenko <alexr...@chromium.org>
Commit-Queue: Nicholas Roscino <nros...@chromium.org>
Files:
- M front_end/ui/components/dialogs/Dialog.test.ts
- M front_end/ui/components/dialogs/Dialog.ts
Change size: S
Delta: 2 files changed, 3 insertions(+), 37 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nicholas Roscino
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages