Add view-source adorner next to the root node in the Elements panel [devtools/devtools-frontend : main]

4 views
Skip to first unread message

Kateryna Prokopenko (Gerrit)

unread,
Nov 27, 2025, 8:19:32 AM (4 days ago) Nov 27
to Benedikt Meurer, devtools-rev...@chromium.org
Attention needed from Benedikt Meurer

Kateryna Prokopenko voted and added 1 comment

Votes added by Kateryna Prokopenko

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Kateryna Prokopenko . resolved

Benedikt, could you please take a look?

Open in Gerrit

Related details

Attention is currently required from:
  • Benedikt Meurer
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I35d04451727f8e79f544e85f951e865276ac566f
Gerrit-Change-Number: 7205539
Gerrit-PatchSet: 4
Gerrit-Owner: Kateryna Prokopenko <kprok...@chromium.org>
Gerrit-Reviewer: Benedikt Meurer <bme...@chromium.org>
Gerrit-Reviewer: Kateryna Prokopenko <kprok...@chromium.org>
Gerrit-Attention: Benedikt Meurer <bme...@chromium.org>
Gerrit-Comment-Date: Thu, 27 Nov 2025 13:19:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Benedikt Meurer (Gerrit)

unread,
Nov 27, 2025, 8:45:04 AM (4 days ago) Nov 27
to Kateryna Prokopenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Kateryna Prokopenko

Benedikt Meurer voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Kateryna Prokopenko
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I35d04451727f8e79f544e85f951e865276ac566f
Gerrit-Change-Number: 7205539
Gerrit-PatchSet: 4
Gerrit-Owner: Kateryna Prokopenko <kprok...@chromium.org>
Gerrit-Reviewer: Benedikt Meurer <bme...@chromium.org>
Gerrit-Reviewer: Kateryna Prokopenko <kprok...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Kateryna Prokopenko <kprok...@chromium.org>
Gerrit-Comment-Date: Thu, 27 Nov 2025 13:44:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Alex Rudenko (Gerrit)

unread,
Nov 28, 2025, 1:38:05 AM (3 days ago) Nov 28
to Kateryna Prokopenko, Benedikt Meurer, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Benedikt Meurer and Kateryna Prokopenko

Alex Rudenko added 1 comment

File front_end/panels/elements/ElementsTreeElement.ts
Line 481, Patchset 4 (Latest): if (this.nodeInternal.nodeType() === Node.ELEMENT_NODE && node.nodeName() === 'HTML') {
Alex Rudenko . unresolved

Let's add new adorners in the declarative way in the DEFAULT_VIEW function and add a test for the new adorner?

Open in Gerrit

Related details

Attention is currently required from:
  • Benedikt Meurer
  • Kateryna Prokopenko
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: devtools/devtools-frontend
    Gerrit-Branch: main
    Gerrit-Change-Id: I35d04451727f8e79f544e85f951e865276ac566f
    Gerrit-Change-Number: 7205539
    Gerrit-PatchSet: 4
    Gerrit-Owner: Kateryna Prokopenko <kprok...@chromium.org>
    Gerrit-Reviewer: Benedikt Meurer <bme...@chromium.org>
    Gerrit-Reviewer: Kateryna Prokopenko <kprok...@chromium.org>
    Gerrit-CC: Alex Rudenko <alexr...@chromium.org>
    Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Attention: Benedikt Meurer <bme...@chromium.org>
    Gerrit-Attention: Kateryna Prokopenko <kprok...@chromium.org>
    Gerrit-Comment-Date: Fri, 28 Nov 2025 06:38:01 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Kateryna Prokopenko (Gerrit)

    unread,
    Nov 28, 2025, 12:07:41 PM (3 days ago) Nov 28
    to Alex Rudenko, Benedikt Meurer, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
    Attention needed from Alex Rudenko and Benedikt Meurer

    Kateryna Prokopenko voted and added 2 comments

    Votes added by Kateryna Prokopenko

    Auto-Submit+1
    Commit-Queue+1

    2 comments

    Patchset-level comments
    File-level comment, Patchset 6 (Latest):
    Kateryna Prokopenko . resolved

    Please take another look?:)

    File front_end/panels/elements/ElementsTreeElement.ts
    Line 481, Patchset 4: if (this.nodeInternal.nodeType() === Node.ELEMENT_NODE && node.nodeName() === 'HTML') {
    Alex Rudenko . resolved

    Let's add new adorners in the declarative way in the DEFAULT_VIEW function and add a test for the new adorner?

    Kateryna Prokopenko

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alex Rudenko
    • Benedikt Meurer
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: devtools/devtools-frontend
    Gerrit-Branch: main
    Gerrit-Change-Id: I35d04451727f8e79f544e85f951e865276ac566f
    Gerrit-Change-Number: 7205539
    Gerrit-PatchSet: 6
    Gerrit-Owner: Kateryna Prokopenko <kprok...@chromium.org>
    Gerrit-Reviewer: Benedikt Meurer <bme...@chromium.org>
    Gerrit-Reviewer: Kateryna Prokopenko <kprok...@chromium.org>
    Gerrit-CC: Alex Rudenko <alexr...@chromium.org>
    Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Attention: Benedikt Meurer <bme...@chromium.org>
    Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Comment-Date: Fri, 28 Nov 2025 17:07:37 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Alex Rudenko <alexr...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Alex Rudenko (Gerrit)

    unread,
    3:09 AM (6 hours ago) 3:09 AM
    to Kateryna Prokopenko, Benedikt Meurer, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
    Attention needed from Benedikt Meurer and Kateryna Prokopenko

    Alex Rudenko added 1 comment

    File front_end/panels/elements/ElementsTreeElement.ts
    Line 741, Patchset 6 (Latest): showViewSourceAdorner: ElementsPanel.instance().isAdornerEnabled(
    Alex Rudenko . unresolved
    The previous version had a bug. Could you please remove the part `ElementsPanel.instance().isAdornerEnabled(
                                         ElementsComponents.AdornerManager.RegisteredAdorners.VIEW_SOURCE) &&` from here? The adorner ref takes care of it now.
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Benedikt Meurer
    • Kateryna Prokopenko
    Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: devtools/devtools-frontend
      Gerrit-Branch: main
      Gerrit-Change-Id: I35d04451727f8e79f544e85f951e865276ac566f
      Gerrit-Change-Number: 7205539
      Gerrit-PatchSet: 6
      Gerrit-Owner: Kateryna Prokopenko <kprok...@chromium.org>
      Gerrit-Reviewer: Benedikt Meurer <bme...@chromium.org>
      Gerrit-Reviewer: Kateryna Prokopenko <kprok...@chromium.org>
      Gerrit-CC: Alex Rudenko <alexr...@chromium.org>
      Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Attention: Benedikt Meurer <bme...@chromium.org>
      Gerrit-Attention: Kateryna Prokopenko <kprok...@chromium.org>
      Gerrit-Comment-Date: Mon, 01 Dec 2025 08:09:24 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages