Fix forcing @starting-style on pseudo-elements in DevTools [chromium/src : main]

0 views
Skip to first unread message

Robert Flack (Gerrit)

unread,
Jul 2, 2026, 2:13:15 PM (2 days ago) Jul 2
to Eric Leese, Menard, Alexis, Olga Gerchikov, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Philip Pfaffe, blink-revie...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, devtools-re...@chromium.org, apavlo...@chromium.org
Attention needed from Eric Leese and Philip Pfaffe

Robert Flack added 1 comment

File third_party/blink/renderer/core/animation/css/css_animations.cc
Line 2993, Patchset 2 (Latest): &To<PseudoElement>(animating_element).UltimateOriginatingElement(),
Robert Flack . unresolved

Technically if we're considering the force starting style state of the pseudo-element and the originating element we should probably also consider all of the parents between the pseudo-element and the originating element. I.e. in the case of view transtiions there can be many, but there is also the case of `::before::marker`, see https://jsbin.com/pocuwis/edit?html,css,output

Open in Gerrit

Related details

Attention is currently required from:
  • Eric Leese
  • Philip Pfaffe
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idc3ad0861ec07223065044421da3e4a871ea6fe1
Gerrit-Change-Number: 8024864
Gerrit-PatchSet: 2
Gerrit-Owner: Eric Leese <le...@chromium.org>
Gerrit-Reviewer: Eric Leese <le...@chromium.org>
Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Attention: Philip Pfaffe <pfa...@chromium.org>
Gerrit-Attention: Eric Leese <le...@chromium.org>
Gerrit-Comment-Date: Thu, 02 Jul 2026 18:13:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Eric Leese (Gerrit)

unread,
Jul 3, 2026, 6:03:21 AM (yesterday) Jul 3
to Robert Flack, Menard, Alexis, Olga Gerchikov, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Philip Pfaffe, blink-revie...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, devtools-re...@chromium.org, apavlo...@chromium.org
Attention needed from Philip Pfaffe and Robert Flack

Eric Leese added 1 comment

File third_party/blink/renderer/core/animation/css/css_animations.cc
Line 2993, Patchset 2: &To<PseudoElement>(animating_element).UltimateOriginatingElement(),
Robert Flack . resolved

Technically if we're considering the force starting style state of the pseudo-element and the originating element we should probably also consider all of the parents between the pseudo-element and the originating element. I.e. in the case of view transtiions there can be many, but there is also the case of `::before::marker`, see https://jsbin.com/pocuwis/edit?html,css,output

Eric Leese

I've changed it to loop until hitting a non-pseudo-element.

Open in Gerrit

Related details

Attention is currently required from:
  • Philip Pfaffe
  • Robert Flack
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idc3ad0861ec07223065044421da3e4a871ea6fe1
    Gerrit-Change-Number: 8024864
    Gerrit-PatchSet: 3
    Gerrit-Owner: Eric Leese <le...@chromium.org>
    Gerrit-Reviewer: Eric Leese <le...@chromium.org>
    Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
    Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Attention: Philip Pfaffe <pfa...@chromium.org>
    Gerrit-Attention: Robert Flack <fla...@chromium.org>
    Gerrit-Comment-Date: Fri, 03 Jul 2026 10:03:02 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Robert Flack <fla...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Robert Flack (Gerrit)

    unread,
    Jul 3, 2026, 12:56:55 PM (yesterday) Jul 3
    to Eric Leese, Menard, Alexis, Olga Gerchikov, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Philip Pfaffe, blink-revie...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, devtools-re...@chromium.org, apavlo...@chromium.org
    Attention needed from Eric Leese and Philip Pfaffe

    Robert Flack voted and added 1 comment

    Votes added by Robert Flack

    Code-Review+1

    1 comment

    File third_party/blink/renderer/core/animation/css/css_animations.cc
    Line 2991, Patchset 3 (Latest): // Also check parents if it is a pseudo element.
    Robert Flack . unresolved

    nit: comment suggests we check all parents, maybe something like
    // Check all pseudo element parents and originating element for pseudo elements.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Eric Leese
    • Philip Pfaffe
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idc3ad0861ec07223065044421da3e4a871ea6fe1
    Gerrit-Change-Number: 8024864
    Gerrit-PatchSet: 3
    Gerrit-Owner: Eric Leese <le...@chromium.org>
    Gerrit-Reviewer: Eric Leese <le...@chromium.org>
    Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
    Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Attention: Philip Pfaffe <pfa...@chromium.org>
    Gerrit-Attention: Eric Leese <le...@chromium.org>
    Gerrit-Comment-Date: Fri, 03 Jul 2026 16:56:45 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Eric Leese (Gerrit)

    unread,
    Jul 3, 2026, 1:27:54 PM (yesterday) Jul 3
    to Robert Flack, Menard, Alexis, Olga Gerchikov, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Philip Pfaffe, blink-revie...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, devtools-re...@chromium.org, apavlo...@chromium.org
    Attention needed from Philip Pfaffe

    Eric Leese added 1 comment

    File third_party/blink/renderer/core/animation/css/css_animations.cc
    Line 2991, Patchset 3: // Also check parents if it is a pseudo element.
    Robert Flack . resolved

    nit: comment suggests we check all parents, maybe something like
    // Check all pseudo element parents and originating element for pseudo elements.

    Eric Leese

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Philip Pfaffe
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Idc3ad0861ec07223065044421da3e4a871ea6fe1
      Gerrit-Change-Number: 8024864
      Gerrit-PatchSet: 4
      Gerrit-Owner: Eric Leese <le...@chromium.org>
      Gerrit-Reviewer: Eric Leese <le...@chromium.org>
      Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
      Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
      Gerrit-Attention: Philip Pfaffe <pfa...@chromium.org>
      Gerrit-Comment-Date: Fri, 03 Jul 2026 17:27:31 +0000
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages