[MiraclePtr] Rewrite templated container fields to raw_ptr [chromium/src : main]

0 views

Skip to first unread message

José Arturo Barrera (Gerrit)

unread,

Jul 1, 2026, 8:57:02 PM (3 days ago) Jul 1

to Arthur Sonzogni, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Peter Beverloo, Sadrul Chowdhury, ayman...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, dewitt...@chromium.org, dibyapal+wa...@chromium.org, extension...@chromium.org, mdjone...@chromium.org, mfoltz+wa...@chromium.org, performance-m...@chromium.org, yuezhang...@chromium.org

Attention needed from Arthur Sonzogni

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Arthur Sonzogni

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Arthur Sonzogni (Gerrit)

unread,

Jul 2, 2026, 4:20:19 AM (2 days ago) Jul 2

to José Arturo Barrera, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Peter Beverloo, Sadrul Chowdhury, ayman...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, dewitt...@chromium.org, dibyapal+wa...@chromium.org, extension...@chromium.org, mdjone...@chromium.org, mfoltz+wa...@chromium.org, performance-m...@chromium.org, yuezhang...@chromium.org

Attention needed from José Arturo Barrera

Arthur Sonzogni added 2 comments

Patchset-level comments

File-level comment, Patchset 8 (Latest):

Arthur Sonzogni . resolved

Thanks!

File chrome/browser/performance_manager/policies/background_tab_loading_policy_unittest.cc

Line 54, Patchset 8 (Latest):


  std::vector<raw_ptr<const PageNode>> GetPageNodesToLoad(
      const PageNode* page_node) override {
    std::vector<raw_ptr<const PageNode, DanglingUntriaged>> to_load =
        split_nodes_map_[page_node];
    if (to_load.empty()) {
      return {page_node};
    } else {
      return base::ToVector(to_load, [](const auto& node) {
        return raw_ptr<const PageNode>(node.get());
      });
    }
  }

  void AddTabSplit(std::vector<raw_ptr<const PageNode>> split_nodes) {
    // Tab splits are symmetrical: return all pages provided in `split_nodes`
    // when looking up any of them. The pointers are converted to
    // DanglingUntriaged to safely survive test teardown.
    auto dangling_nodes = base::ToVector(split_nodes, [](const auto& node) {
      return raw_ptr<const PageNode, DanglingUntriaged>(node.get());
    });
    for (const PageNode* page_node : split_nodes) {
      split_nodes_map_[page_node] = dangling_nodes;
    }
  }

 private:
  std::map<const PageNode*,
           std::vector<raw_ptr<const PageNode, DanglingUntriaged>>>
      split_nodes_map_;

Arthur Sonzogni . unresolved

Converting from raw_ptr to raw_ptr<DanglingUntriaged> is okay, but the opposite direction isn't.

I feel this part of the change is going to be challenging. What about extracting it out and land everything else?

Open in Gerrit

Related details

Attention is currently required from:

José Arturo Barrera

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

José Arturo Barrera (Gerrit)

unread,

Jul 3, 2026, 8:56:18 AM (yesterday) Jul 3

Attention needed from Arthur Sonzogni

José Arturo Barrera added 1 comment

File chrome/browser/performance_manager/policies/background_tab_loading_policy_unittest.cc

Line 54, Patchset 8:


  std::vector<raw_ptr<const PageNode>> GetPageNodesToLoad(
      const PageNode* page_node) override {
    std::vector<raw_ptr<const PageNode, DanglingUntriaged>> to_load =
        split_nodes_map_[page_node];
    if (to_load.empty()) {
      return {page_node};
    } else {
      return base::ToVector(to_load, [](const auto& node) {
        return raw_ptr<const PageNode>(node.get());
      });
    }
  }

  void AddTabSplit(std::vector<raw_ptr<const PageNode>> split_nodes) {
    // Tab splits are symmetrical: return all pages provided in `split_nodes`
    // when looking up any of them. The pointers are converted to
    // DanglingUntriaged to safely survive test teardown.
    auto dangling_nodes = base::ToVector(split_nodes, [](const auto& node) {
      return raw_ptr<const PageNode, DanglingUntriaged>(node.get());
    });
    for (const PageNode* page_node : split_nodes) {
      split_nodes_map_[page_node] = dangling_nodes;
    }
  }

 private:
  std::map<const PageNode*,
           std::vector<raw_ptr<const PageNode, DanglingUntriaged>>>
      split_nodes_map_;

Arthur Sonzogni . resolved

Converting from raw_ptr to raw_ptr<DanglingUntriaged> is okay, but the opposite direction isn't.

I feel this part of the change is going to be challenging. What about extracting it out and land everything else?

José Arturo Barrera

Done, follow-up in https://chromium-review.googlesource.com/8029247

Open in Gerrit

Related details

Attention is currently required from:

Arthur Sonzogni

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages