[Layout] Oilpan LayoutResult's RareData members [chromium/src : main]

0 views
Skip to first unread message

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Mar 18, 2026, 2:37:42 PMMar 18
to Kurt Catti-Schmidt, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, zol...@webkit.org
Attention needed from Kurt Catti-Schmidt

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/blink_perf.layout complete.

  • animate-abspos-deep: base median = 30.99999999998836 -> patched median = 31.079999999329445
  • attach-inlines: base median = 388.06769796536923 -> patched median = 390.3294352719312
  • flexbox-column-nowrap: base median = 8236.084373523237 -> patched median = 8319.303608868377
  • flexbox-column-wrap: base median = 8161.92360948496 -> patched median = 8246.468653213693
  • flexbox-deeply-nested-column-flow: base median = 43026.89822390547 -> patched median = 43243.1255773592
  • flexbox-deeply-nested-with-ortho-flow: base median = 7529.909454048104 -> patched median = 7599.052682950778
  • flexbox-hittest: base median = 491044.5399496598 -> patched median = 492941.76653473923
  • flexbox-input: base median = 51996.383832476524 -> patched median = 52144.587454585126
  • flexbox-lots-of-data: base median = 422.3681356164507 -> patched median = 430.37152812475364
  • flexbox-nested-rows-and-columns-auto-overflow: base median = 2134.138587305121 -> patched median = 2161.7654620945004
  • flexbox-row-stretch-height-indefinite: base median = 4426.030919938219 -> patched median = 4545.176430923826
  • floats_100_100: base median = 18.380000001192094 -> patched median = 18.419999999180433
  • floats_100_100_nested: base median = 18.520000000018626 -> patched median = 18.59999999925494
  • floats_2_100: base median = 53.38000000016764 -> patched median = 53.51999999973923
  • gap-decorations-flexbox-lots-of-data: base median = 401.20509570096283 -> patched median = 409.6370053714886
  • gap-decorations-multicol-lots-of-columns: base median = 300.1439310067363 -> patched median = 304.0210818676833
  • grid-nested-baseline: base median = 12474.273910697386 -> patched median = 12523.7562917322
  • hindi-line-layout: base median = 1759.0892356906336 -> patched median = 1764.522257745265
  • hittest-nested-inline-blocks-listbased: base median = 163343.489532754 -> patched median = 164916.08563249733
  • large-grid: base median = 11.456962430153972 -> patched median = 11.509355433257369
  • large-spanning-grid-item: base median = 73390.89113762951 -> patched median = 73511.6407073974
  • large-table-with-collapsed-borders-and-no-colspans: base median = 116.10999999977648 -> patched median = 116.28999999985098
  • latin-ebook: base median = 104.95000000074506 -> patched median = 105.08999999929219
  • latin-ebook-french: base median = 63.99000000059605 -> patched median = 64.15999999998604
  • line-layout-fit-content: base median = 201.29999999981374 -> patched median = 201.5399999992922
  • line-layout-fit-content-break-word: base median = 41.93999999985099 -> patched median = 41.99999999925494
  • multicol_balance-list-items-with-tall-marker: base median = 346.8472859823564 -> patched median = 351.8106779886555
  • multicol_deeply-nested-tables: base median = 28061.28980593061 -> patched median = 28200.3794901887
  • multicol_large-inline-formatting-context: base median = 6.659657732349785 -> patched median = 6.679455275996858
  • multicol_lots-of-small-unbreakable-blocks-balanced: base median = 166.77201822942152 -> patched median = 169.75936490506598
  • multicol_tall-content-short-columns-realistic: base median = 383.14910040139785 -> patched median = 383.899442925161
  • nested-percent-height-tables: base median = 3421.657635474624 -> patched median = 3426.5610850371795
  • nested-subgrid: base median = 228.75402029684489 -> patched median = 228.9519334456549
  • nested-tables-with-overflow-auto: base median = 2317.134381701888 -> patched median = 2323.623495655793
  • ruby: base median = 162.11120397646243 -> patched median = 163.33668553932412
  • text-wrap-balance: base median = 439.91690154556846 -> patched median = 441.53531321899266
  • word-break-break-word: base median = 12.579999999981373 -> patched median = 12.619999998807907
  • word-wrap-break-word: base median = 12.599999999813736 -> patched median = 12.619999999552965


See results at: https://pinpoint-dot-chromeperf.appspot.com/job/10f8bbbc090000

Open in Gerrit

Related details

Attention is currently required from:
  • Kurt Catti-Schmidt
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I98b2218a12c0f8e963a8dfaf6440a540755adff6
Gerrit-Change-Number: 7680896
Gerrit-PatchSet: 1
Gerrit-Owner: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-Attention: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-Comment-Date: Wed, 18 Mar 2026 18:37:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Ian Kilpatrick (Gerrit)

unread,
Apr 9, 2026, 5:25:50 PM (6 days ago) Apr 9
to Kurt Catti-Schmidt, chrom...@appspot.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, zol...@webkit.org
Attention needed from Kurt Catti-Schmidt

Ian Kilpatrick voted and added 2 comments

Votes added by Ian Kilpatrick

Code-Review+1

2 comments

File third_party/blink/renderer/core/layout/layout_result.h
Line 764, Patchset 3 (Latest): HeapVector<NonOverflowingScrollRange> non_overflowing_scroll_ranges;
Ian Kilpatrick . unresolved

So can either put this at the start to reduce padding (136->128) or make this a:

Member<GCedHeapVector<>>

Line 749, Patchset 3 (Latest): int lines_until_clamp;
Ian Kilpatrick . unresolved

can you initialize this?

Open in Gerrit

Related details

Attention is currently required from:
  • Kurt Catti-Schmidt
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I98b2218a12c0f8e963a8dfaf6440a540755adff6
Gerrit-Change-Number: 7680896
Gerrit-PatchSet: 3
Gerrit-Owner: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-Attention: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-Comment-Date: Thu, 09 Apr 2026 21:25:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Apr 10, 2026, 3:52:03 PM (5 days ago) Apr 10
to Kurt Catti-Schmidt, Ian Kilpatrick, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, zol...@webkit.org
Attention needed from Ian Kilpatrick and Kurt Catti-Schmidt

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/blink_perf.layout complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/10570b82890000

Open in Gerrit

Related details

Attention is currently required from:
  • Ian Kilpatrick
  • Kurt Catti-Schmidt
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I98b2218a12c0f8e963a8dfaf6440a540755adff6
    Gerrit-Change-Number: 7680896
    Gerrit-PatchSet: 4
    Gerrit-Owner: Kurt Catti-Schmidt <ksc...@microsoft.com>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
    Gerrit-Attention: Kurt Catti-Schmidt <ksc...@microsoft.com>
    Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Comment-Date: Fri, 10 Apr 2026 19:51:46 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Kurt Catti-Schmidt (Gerrit)

    unread,
    Apr 10, 2026, 4:05:11 PM (5 days ago) Apr 10
    to Ian Kilpatrick, chrom...@appspot.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, zol...@webkit.org
    Attention needed from Ian Kilpatrick

    Kurt Catti-Schmidt added 3 comments

    Patchset-level comments
    File-level comment, Patchset 4 (Latest):
    Kurt Catti-Schmidt . resolved

    Looks like the GCedHeapVector change lost your +1, but perf went up a little more!

    File third_party/blink/renderer/core/layout/layout_result.h
    Line 764, Patchset 3: HeapVector<NonOverflowingScrollRange> non_overflowing_scroll_ranges;
    Ian Kilpatrick . resolved

    So can either put this at the start to reduce padding (136->128) or make this a:

    Member<GCedHeapVector<>>

    Kurt Catti-Schmidt

    Done

    Line 749, Patchset 3: int lines_until_clamp;
    Ian Kilpatrick . resolved

    can you initialize this?

    Kurt Catti-Schmidt

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ian Kilpatrick
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I98b2218a12c0f8e963a8dfaf6440a540755adff6
      Gerrit-Change-Number: 7680896
      Gerrit-PatchSet: 4
      Gerrit-Owner: Kurt Catti-Schmidt <ksc...@microsoft.com>
      Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
      Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
      Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
      Gerrit-Comment-Date: Fri, 10 Apr 2026 20:05:03 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Ian Kilpatrick <ikilp...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Kurt Catti-Schmidt (Gerrit)

      unread,
      Apr 10, 2026, 5:57:54 PM (5 days ago) Apr 10
      to Ian Kilpatrick, chrom...@appspot.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, zol...@webkit.org
      Attention needed from Ian Kilpatrick

      Kurt Catti-Schmidt voted Commit-Queue+1

      Commit-Queue+1
      Gerrit-Comment-Date: Fri, 10 Apr 2026 21:57:43 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Ian Kilpatrick (Gerrit)

      unread,
      Apr 13, 2026, 2:42:41 PM (2 days ago) Apr 13
      to Kurt Catti-Schmidt, chrom...@appspot.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, zol...@webkit.org
      Attention needed from Kurt Catti-Schmidt

      Ian Kilpatrick voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Kurt Catti-Schmidt
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I98b2218a12c0f8e963a8dfaf6440a540755adff6
        Gerrit-Change-Number: 7680896
        Gerrit-PatchSet: 4
        Gerrit-Owner: Kurt Catti-Schmidt <ksc...@microsoft.com>
        Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
        Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
        Gerrit-Attention: Kurt Catti-Schmidt <ksc...@microsoft.com>
        Gerrit-Comment-Date: Mon, 13 Apr 2026 18:42:30 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Kurt Catti-Schmidt (Gerrit)

        unread,
        Apr 13, 2026, 2:43:36 PM (2 days ago) Apr 13
        to Ian Kilpatrick, chrom...@appspot.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, zol...@webkit.org

        Kurt Catti-Schmidt voted Commit-Queue+2

        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I98b2218a12c0f8e963a8dfaf6440a540755adff6
        Gerrit-Change-Number: 7680896
        Gerrit-PatchSet: 4
        Gerrit-Owner: Kurt Catti-Schmidt <ksc...@microsoft.com>
        Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
        Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
        Gerrit-Comment-Date: Mon, 13 Apr 2026 18:43:27 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        chromium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

        unread,
        Apr 13, 2026, 5:02:48 PM (2 days ago) Apr 13
        to Kurt Catti-Schmidt, Ian Kilpatrick, chrom...@appspot.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, zol...@webkit.org

        chromiu...@luci-project-accounts.iam.gserviceaccount.com submitted the change

        Change information

        Commit message:
        [Layout] Oilpan LayoutResult's RareData members

        This change converts DevtoolsFlexInfo to be Oilpan managed and removes
        the RareData union in LayoutResult. This simplifies the LayoutResult
        structure and has modest (2-3%) performance gains on some tests.

        No behavioral changes are expected.
        Bug: 460491953
        Change-Id: I98b2218a12c0f8e963a8dfaf6440a540755adff6
        Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>
        Commit-Queue: Kurt Catti-Schmidt <ksc...@microsoft.com>
        Cr-Commit-Position: refs/heads/main@{#1613963}
        Files:
        • M third_party/blink/renderer/core/inspector/inspector_highlight.cc
        • M third_party/blink/renderer/core/layout/anchor_position_scroll_data.cc
        • M third_party/blink/renderer/core/layout/box_fragment_builder.h
        • M third_party/blink/renderer/core/layout/flex/devtools_flex_info.h
        • M third_party/blink/renderer/core/layout/flex/flex_layout_algorithm.cc
        • M third_party/blink/renderer/core/layout/flex/flex_layout_algorithm.h
        • M third_party/blink/renderer/core/layout/layout_box.cc
        • M third_party/blink/renderer/core/layout/layout_box.h
        • M third_party/blink/renderer/core/layout/layout_result.cc
        • M third_party/blink/renderer/core/layout/layout_result.h
        Change size: L
        Delta: 10 files changed, 60 insertions(+), 278 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Ian Kilpatrick
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I98b2218a12c0f8e963a8dfaf6440a540755adff6
        Gerrit-Change-Number: 7680896
        Gerrit-PatchSet: 5
        Gerrit-Owner: Kurt Catti-Schmidt <ksc...@microsoft.com>
        Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
        Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages