Fix overlapping icons in Application frames view [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Piotr Paulski (Gerrit)

unread,
Mar 23, 2026, 2:28:35 PM (17 hours ago) Mar 23
to Simon Zünd, AyeAye, devtools-rev...@chromium.org
Attention needed from Simon Zünd

Piotr Paulski voted and added 1 comment

Votes added by Piotr Paulski

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Piotr Paulski . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Simon Zünd
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: Ifa0dd73e994752ec11c7c4c16e733ba08cd4f192
Gerrit-Change-Number: 7693773
Gerrit-PatchSet: 1
Gerrit-Owner: Piotr Paulski <piotrp...@chromium.org>
Gerrit-Reviewer: Piotr Paulski <piotrp...@chromium.org>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
Gerrit-Attention: Simon Zünd <szu...@chromium.org>
Gerrit-Comment-Date: Mon, 23 Mar 2026 18:28:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Simon Zünd (Gerrit)

unread,
1:23 AM (6 hours ago) 1:23 AM
to Piotr Paulski, Devtools-frontend LUCI CQ, AyeAye, devtools-rev...@chromium.org
Attention needed from Piotr Paulski

Simon Zünd voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Piotr Paulski
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: Ifa0dd73e994752ec11c7c4c16e733ba08cd4f192
Gerrit-Change-Number: 7693773
Gerrit-PatchSet: 1
Gerrit-Owner: Piotr Paulski <piotrp...@chromium.org>
Gerrit-Reviewer: Piotr Paulski <piotrp...@chromium.org>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Piotr Paulski <piotrp...@chromium.org>
Gerrit-Comment-Date: Tue, 24 Mar 2026 05:23:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,
1:25 AM (6 hours ago) 1:25 AM
to Piotr Paulski, Simon Zünd, AyeAye, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:
Fix overlapping icons in Application frames view

The icons next to the frame URL were resizing with panel width.
When panel was narrow, they would start overlapping.
Fixed: 481938884
Change-Id: Ifa0dd73e994752ec11c7c4c16e733ba08cd4f192
Auto-Submit: Piotr Paulski <piotrp...@chromium.org>
Reviewed-by: Simon Zünd <szu...@chromium.org>
Commit-Queue: Simon Zünd <szu...@chromium.org>
Files:
  • M front_end/panels/application/FrameDetailsView.test.ts
  • M front_end/panels/application/FrameDetailsView.ts
  • M front_end/panels/application/frameDetailsReportView.css
  • A test/goldens/linux/application/frame-details-narrow.png
  • A test/goldens/linux/application/frame-details-wide.png
Change size: M
Delta: 5 files changed, 65 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Simon Zünd
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: Ifa0dd73e994752ec11c7c4c16e733ba08cd4f192
Gerrit-Change-Number: 7693773
Gerrit-PatchSet: 2
Gerrit-Owner: Piotr Paulski <piotrp...@chromium.org>
Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages