Shivani Sharma (Gerrit)

unread,

May 15, 2026, 10:53:00 AM (9 days ago) May 15

to Yoshisato Yanagisawa, Noam Rosenthal, Mike West, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Hiroki Nakagawa, loading...@chromium.org, devtools...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, dmurph+watching...@chromium.org, edgesto...@microsoft.com, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org

Attention needed from Yoshisato Yanagisawa

Shivani Sharma voted and added 1 comment

Votes added by Shivani Sharma

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 37 (Latest):

Shivani Sharma . resolved

yyana...@chromium.org PTAL, thanks!

cc nrosenthal@, mkwst@

Open in Gerrit

Related details

Attention is currently required from:

Yoshisato Yanagisawa

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Shivani Sharma (Gerrit)

unread,

May 15, 2026, 11:50:17 AM (9 days ago) May 15

to Xiaochen Zhou, Yoshisato Yanagisawa, Noam Rosenthal, Mike West, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Hiroki Nakagawa, loading...@chromium.org, devtools...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, dmurph+watching...@chromium.org, edgesto...@microsoft.com, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org

Attention needed from Xiaochen Zhou and Yoshisato Yanagisawa

Shivani Sharma added 1 comment

Patchset-level comments

File-level comment, Patchset 38 (Latest):

Shivani Sharma . resolved

Xiaochen, PTAL at the changes in connection_allowlist_gating* and its usage, thanks!

Open in Gerrit

Related details

Attention is currently required from:

Xiaochen Zhou
Yoshisato Yanagisawa

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dominic Farolino (Gerrit)

unread,

May 15, 2026, 12:47:40 PM (9 days ago) May 15

to Shivani Sharma, Xiaochen Zhou, Yoshisato Yanagisawa, Noam Rosenthal, Mike West, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Hiroki Nakagawa, loading...@chromium.org, devtools...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, dmurph+watching...@chromium.org, edgesto...@microsoft.com, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org

Attention needed from Shivani Sharma, Xiaochen Zhou and Yoshisato Yanagisawa

Dominic Farolino added 3 comments

Commit Message

Line 12, Patchset 38 (Latest):1. Main Script Fetch:

Dominic Farolino . unresolved

Can you clarify up top whether this is about blocking / allowing the fetching and registration of service worker scripts themselves, vs Document subresources bound for an already-present service worker? It's not clear to me.

Line 15, Patchset 38 (Latest):

2. Once the main script response is received in ServiceWorkerNewScriptFetcher::OnReceiveResponse, the allowlist headers (if any) are parsed and propagated to WorkerScriptFetcherResult.

Dominic Farolino . unresolved

The formatting of this is REALLY hard to read. Can you clean it up?

Line 37, Patchset 38 (Latest):Since web based service workers cannot be from a local scheme (added

Dominic Farolino . unresolved

What are "web"-based service worker? What other kinds are there?

Open in Gerrit

Related details

Attention is currently required from:

Shivani Sharma
Xiaochen Zhou
Yoshisato Yanagisawa

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Shivani Sharma (Gerrit)

unread,

May 15, 2026, 1:26:47 PM (9 days ago) May 15

to Dominic Farolino, Xiaochen Zhou, Yoshisato Yanagisawa, Noam Rosenthal, Mike West, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Hiroki Nakagawa, loading...@chromium.org, devtools...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, dmurph+watching...@chromium.org, edgesto...@microsoft.com, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org

Attention needed from Dominic Farolino, Xiaochen Zhou and Yoshisato Yanagisawa

Shivani Sharma added 3 comments

Commit Message

Line 12, Patchset 38:1. Main Script Fetch:

Dominic Farolino . resolved

Can you clarify up top whether this is about blocking / allowing the fetching and registration of service worker scripts themselves, vs Document subresources bound for an already-present service worker? It's not clear to me.

Shivani Sharma

Done

Line 15, Patchset 38:

2. Once the main script response is received in ServiceWorkerNewScriptFetcher::OnReceiveResponse, the allowlist headers (if any) are parsed and propagated to WorkerScriptFetcherResult.

Dominic Farolino . resolved

The formatting of this is REALLY hard to read. Can you clean it up?

Shivani Sharma

Done

Line 37, Patchset 38:Since web based service workers cannot be from a local scheme (added

Dominic Farolino . resolved

What are "web"-based service worker? What other kinds are there?

Shivani Sharma

I don't know much about them but I was told there are extension service workers and in those cases the existing function ShouldServiceWorkerInheritPolicyContainerFromCreator() gets invoked, while for web SWs this doesn't get invoked. (I'll cc you in the chat thread)

Open in Gerrit

Related details

Attention is currently required from:

Dominic Farolino
Xiaochen Zhou
Yoshisato Yanagisawa

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Shivani Sharma (Gerrit)

unread,

May 15, 2026, 10:44:13 PM (9 days ago) May 15

to Nate Chapin, Dominic Farolino, Xiaochen Zhou, Yoshisato Yanagisawa, Noam Rosenthal, Mike West, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Hiroki Nakagawa, gavinp...@chromium.org, loading...@chromium.org, devtools...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, dmurph+watching...@chromium.org, edgesto...@microsoft.com, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org

Shivani Sharma added 1 comment

Patchset-level comments

File-level comment, Patchset 42 (Latest):

Shivani Sharma . resolved

Removed reviewers from attention set as we are discussing the spec, in parallel. Will add back when that's resolved.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Shivani Sharma (Gerrit)

unread,

May 18, 2026, 11:37:28 PM (6 days ago) May 18

to Nate Chapin, Dominic Farolino, Xiaochen Zhou, Yoshisato Yanagisawa, Noam Rosenthal, Mike West, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Hiroki Nakagawa, gavinp...@chromium.org, loading...@chromium.org, devtools...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, dmurph+watching...@chromium.org, edgesto...@microsoft.com, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org

Attention needed from Xiaochen Zhou and Yoshisato Yanagisawa

Shivani Sharma added 1 comment

Patchset-level comments

File-level comment, Patchset 46 (Latest):

Shivani Sharma . resolved

PTAL, thanks!

(Adding reviewers to attention set as the CL is updated to match the spec)

Open in Gerrit

Related details

Attention is currently required from:

Xiaochen Zhou
Yoshisato Yanagisawa

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Shivani Sharma (Gerrit)

unread,

May 20, 2026, 7:49:51 AM (4 days ago) May 20

to Nate Chapin, Dominic Farolino, Xiaochen Zhou, Yoshisato Yanagisawa, Noam Rosenthal, Mike West, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Hiroki Nakagawa, gavinp...@chromium.org, loading...@chromium.org, devtools...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, dmurph+watching...@chromium.org, edgesto...@microsoft.com, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org

Attention needed from Xiaochen Zhou and Yoshisato Yanagisawa

Shivani Sharma added 1 comment

Patchset-level comments

File-level comment, Patchset 46 (Latest):

Shivani Sharma . resolved

friendly ping, thanks!

satisfied_requirement

unsatisfied_requirement

open

diffy

Xiaochen Zhou (Gerrit)

unread,

May 20, 2026, 12:08:05 PM (4 days ago) May 20

to Shivani Sharma, Nate Chapin, Dominic Farolino, Yoshisato Yanagisawa, Noam Rosenthal, Mike West, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Hiroki Nakagawa, gavinp...@chromium.org, loading...@chromium.org, devtools...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, dmurph+watching...@chromium.org, edgesto...@microsoft.com, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org

Attention needed from Shivani Sharma and Yoshisato Yanagisawa

Xiaochen Zhou added 2 comments

File content/browser/connection_allowlist_gating.cc

Line 53, Patchset 46 (Latest): if (response_url.SchemeIsLocal() && creator_policies) {

Xiaochen Zhou . unresolved

Should this condition also include extension worker?

File content/browser/service_worker/service_worker_container_host_unittest.cc

Line 577, Patchset 46 (Latest): std::optional<base::UnguessableToken>(), PolicyContainerPolicies());

Xiaochen Zhou . unresolved

nit: this is equivalent to `std::nullopt`.

Open in Gerrit

Related details

Attention is currently required from:

Shivani Sharma
Yoshisato Yanagisawa

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Shivani Sharma (Gerrit)

unread,

May 20, 2026, 2:59:55 PM (4 days ago) May 20

to Nate Chapin, Dominic Farolino, Xiaochen Zhou, Yoshisato Yanagisawa, Noam Rosenthal, Mike West, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Hiroki Nakagawa, gavinp...@chromium.org, loading...@chromium.org, devtools...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, dmurph+watching...@chromium.org, edgesto...@microsoft.com, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org

Attention needed from Xiaochen Zhou and Yoshisato Yanagisawa

Shivani Sharma added 2 comments

File content/browser/connection_allowlist_gating.cc

Line 53, Patchset 46: if (response_url.SchemeIsLocal() && creator_policies) {

Xiaochen Zhou . resolved

Should this condition also include extension worker?

Shivani Sharma

Good point, I updated to pass the return value of ShouldServiceWorkerInheritPolicyContainerFromCreator to this function which checks for all the relevant conditions

File content/browser/service_worker/service_worker_container_host_unittest.cc

Line 577, Patchset 46: std::optional<base::UnguessableToken>(), PolicyContainerPolicies());

Xiaochen Zhou . resolved

nit: this is equivalent to `std::nullopt`.

Shivani Sharma

Done

Open in Gerrit

Related details

Attention is currently required from:

Xiaochen Zhou
Yoshisato Yanagisawa

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Xiaochen Zhou (Gerrit)

unread,

May 20, 2026, 3:41:14 PM (4 days ago) May 20

to Shivani Sharma, Nate Chapin, Dominic Farolino, Yoshisato Yanagisawa, Noam Rosenthal, Mike West, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Hiroki Nakagawa, gavinp...@chromium.org, loading...@chromium.org, devtools...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, dmurph+watching...@chromium.org, edgesto...@microsoft.com, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org

Attention needed from Shivani Sharma and Yoshisato Yanagisawa

Xiaochen Zhou added 2 comments

File content/browser/connection_allowlist_gating.cc

Line 54, Patchset 47 (Latest): if (inherit_from_creator && creator_policies) {

Xiaochen Zhou . unresolved

If `inherit_from_creator` is true but `creator_policies` is nullptr, function falls through and the logic for non-local scheme might be executed for local scheme worker.

I think it should be something like this?
```
  if (inherit_from_creator) {
    return creator_policies ? creator_policies->connection_allowlists
                            : network::ConnectionAllowlists();
  }
```

File content/browser/service_worker/service_worker_new_script_loader.cc

Line 341, Patchset 47 (Latest): ->ShouldServiceWorkerInheritPolicyContainerFromCreator(

Xiaochen Zhou . unresolved

nit: The if condition above has already checked this is false. We can just pass a false here.

Open in Gerrit

Related details

Attention is currently required from:

Shivani Sharma
Yoshisato Yanagisawa

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Xiaochen Zhou (Gerrit)

unread,

May 20, 2026, 3:52:13 PM (4 days ago) May 20

to Shivani Sharma, Nate Chapin, Dominic Farolino, Yoshisato Yanagisawa, Noam Rosenthal, Mike West, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Hiroki Nakagawa, gavinp...@chromium.org, loading...@chromium.org, devtools...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, dmurph+watching...@chromium.org, edgesto...@microsoft.com, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org

Attention needed from Shivani Sharma and Yoshisato Yanagisawa

Xiaochen Zhou added 7 comments

File content/browser/service_worker/service_worker_context_unittest.cc

Line 482, Patchset 47 (Latest): std::optional<base::UnguessableToken>(), PolicyContainerPolicies());

Xiaochen Zhou . unresolved

nit: Let's update this to std::nullopt too.

File content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc

Line 199, Patchset 47 (Latest): /*network_restrictions_id=*/std::optional<base::UnguessableToken>(),

Xiaochen Zhou . unresolved

Ditto

File content/browser/service_worker/service_worker_job_unittest.cc

Line 955, Patchset 47 (Latest): /*network_restrictions_id=*/std::optional<base::UnguessableToken>(),

Xiaochen Zhou . unresolved

Ditto.

File content/browser/service_worker/service_worker_registration_unittest.cc

Line 258, Patchset 47 (Latest): std::optional<base::UnguessableToken>(), PolicyContainerPolicies());

Xiaochen Zhou . unresolved

Ditto.

File content/browser/service_worker/service_worker_registry.cc

Line 1237, Patchset 47 (Latest): /*network_restrictions_id=*/std::optional<base::UnguessableToken>(),

Xiaochen Zhou . unresolved

Ditto.

File content/browser/service_worker/service_worker_registry_unittest.cc

Line 804, Patchset 47 (Latest): /*network_restrictions_id=*/std::optional<base::UnguessableToken>(),

Xiaochen Zhou . unresolved

Ditto.

File content/browser/service_worker/service_worker_test_utils.cc

Line 511, Patchset 47 (Latest): /*network_restrictions_id=*/std::optional<base::UnguessableToken>(),

Xiaochen Zhou . unresolved

Ditto.

satisfied_requirement

unsatisfied_requirement

open

diffy

Shivani Sharma (Gerrit)

unread,

May 20, 2026, 5:17:48 PM (4 days ago) May 20

to Nate Chapin, Dominic Farolino, Xiaochen Zhou, Yoshisato Yanagisawa, Noam Rosenthal, Mike West, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Hiroki Nakagawa, navigation...@chromium.org, creis...@chromium.org, alexmo...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, devtools...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, dmurph+watching...@chromium.org, edgesto...@microsoft.com, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org

Attention needed from Xiaochen Zhou and Yoshisato Yanagisawa

Shivani Sharma added 9 comments

File content/browser/connection_allowlist_gating.cc

Line 54, Patchset 47: if (inherit_from_creator && creator_policies) {

Xiaochen Zhou . resolved

If `inherit_from_creator` is true but `creator_policies` is nullptr, function falls through and the logic for non-local scheme might be executed for local scheme worker.
I think it should be something like this?
```
  if (inherit_from_creator) {
    return creator_policies ? creator_policies->connection_allowlists
                            : network::ConnectionAllowlists();
  }
```

Shivani Sharma

Done

File content/browser/service_worker/service_worker_context_unittest.cc

Line 482, Patchset 47: std::optional<base::UnguessableToken>(), PolicyContainerPolicies());

Xiaochen Zhou . resolved

nit: Let's update this to std::nullopt too.

Shivani Sharma

Done

File content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc

Line 199, Patchset 47: /*network_restrictions_id=*/std::optional<base::UnguessableToken>(),

Xiaochen Zhou . resolved

Ditto

Shivani Sharma

Done

File content/browser/service_worker/service_worker_job_unittest.cc

Line 955, Patchset 47: /*network_restrictions_id=*/std::optional<base::UnguessableToken>(),

Xiaochen Zhou . resolved

Ditto.

Shivani Sharma

Done

File content/browser/service_worker/service_worker_new_script_loader.cc

Line 341, Patchset 47: ->ShouldServiceWorkerInheritPolicyContainerFromCreator(

Xiaochen Zhou . resolved

nit: The if condition above has already checked this is false. We can just pass a false here.

Shivani Sharma

Done

File content/browser/service_worker/service_worker_registration_unittest.cc

Line 258, Patchset 47: std::optional<base::UnguessableToken>(), PolicyContainerPolicies());

Xiaochen Zhou . resolved

Ditto.

Shivani Sharma

Done

File content/browser/service_worker/service_worker_registry.cc

Line 1237, Patchset 47: /*network_restrictions_id=*/std::optional<base::UnguessableToken>(),

Xiaochen Zhou . resolved

Ditto.

Shivani Sharma

Done

File content/browser/service_worker/service_worker_registry_unittest.cc

Line 804, Patchset 47: /*network_restrictions_id=*/std::optional<base::UnguessableToken>(),

Xiaochen Zhou . resolved

Ditto.

Shivani Sharma

Done

File content/browser/service_worker/service_worker_test_utils.cc

Line 511, Patchset 47: /*network_restrictions_id=*/std::optional<base::UnguessableToken>(),

Xiaochen Zhou . resolved

Ditto.

Shivani Sharma

Done

Open in Gerrit

Related details

Attention is currently required from:

Xiaochen Zhou
Yoshisato Yanagisawa

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Xiaochen Zhou (Gerrit)

unread,

May 20, 2026, 5:21:41 PM (4 days ago) May 20

to Shivani Sharma, Nate Chapin, Dominic Farolino, Yoshisato Yanagisawa, Noam Rosenthal, Mike West, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Hiroki Nakagawa, navigation...@chromium.org, creis...@chromium.org, alexmo...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, devtools...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, dmurph+watching...@chromium.org, edgesto...@microsoft.com, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org

Attention needed from Shivani Sharma and Yoshisato Yanagisawa

Xiaochen Zhou voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Shivani Sharma
Yoshisato Yanagisawa

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Yoshisato Yanagisawa (Gerrit)

unread,

May 22, 2026, 4:22:42 AM (3 days ago) May 22

to Shivani Sharma, Xiaochen Zhou, Nate Chapin, Dominic Farolino, Noam Rosenthal, Mike West, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Hiroki Nakagawa, navigation...@chromium.org, creis...@chromium.org, alexmo...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, devtools...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, dmurph+watching...@chromium.org, edgesto...@microsoft.com, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org

Attention needed from Shivani Sharma

Yoshisato Yanagisawa added 1 comment

Patchset-level comments

File-level comment, Patchset 49 (Latest):

Yoshisato Yanagisawa . resolved

Sorry for the slow reply, but let me ask the author to write an explainer or so to explain the corner case if not yet. Or, will you link the document with this CL?

Recently, I got filed on the corner case scenario for the SW static routing API's cache source scenario, and I got a bit nervous for such corner case behavior.

Open in Gerrit

Related details

Attention is currently required from:

Shivani Sharma

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Shivani Sharma (Gerrit)

unread,

May 22, 2026, 5:13:34 PM (2 days ago) May 22

to Xiaochen Zhou, Nate Chapin, Dominic Farolino, Yoshisato Yanagisawa, Noam Rosenthal, Mike West, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Hiroki Nakagawa, navigation...@chromium.org, creis...@chromium.org, alexmo...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, devtools...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, dmurph+watching...@chromium.org, edgesto...@microsoft.com, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, storage...@chromium.org

Attention needed from Xiaochen Zhou and Yoshisato Yanagisawa

Shivani Sharma added 1 comment

Patchset-level comments

File-level comment, Patchset 49:

Yoshisato Yanagisawa . resolved

Sorry for the slow reply, but let me ask the author to write an explainer or so to explain the corner case if not yet. Or, will you link the document with this CL?
Recently, I got filed on the corner case scenario for the SW static routing API's cache source scenario, and I got a bit nervous for such corner case behavior.

Shivani Sharma

I've responded to the questions in the issue here. PTAL, thanks!
https://issues.chromium.org/u/1/issues/492456052#comment4

Open in Gerrit

Related details

Attention is currently required from:

Xiaochen Zhou
Yoshisato Yanagisawa

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[Connection-Allowlist] Service workers support [chromium/src : main]

Shivani Sharma (Gerrit)

Shivani Sharma voted and added 1 comment

Votes added by Shivani Sharma

1 comment

Related details

Shivani Sharma (Gerrit)

Shivani Sharma added 1 comment

Related details

Dominic Farolino (Gerrit)

Dominic Farolino added 3 comments

Related details

Shivani Sharma (Gerrit)

Shivani Sharma added 3 comments

Related details

Shivani Sharma (Gerrit)

Shivani Sharma added 1 comment

Related details

Shivani Sharma (Gerrit)

Shivani Sharma added 1 comment

Related details

Shivani Sharma (Gerrit)

Shivani Sharma added 1 comment

Xiaochen Zhou (Gerrit)

Xiaochen Zhou added 2 comments

Related details

Shivani Sharma (Gerrit)

Shivani Sharma added 2 comments

Related details

Xiaochen Zhou (Gerrit)

Xiaochen Zhou added 2 comments

Related details

Xiaochen Zhou (Gerrit)

Xiaochen Zhou added 7 comments

Shivani Sharma (Gerrit)

Shivani Sharma added 9 comments

Related details

Xiaochen Zhou (Gerrit)

Xiaochen Zhou voted Code-Review+1

Related details

Yoshisato Yanagisawa (Gerrit)

Yoshisato Yanagisawa added 1 comment

Related details

Shivani Sharma (Gerrit)

Shivani Sharma added 1 comment

Related details