[console] Improve URL filtering for console.log %c formatter [devtools/devtools-frontend : main]
Lyra Rebane (Gerrit)
Lyra Rebane added 1 comment![]( "Open in Gerrit")
Adding Mathias and Nikolay for ConsoleFormat files, and Nikolay and Ergün for AUTHORS file. I believe I need two +1's on each file because I am not a Chromium committer.
Related details
- Ergün Erdoğmuş
- Mathias Bynens
- Nikolay Vitkov
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lyra Rebane (Gerrit)
Lyra Rebane added 1 comment![]( "Open in Gerrit")
Removing Ergün as Mathias and Nikolay are both able to review the AUTHORS file (gerrit "suggest owners" ui confused me).
Related details
- Mathias Bynens
- Nikolay Vitkov
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mathias Bynens (Gerrit)
Mathias Bynens added 1 comment![]( "Open in Gerrit")
- Lyra Rebane
- Nikolay Vitkov
- Philip Pfaffe
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Pfaffe (Gerrit)
Philip Pfaffe added 1 comment![]( "Open in Gerrit")
+szuend because he worked on this previously. Did we ever experiment with applying more CSP devtools-wide?
Generally this looks good to me, but I'm worried about the complexity of this solution.
Related details
- Lyra Rebane
- Simon Zünd
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lyra Rebane (Gerrit)
Lyra Rebane added 1 comment![]( "Open in Gerrit")
+szuend because he worked on this previously. Did we ever experiment with applying more CSP devtools-wide?
Generally this looks good to me, but I'm worried about the complexity of this solution.
FWIW I poked around in DevTools for a bit and it seems like there are features there with external http traffic to various servers, so writing a CSP that doesn't break those use cases might be a bit difficult and could still leave some gaps open in terms of exfiltrating data. CSP on the DevTools/console would be a good long-term goal though.
Related details
- Philip Pfaffe
- Simon Zünd
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Pfaffe (Gerrit)
Philip Pfaffe added 1 comment![]( "Open in Gerrit")
Lyra Rebane+szuend because he worked on this previously. Did we ever experiment with applying more CSP devtools-wide?
Generally this looks good to me, but I'm worried about the complexity of this solution.
FWIW I poked around in DevTools for a bit and it seems like there are features there with external http traffic to various servers, so writing a CSP that doesn't break those use cases might be a bit difficult and could still leave some gaps open in terms of exfiltrating data. CSP on the DevTools/console would be a good long-term goal though.
- Lyra Rebane
- Simon Zünd
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |