[DC] Virtual Wallet Interceptor Protocol tests [chromium/src : main]

[Mohamed Amir Yosef (Gerrit)]

Attention needed from Alex Rudenko and Tejas Dhagawkar

Mohamed Amir Yosef added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Mohamed Amir Yosef . unresolved

for DC, please land the tests to the upstream
https://github.com/web-platform-tests/wpt
such that both Marcos and I get a chance to review them!

Open in Gerrit

Related details

Attention is currently required from:

• Alex Rudenko
• Tejas Dhagawkar

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ib961e0ad69ac9b7d98414d3f1ba49c9cde026f94

Gerrit-Change-Number: 7913321

Gerrit-PatchSet: 3

Gerrit-Owner: Tejas Dhagawkar <tdhag...@microsoft.com>

Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>

Gerrit-Reviewer: Mohamed Amir Yosef <ma...@chromium.org>

Gerrit-Reviewer: Tejas Dhagawkar <tdhag...@microsoft.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Tejas Dhagawkar <tdhag...@microsoft.com>

Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>

Gerrit-Comment-Date: Tue, 09 Jun 2026 15:07:42 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Mohamed Amir Yosef (Gerrit)]

Attention needed from Alex Rudenko and Tejas Dhagawkar

Mohamed Amir Yosef voted Code-Review-1

Code-Review

-1

Open in Gerrit

Related details

Attention is currently required from:

• Alex Rudenko
• Tejas Dhagawkar

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review

• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ib961e0ad69ac9b7d98414d3f1ba49c9cde026f94

Gerrit-Change-Number: 7913321

Gerrit-PatchSet: 3

Gerrit-Owner: Tejas Dhagawkar <tdhag...@microsoft.com>

Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>

Gerrit-Reviewer: Mohamed Amir Yosef <ma...@chromium.org>

Gerrit-Reviewer: Tejas Dhagawkar <tdhag...@microsoft.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Tejas Dhagawkar <tdhag...@microsoft.com>

Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>

Gerrit-Comment-Date: Tue, 09 Jun 2026 15:07:48 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Tejas Dhagawkar (Gerrit)]

Attention needed from Alex Rudenko and Mohamed Amir Yosef

Tejas Dhagawkar voted and added 1 comment

Votes added by Tejas Dhagawkar

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Mohamed Amir Yosef . resolved

for DC, please land the tests to the upstream
https://github.com/web-platform-tests/wpt
such that both Marcos and I get a chance to review them!

Tejas Dhagawkar

Thanks for the feedback. These tests run by directly calling the handler. I need to complete the pending BiDi implementation for the virtual wallet before adding them to external WPTs. I will add them there once the WebDriver implementation is complete.

Open in Gerrit

Related details

Attention is currently required from:

• Alex Rudenko
• Mohamed Amir Yosef

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ib961e0ad69ac9b7d98414d3f1ba49c9cde026f94

Gerrit-Change-Number: 7913321

Gerrit-PatchSet: 3

Gerrit-Owner: Tejas Dhagawkar <tdhag...@microsoft.com>

Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>

Gerrit-Reviewer: Mohamed Amir Yosef <ma...@chromium.org>

Gerrit-Reviewer: Tejas Dhagawkar <tdhag...@microsoft.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Mohamed Amir Yosef <ma...@chromium.org>

Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>

Gerrit-Comment-Date: Wed, 10 Jun 2026 07:06:38 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Mohamed Amir Yosef <ma...@chromium.org>

[Alex Rudenko (Gerrit)]

Attention needed from Mohamed Amir Yosef and Tejas Dhagawkar

Alex Rudenko added 2 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Alex Rudenko . unresolved

Let's add the following tests:

1) the devtools wallet state is maintained across navigations
2) the devtools wallet state is not leaking into local iframes

File third_party/blink/web_tests/http/tests/inspector-protocol/digital-credentials/resources/digital-credentials-get.html

Line 19, Patchset 3 (Latest):

Alex Rudenko . unresolved

Please fix this WARNING reported by Trailing Whitespace: Please remove the trailing whitespace.

Open in Gerrit

Related details

Attention is currently required from:

• Mohamed Amir Yosef
• Tejas Dhagawkar

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ib961e0ad69ac9b7d98414d3f1ba49c9cde026f94

Gerrit-Change-Number: 7913321

Gerrit-PatchSet: 3

Gerrit-Owner: Tejas Dhagawkar <tdhag...@microsoft.com>

Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>

Gerrit-Reviewer: Mohamed Amir Yosef <ma...@chromium.org>

Gerrit-Reviewer: Tejas Dhagawkar <tdhag...@microsoft.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Tejas Dhagawkar <tdhag...@microsoft.com>

Gerrit-Attention: Mohamed Amir Yosef <ma...@chromium.org>

Gerrit-Comment-Date: Fri, 12 Jun 2026 11:40:41 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Alex Rudenko (Gerrit)]

Attention needed from Mohamed Amir Yosef and Tejas Dhagawkar

Alex Rudenko added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Alex Rudenko . unresolved

Let's add the following tests:

1) the devtools wallet state is maintained across navigations
2) the devtools wallet state is not leaking into local iframes

Alex Rudenko

3. the devtools wallet state is releases once the CDP session disconnects.

Comment-In-Reply-To: Alex Rudenko <alexr...@chromium.org>

[Tejas Dhagawkar (Gerrit)]

Attention needed from Alex Rudenko and Mohamed Amir Yosef

Tejas Dhagawkar added 2 comments

Patchset-level comments

File-level comment, Patchset 3:

Alex Rudenko . resolved

Let's add the following tests:

1) the devtools wallet state is maintained across navigations
2) the devtools wallet state is not leaking into local iframes

Alex Rudenko

3. the devtools wallet state is releases once the CDP session disconnects.

Tejas Dhagawkar

Thank you! I added tests. The current behavior is:

1. The virtual wallet is destroyed upon navigation.
2. An iframe can have its own virtual wallet. If one is not set, it uses its parent's virtual wallet by default.
3. The virtual wallet is destroyed when the CDP session is disconnected.

File third_party/blink/web_tests/http/tests/inspector-protocol/digital-credentials/resources/digital-credentials-get.html

Line 19, Patchset 3:

Alex Rudenko . resolved

Please fix this WARNING reported by Trailing Whitespace: Please remove the trailing whitespace.

Tejas Dhagawkar

Thanks. Done

Open in Gerrit

Related details

Attention is currently required from:

• Alex Rudenko
• Mohamed Amir Yosef

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ib961e0ad69ac9b7d98414d3f1ba49c9cde026f94

Gerrit-Change-Number: 7913321

Gerrit-PatchSet: 4

Gerrit-Owner: Tejas Dhagawkar <tdhag...@microsoft.com>

Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>

Gerrit-Reviewer: Mohamed Amir Yosef <ma...@chromium.org>

Gerrit-Reviewer: Tejas Dhagawkar <tdhag...@microsoft.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Mohamed Amir Yosef <ma...@chromium.org>

Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>

Gerrit-Comment-Date: Fri, 12 Jun 2026 20:33:27 +0000