Update lint rule for imperative icon creation [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Danil Somsikov (Gerrit)
Nov 28, 2025, 9:26:24 AM (3 days ago) Nov 28
to AyeAye, Kim-Anh Tran, devtools-rev...@chromium.org
Attention needed from Kim-Anh Tran
Danil Somsikov voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Kim-Anh Tran
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kim-Anh Tran (Gerrit)
12:36 AM (10 hours ago) 12:36 AM
to Danil Somsikov, Devtools-frontend LUCI CQ, AyeAye, devtools-rev...@chromium.org
Attention needed from Danil Somsikov
Kim-Anh Tran voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kim-Anh Tran
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Danil Somsikov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Danil Somsikov (Gerrit)
1:43 AM (9 hours ago) 1:43 AM
to Kim-Anh Tran, Devtools-frontend LUCI CQ, AyeAye, devtools-rev...@chromium.org
Attention needed from Kim-Anh Tran
Danil Somsikov voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Kim-Anh Tran
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kim-Anh Tran (Gerrit)
2:46 AM (8 hours ago) 2:46 AM
to Danil Somsikov, Devtools-frontend LUCI CQ, AyeAye, devtools-rev...@chromium.org
Attention needed from Danil Somsikov
Kim-Anh Tran voted![]( "Open in Gerrit")
Attention is currently required from:
- Danil Somsikov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Danil Somsikov (Gerrit)
2:56 AM (8 hours ago) 2:56 AM
to Kim-Anh Tran, Devtools-frontend LUCI CQ, AyeAye, devtools-rev...@chromium.org
Attention needed from Kim-Anh Tran
Danil Somsikov voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Kim-Anh Tran
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
3:44 AM (7 hours ago) 3:44 AM
to Danil Somsikov, Kim-Anh Tran, AyeAye, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
5 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: front_end/panels/sources/TabbedEditorContainer.ts
Insertions: 8, Deletions: 6.
@@ -527,9 +527,10 @@
}
private addLoadErrorIcon(tabId: string): void {
- const icon = html`
- <devtools-icon class="small" name="cross-circle-filled"
- title=${i18nString(UIStrings.unableToLoadThisContent)}></devtools-icon>`;
+ const icon = new Icon();
+ icon.name = 'cross-circle-filled';
+ icon.classList.add('small');
+ UI.Tooltip.Tooltip.install(icon, i18nString(UIStrings.unableToLoadThisContent));
if (this.tabbedPane.tabView(tabId)) {
this.tabbedPane.setTrailingTabIcon(tabId, icon);
}
@@ -605,9 +606,10 @@
const tooltip = this.tooltipForFile(uiSourceCode);
this.tabbedPane.changeTabTitle(tabId, title, tooltip);
if (uiSourceCode.loadError()) {
- const icon = html`
- <devtools-icon class="small" name="cross-circle-filled"
- title=${i18nString(UIStrings.unableToLoadThisContent)}></devtools-icon>`;
+ const icon = new Icon();
+ icon.name = 'cross-circle-filled';
+ icon.classList.add('small');
+ UI.Tooltip.Tooltip.install(icon, i18nString(UIStrings.unableToLoadThisContent));
this.tabbedPane.setTrailingTabIcon(tabId, icon);
} else if (Persistence.Persistence.PersistenceImpl.instance().hasUnsavedCommittedChanges(uiSourceCode)) {
/* eslint-disable @devtools/no-imperative-dom-api --
```
Change information
Commit message:
Update lint rule for imperative icon creation
- updated the identifiers after ui kit migration
- moved the icon-related out of button.ts as icons are no longer related to the button component
- added support for UIUtils.createIconLabel
Bug: 464124289
Change-Id: I6e42c200af4c19b630ab9482b4efee387cffe2fa
Commit-Queue: Danil Somsikov <d...@chromium.org>
Auto-Submit: Danil Somsikov <d...@chromium.org>
Reviewed-by: Kim-Anh Tran <kim...@chromium.org>
Files:
- M front_end/panels/common/PersistenceUtils.ts
- M front_end/panels/sources/TabbedEditorContainer.ts
- M scripts/eslint_rules/lib/no-imperative-dom-api.ts
- M scripts/eslint_rules/lib/no-imperative-dom-api/button.ts
- M scripts/eslint_rules/lib/no-imperative-dom-api/dom-fragment.ts
- A scripts/eslint_rules/lib/no-imperative-dom-api/icon.ts
- M scripts/eslint_rules/lib/no-imperative-dom-api/ui-utils.ts
- M scripts/eslint_rules/tests/no-imperative-dom-api.test.ts
Change size: M
Delta: 8 files changed, 163 insertions(+), 40 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kim-Anh Tran
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages