Avoid re-entry when draining pending error events [chromium/src : main]
0 views
Skip to first unread message
Andrey Kosyakov (Gerrit)
Oct 21, 2026, 11:29:55 PM (16 hours ago) Oct 21
to Nate Chapin, Michael Lippautz, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org
Attention needed from Michael Lippautz and Nate Chapin
Andrey Kosyakov added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2:
Andrey Kosyakov . resolved
PTAL -- this takes care of the blink-side reentry problem, but there's more to this issue, I'll follow up with some work on the v8-inspector side too.
Related details
Attention is currently required from:
- Michael Lippautz
- Nate Chapin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
1:02 AM (14 hours ago) 1:02 AM
to Andrey Kosyakov, Nate Chapin, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org
Attention needed from Andrey Kosyakov and Nate Chapin
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz <mlip...@chromium.org>
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Andrey Kosyakov
- Nate Chapin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nate Chapin (Gerrit)
1:31 PM (2 hours ago) 1:31 PM
to Andrey Kosyakov, Michael Lippautz, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org
Attention needed from Andrey Kosyakov
Nate Chapin voted Code-Review+1 on change 8622063![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Andrey Kosyakov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrey Kosyakov (Gerrit)
1:32 PM (2 hours ago) 1:32 PM
to Nate Chapin, Michael Lippautz, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org
Andrey Kosyakov voted Commit-Queue+2 on change 8622063![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
1:38 PM (2 hours ago) 1:38 PM
to Andrey Kosyakov, Nate Chapin, Michael Lippautz, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted change 8622063![]( "Open in Gerrit")
Change information
Commit message:
Avoid re-entry when draining pending error events
Fixed: 573264074
Change-Id: If8503bd2e9ca28fc5dd316d8aacb58ec168c6d38
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Reviewed-by: Nate Chapin <jap...@chromium.org>
Commit-Queue: Andrey Kosyakov <ca...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1724943}
Files:
- M third_party/blink/renderer/core/execution_context/execution_context.cc
- M third_party/blink/renderer/core/execution_context/execution_context.h
- A third_party/blink/web_tests/inspector-protocol/runtime/runtime-exception-thrown-nested-expected.txt
- A third_party/blink/web_tests/inspector-protocol/runtime/runtime-exception-thrown-nested.js
Change size: M
Delta: 4 files changed, 67 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz, +1 by Nate Chapin
Review-Enforcement: Code-Review+1 by Michael Lippautz, Code-Review+1 by Nate Chapin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages