Migrate persistence-network-overrides-enabled setting to SettingDescriptor [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Simon Zünd (Gerrit)
5:08 AM (5 hours ago) 5:08 AM
to Philip Pfaffe, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Philip Pfaffe
Simon Zünd voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Philip Pfaffe
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Pfaffe (Gerrit)
5:44 AM (4 hours ago) 5:44 AM
to Simon Zünd, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Simon Zünd
Philip Pfaffe voted![]( "Open in Gerrit")
Attention is currently required from:
- Simon Zünd
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
6:15 AM (4 hours ago) 6:15 AM
to Simon Zünd, Philip Pfaffe, devtools-rev...@chromium.org
devtools-fro...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Migrate persistence-network-overrides-enabled setting to SettingDescriptor
This CL migrates the `persistence-network-overrides-enabled` setting
from a SettingRegistration in
`front_end/models/persistence/persistence-meta.ts` to a
SettingDescriptor in `NetworkPersistenceManager.ts` and registers its UI
descriptor in `front_end/entrypoints/main/main-meta.ts`.
With this migration, `front_end/models/persistence/persistence-meta.ts`
is deleted as it has no remaining settings.
Bug: 535451658
Change-Id: I2b4e3e43b41fbe8b069a2355e2798fb86febc0ec
TAG=agy
CONV=be04dab5-6365-426e-a74b-e01f2db639bd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/8264080
Commit-Queue: Philip Pfaffe <pfa...@chromium.org>
Auto-Submit: Simon Zünd <szu...@chromium.org>
Reviewed-by: Philip Pfaffe <pfa...@chromium.org>
Files:
- M config/gni/devtools_grd_files.gni
- M front_end/core/sdk/NetworkManager.test.ts
- M front_end/entrypoints/main/BUILD.gn
- M front_end/entrypoints/main/main-meta.ts
- M front_end/entrypoints/shell/BUILD.gn
- M front_end/entrypoints/shell/shell.ts
- M front_end/entrypoints/trace_app/BUILD.gn
- M front_end/entrypoints/trace_app/trace_app.ts
- M front_end/legacy_test_runner/bindings_test_runner/OverridesTestRunner.js
- M front_end/models/persistence/BUILD.gn
- M front_end/models/persistence/NetworkPersistenceManager.test.ts
- M front_end/models/persistence/NetworkPersistenceManager.ts
- D front_end/models/persistence/persistence-meta.ts
- M front_end/panels/network/NetworkLogView.ts
- M front_end/panels/network/RequestHeadersView.test.ts
- M front_end/panels/network/RequestHeadersView.ts
- M front_end/panels/network/components/ResponseHeaderSection.test.ts
- M front_end/panels/network/components/ResponseHeaderSection.ts
- M front_end/panels/sources/NavigatorView.ts
- M front_end/panels/sources/SourcesNavigator.test.ts
- M front_end/panels/sources/SourcesNavigator.ts
- M front_end/panels/sources/SourcesSearchScope.ts
- M front_end/panels/sources/UISourceCodeFrame.ts
- M mcp/BUILD.gn
- M mcp/mcp.ts
- M test/api/BUILD.gn
- M test/api/TargetUniverse.ts
Change size: M
Delta: 27 files changed, 127 insertions(+), 122 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Philip Pfaffe
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages