Reland 'Allow fetch/XMLHttpRequest APIs to set a user-agent' [chromium/src : main]

1 view

Skip to first unread message

Andrew Brown (Gerrit)

unread,

1:01 AM (17 hours ago) 1:01 AM

to Takashi Nakayama, Takashi Toyoshima, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, Nate Chapin, Hiroki Nakagawa, alexmo...@chromium.org, antoniosarto...@chromium.org, arthursonzog...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, extension...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kenjibah...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mkwst+w...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, prerenderi...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, tburkar...@chromium.org

Attention needed from Takashi Nakayama and Takashi Toyoshima

Andrew Brown added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Andrew Brown . unresolved

Before I go through the hassle of pinging like, all 7 different "owners" this CL needs, I would like to try and resolve the test issues.

I've resolved the first problem by just removing that test - there's a comment where it used to be explaining my logic.

As for the second problem, sorry to be doubtful of previous messages, but you *sure* that nothing is different about (beyond like, internal branding stuff or whatever) for "Chrome" vs "Chromium" builds? Because I looked back at the issues, and it looks like three completely different tests all started failing only on "Chrome" ci builds.

I don't think I can meaningfully progress the three "Chrome" specific failures, because I can't view the tests, or any differences in code setup, and the tests all pass on every "Chromium" run I've seen. There's not even any commonalities between the three tests that I could look into, beyond the fact they're all in `content/`.

If there are other avenues of investigation that I'm missing, I'm all ears.

Open in Gerrit

Related details

Attention is currently required from:

Takashi Nakayama
Takashi Toyoshima

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages