AI: update button when walkthrough is open [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Jack Franklin (Gerrit)

unread,
Mar 23, 2026, 1:06:50 PM (19 hours ago) Mar 23
to Kateryna Prokopenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Kateryna Prokopenko

Jack Franklin voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kateryna Prokopenko
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I157d79404438d3c9c13734b2d39d5afe50b274db
Gerrit-Change-Number: 7693139
Gerrit-PatchSet: 1
Gerrit-Owner: Jack Franklin <jacktf...@chromium.org>
Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
Gerrit-Reviewer: Kateryna Prokopenko <kprok...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Kateryna Prokopenko <kprok...@chromium.org>
Gerrit-Comment-Date: Mon, 23 Mar 2026 17:06:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kateryna Prokopenko (Gerrit)

unread,
Mar 23, 2026, 2:01:59 PM (18 hours ago) Mar 23
to Jack Franklin, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Jack Franklin

Kateryna Prokopenko voted and added 1 comment

Votes added by Kateryna Prokopenko

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Kateryna Prokopenko . resolved

Nice, thanks, Jack! Looks good to me :)

Open in Gerrit

Related details

Attention is currently required from:
  • Jack Franklin
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I157d79404438d3c9c13734b2d39d5afe50b274db
Gerrit-Change-Number: 7693139
Gerrit-PatchSet: 1
Gerrit-Owner: Jack Franklin <jacktf...@chromium.org>
Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
Gerrit-Reviewer: Kateryna Prokopenko <kprok...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Jack Franklin <jacktf...@chromium.org>
Gerrit-Comment-Date: Mon, 23 Mar 2026 18:01:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Jack Franklin (Gerrit)

unread,
5:19 AM (3 hours ago) 5:19 AM
to Kateryna Prokopenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

Jack Franklin voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I157d79404438d3c9c13734b2d39d5afe50b274db
Gerrit-Change-Number: 7693139
Gerrit-PatchSet: 1
Gerrit-Owner: Jack Franklin <jacktf...@chromium.org>
Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
Gerrit-Reviewer: Kateryna Prokopenko <kprok...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Comment-Date: Tue, 24 Mar 2026 09:19:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,
5:21 AM (3 hours ago) 5:21 AM
to Jack Franklin, Kateryna Prokopenko, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:
AI: update button when walkthrough is open

So it says "Close walkthrough". Drive-by fix to make the scrollbar on
the walkthrough thinner to align with the AI Assistance panel.
Fixed: 495397063, 495416130
Change-Id: I157d79404438d3c9c13734b2d39d5afe50b274db
Reviewed-by: Kateryna Prokopenko <kprok...@chromium.org>
Auto-Submit: Jack Franklin <jacktf...@chromium.org>
Commit-Queue: Jack Franklin <jacktf...@chromium.org>
Files:
  • M front_end/panels/ai_assistance/components/ChatMessage.test.ts
  • M front_end/panels/ai_assistance/components/ChatMessage.ts
  • M front_end/panels/ai_assistance/components/walkthroughView.css
Change size: S
Delta: 3 files changed, 21 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Kateryna Prokopenko
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I157d79404438d3c9c13734b2d39d5afe50b274db
Gerrit-Change-Number: 7693139
Gerrit-PatchSet: 2
Gerrit-Owner: Jack Franklin <jacktf...@chromium.org>
Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages