Clean up code in AiCodeCompletion which is already part of Provider [devtools/devtools-frontend : main]

[Samiya Caur (Gerrit)]

Attention needed from Ergün Erdoğmuş

Samiya Caur voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

• Ergün Erdoğmuş

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: devtools/devtools-frontend

Gerrit-Branch: main

Gerrit-Change-Id: I007bd5bf2de008965a92a6e8f019a9705b445498

Gerrit-Change-Number: 7316929

Gerrit-PatchSet: 2

Gerrit-Owner: Samiya Caur <sam...@chromium.org>

Gerrit-Reviewer: Ergün Erdoğmuş <erg...@chromium.org>

Gerrit-Reviewer: Samiya Caur <sam...@chromium.org>

Gerrit-Attention: Ergün Erdoğmuş <erg...@chromium.org>

Gerrit-Comment-Date: Tue, 30 Dec 2025 10:35:11 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Ergün Erdoğmuş (Gerrit)]

Attention needed from Samiya Caur

Ergün Erdoğmuş voted and added 1 comment

Votes added by Ergün Erdoğmuş

Code-Review	+1
Commit-Queue	+2

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Ergün Erdoğmuş . resolved

Wohoooo! 🥳

Open in Gerrit

Related details

Attention is currently required from:

• Samiya Caur

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: devtools/devtools-frontend

Gerrit-Branch: main

Gerrit-Change-Id: I007bd5bf2de008965a92a6e8f019a9705b445498

Gerrit-Change-Number: 7316929

Gerrit-PatchSet: 2

Gerrit-Owner: Samiya Caur <sam...@chromium.org>

Gerrit-Reviewer: Ergün Erdoğmuş <erg...@chromium.org>

Gerrit-Reviewer: Samiya Caur <sam...@chromium.org>

Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Samiya Caur <sam...@chromium.org>

Gerrit-Comment-Date: Tue, 30 Dec 2025 12:14:24 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Devtools-frontend LUCI CQ (Gerrit)]

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:

Clean up code in AiCodeCompletion which is already part of Provider

Bug: 445394511

Change-Id: I007bd5bf2de008965a92a6e8f019a9705b445498

Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7316929

Commit-Queue: Ergün Erdoğmuş <erg...@chromium.org>

Reviewed-by: Ergün Erdoğmuş <erg...@chromium.org>

Auto-Submit: Samiya Caur <sam...@chromium.org>

Files:

• M front_end/models/ai_code_completion/AiCodeCompletion.test.ts
• M front_end/models/ai_code_completion/AiCodeCompletion.ts
• M front_end/ui/components/text_editor/AiCodeCompletionProvider.test.ts
• M front_end/ui/components/text_editor/AiCodeCompletionProvider.ts

Change size: L

Delta: 4 files changed, 67 insertions(+), 532 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Ergün Erdoğmuş

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: devtools/devtools-frontend

Gerrit-Branch: main

Gerrit-Change-Id: I007bd5bf2de008965a92a6e8f019a9705b445498

Gerrit-Change-Number: 7316929

Gerrit-PatchSet: 3

Gerrit-Owner: Samiya Caur <sam...@chromium.org>

Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>