[Lens / Cookies] Grant secure cookie exemptions for Lens side panel [chromium/src : main]

0 views
Skip to first unread message

Duncan Mercer (Gerrit)

unread,
Mar 31, 2026, 5:10:03 PMMar 31
to Theresa Sullivan, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, devtools...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, dullweb...@chromium.org, ipc-securi...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
Attention needed from Theresa Sullivan

Duncan Mercer voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Theresa Sullivan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7e7e06819012fc3deef8ab13fc3ecb5e89f49bef
Gerrit-Change-Number: 7688714
Gerrit-PatchSet: 12
Gerrit-Owner: Duncan Mercer <mer...@google.com>
Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
Gerrit-Reviewer: Theresa Sullivan <twell...@chromium.org>
Gerrit-Attention: Theresa Sullivan <twell...@chromium.org>
Gerrit-Comment-Date: Tue, 31 Mar 2026 21:09:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Duncan Mercer (Gerrit)

unread,
Mar 31, 2026, 5:10:45 PMMar 31
to Lily Chen, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, devtools...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, dullweb...@chromium.org, ipc-securi...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
Attention needed from Lily Chen

Duncan Mercer added 1 comment

Patchset-level comments
File-level comment, Patchset 12 (Latest):
Duncan Mercer . resolved

Hi Lily! Can you take a general look at this before I send to all the respective owners?

Open in Gerrit

Related details

Attention is currently required from:
  • Lily Chen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7e7e06819012fc3deef8ab13fc3ecb5e89f49bef
Gerrit-Change-Number: 7688714
Gerrit-PatchSet: 12
Gerrit-Owner: Duncan Mercer <mer...@google.com>
Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
Gerrit-Reviewer: Lily Chen <chl...@chromium.org>
Gerrit-Attention: Lily Chen <chl...@chromium.org>
Gerrit-Comment-Date: Tue, 31 Mar 2026 21:10:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Lily Chen (Gerrit)

unread,
Apr 1, 2026, 12:06:17 AMApr 1
to Duncan Mercer, Lily Chen, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, devtools...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, dullweb...@chromium.org, ipc-securi...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
Attention needed from Duncan Mercer

Lily Chen added 4 comments

File chrome/browser/chrome_content_browser_client.cc
Line 2134, Patchset 12 (Latest): top_frame_origin.scheme() == content::kChromeUIUntrustedScheme &&
top_frame_origin.host() == chrome::kChromeUILensHost) {
Lily Chen . unresolved

We should check the whole origin, not just scheme and host. In theory top_frame_origin could be something cursed like chrome-untrusted://lens:8880 and that shouldn't return true here. Could we instead make a GURL out of the Lens URL and then convert that to an origin to check against top_frame_origin? (same below)

File content/browser/devtools/devtools_url_loader_interceptor.cc
Line 1528, Patchset 12 (Latest): url::Origin::Create(create_loader_params_->request
.site_for_cookies.RepresentativeUrl()),
Lily Chen . unresolved

nit: use request.isolation_info.top_frame_origin instead

Line 1691, Patchset 12 (Latest): url::Origin::Create(request.site_for_cookies.RepresentativeUrl()),
Lily Chen . unresolved

ditto

File content/browser/renderer_host/render_frame_host_impl.cc
Line 5483, Patchset 12 (Latest): // Reset the SiteForCookies if the top frame origin is of a scheme that should
Lily Chen . unresolved

nit: update comment

Open in Gerrit

Related details

Attention is currently required from:
  • Duncan Mercer
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7e7e06819012fc3deef8ab13fc3ecb5e89f49bef
    Gerrit-Change-Number: 7688714
    Gerrit-PatchSet: 12
    Gerrit-Owner: Duncan Mercer <mer...@google.com>
    Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
    Gerrit-Reviewer: Lily Chen <chl...@chromium.org>
    Gerrit-Attention: Duncan Mercer <mer...@google.com>
    Gerrit-Comment-Date: Wed, 01 Apr 2026 04:06:10 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Duncan Mercer (Gerrit)

    unread,
    Apr 9, 2026, 4:14:50 PM (10 days ago) Apr 9
    to Lily Chen, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, devtools...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, dullweb...@chromium.org, ipc-securi...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
    Attention needed from Lily Chen

    Duncan Mercer added 4 comments

    File chrome/browser/chrome_content_browser_client.cc
    Line 2134, Patchset 12: top_frame_origin.scheme() == content::kChromeUIUntrustedScheme &&
    top_frame_origin.host() == chrome::kChromeUILensHost) {
    Lily Chen . resolved

    We should check the whole origin, not just scheme and host. In theory top_frame_origin could be something cursed like chrome-untrusted://lens:8880 and that shouldn't return true here. Could we instead make a GURL out of the Lens URL and then convert that to an origin to check against top_frame_origin? (same below)

    Duncan Mercer

    Done

    File content/browser/devtools/devtools_url_loader_interceptor.cc
    Line 1528, Patchset 12: url::Origin::Create(create_loader_params_->request
    .site_for_cookies.RepresentativeUrl()),
    Lily Chen . resolved

    nit: use request.isolation_info.top_frame_origin instead

    Duncan Mercer

    Done

    Line 1691, Patchset 12: url::Origin::Create(request.site_for_cookies.RepresentativeUrl()),
    Lily Chen . resolved

    ditto

    Duncan Mercer

    Done

    File content/browser/renderer_host/render_frame_host_impl.cc
    Line 5483, Patchset 12: // Reset the SiteForCookies if the top frame origin is of a scheme that should
    Lily Chen . resolved

    nit: update comment

    Duncan Mercer

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Lily Chen
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I7e7e06819012fc3deef8ab13fc3ecb5e89f49bef
      Gerrit-Change-Number: 7688714
      Gerrit-PatchSet: 15
      Gerrit-Owner: Duncan Mercer <mer...@google.com>
      Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
      Gerrit-Reviewer: Lily Chen <chl...@chromium.org>
      Gerrit-Attention: Lily Chen <chl...@chromium.org>
      Gerrit-Comment-Date: Thu, 09 Apr 2026 20:14:44 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Lily Chen <chl...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Duncan Mercer (Gerrit)

      unread,
      Apr 9, 2026, 4:15:14 PM (10 days ago) Apr 9
      to Lily Chen, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, devtools...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, dullweb...@chromium.org, ipc-securi...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
      Attention needed from Lily Chen

      Duncan Mercer added 1 comment

      Patchset-level comments
      File-level comment, Patchset 15 (Latest):
      Duncan Mercer . unresolved

      Unresolved comment to my self to re-verify the changes work before submitting.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Lily Chen
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I7e7e06819012fc3deef8ab13fc3ecb5e89f49bef
        Gerrit-Change-Number: 7688714
        Gerrit-PatchSet: 15
        Gerrit-Owner: Duncan Mercer <mer...@google.com>
        Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
        Gerrit-Reviewer: Lily Chen <chl...@chromium.org>
        Gerrit-Attention: Lily Chen <chl...@chromium.org>
        Gerrit-Comment-Date: Thu, 09 Apr 2026 20:15:09 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Duncan Mercer (Gerrit)

        unread,
        Apr 10, 2026, 10:19:30 AM (9 days ago) Apr 10
        to Lily Chen, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, dullweb...@chromium.org, ipc-securi...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
        Attention needed from Lily Chen

        Duncan Mercer voted and added 1 comment

        Votes added by Duncan Mercer

        Commit-Queue+1

        1 comment

        Patchset-level comments
        File-level comment, Patchset 15:
        Duncan Mercer . resolved

        Unresolved comment to my self to re-verify the changes work before submitting.

        Duncan Mercer

        Done

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Lily Chen
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement is not satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I7e7e06819012fc3deef8ab13fc3ecb5e89f49bef
          Gerrit-Change-Number: 7688714
          Gerrit-PatchSet: 15
          Gerrit-Owner: Duncan Mercer <mer...@google.com>
          Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
          Gerrit-Reviewer: Lily Chen <chl...@chromium.org>
          Gerrit-Attention: Lily Chen <chl...@chromium.org>
          Gerrit-Comment-Date: Fri, 10 Apr 2026 14:19:25 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: Yes
          Comment-In-Reply-To: Duncan Mercer <mer...@google.com>
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Lily Chen (Gerrit)

          unread,
          Apr 11, 2026, 4:46:17 PM (8 days ago) Apr 11
          to Duncan Mercer, Lily Chen, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, dullweb...@chromium.org, ipc-securi...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
          Attention needed from Duncan Mercer

          Lily Chen voted Code-Review+1

          Code-Review+1
          Open in Gerrit

          Related details

          Attention is currently required from:
          • Duncan Mercer
          Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement is not satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: I7e7e06819012fc3deef8ab13fc3ecb5e89f49bef
            Gerrit-Change-Number: 7688714
            Gerrit-PatchSet: 16
            Gerrit-Owner: Duncan Mercer <mer...@google.com>
            Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
            Gerrit-Reviewer: Lily Chen <chl...@chromium.org>
            Gerrit-Attention: Duncan Mercer <mer...@google.com>
            Gerrit-Comment-Date: Sat, 11 Apr 2026 20:46:10 +0000
            Gerrit-HasComments: No
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy

            Duncan Mercer (Gerrit)

            unread,
            Apr 13, 2026, 10:02:35 AM (6 days ago) Apr 13
            to Avi Drissman, Jonathan Ross, Eric Orth, Alex Rudenko, Lily Chen, chromiu...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, dullweb...@chromium.org, ipc-securi...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
            Attention needed from Alex Rudenko, Avi Drissman, Eric Orth and Jonathan Ross

            Duncan Mercer added 1 comment

            Patchset-level comments
            File-level comment, Patchset 16 (Latest):
            Duncan Mercer . resolved

            Adding relevant file owners. Lily already took an overall review, so please review the files you have owners in.

            Open in Gerrit

            Related details

            Attention is currently required from:
            • Alex Rudenko
            • Avi Drissman
            • Eric Orth
            • Jonathan Ross
            Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement is not satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: I7e7e06819012fc3deef8ab13fc3ecb5e89f49bef
            Gerrit-Change-Number: 7688714
            Gerrit-PatchSet: 16
            Gerrit-Owner: Duncan Mercer <mer...@google.com>
            Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
            Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
            Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
            Gerrit-Reviewer: Eric Orth <eric...@chromium.org>
            Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
            Gerrit-Reviewer: Lily Chen <chl...@chromium.org>
            Gerrit-Attention: Jonathan Ross <jon...@chromium.org>
            Gerrit-Attention: Avi Drissman <a...@chromium.org>
            Gerrit-Attention: Eric Orth <eric...@chromium.org>
            Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
            Gerrit-Comment-Date: Mon, 13 Apr 2026 14:02:00 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: No
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy

            Avi Drissman (Gerrit)

            unread,
            Apr 13, 2026, 10:34:09 AM (6 days ago) Apr 13
            to Duncan Mercer, Avi Drissman, Jonathan Ross, Eric Orth, Alex Rudenko, Lily Chen, chromiu...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, dullweb...@chromium.org, ipc-securi...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
            Attention needed from Alex Rudenko, Duncan Mercer, Eric Orth and Jonathan Ross

            Avi Drissman voted Code-Review+1

            Code-Review+1
            Open in Gerrit

            Related details

            Attention is currently required from:
            • Alex Rudenko
            • Duncan Mercer
            • Eric Orth
            • Jonathan Ross
            Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: I7e7e06819012fc3deef8ab13fc3ecb5e89f49bef
            Gerrit-Change-Number: 7688714
            Gerrit-PatchSet: 16
            Gerrit-Owner: Duncan Mercer <mer...@google.com>
            Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
            Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
            Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
            Gerrit-Reviewer: Eric Orth <eric...@chromium.org>
            Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
            Gerrit-Reviewer: Lily Chen <chl...@chromium.org>
            Gerrit-Attention: Jonathan Ross <jon...@chromium.org>
            Gerrit-Attention: Duncan Mercer <mer...@google.com>
            Gerrit-Attention: Eric Orth <eric...@chromium.org>
            Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
            Gerrit-Comment-Date: Mon, 13 Apr 2026 14:34:03 +0000
            Gerrit-HasComments: No
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            open
            diffy

            Duncan Mercer (Gerrit)

            unread,
            Apr 13, 2026, 10:39:00 AM (6 days ago) Apr 13
            to Avi Drissman, Lily Chen, chromiu...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, dullweb...@chromium.org, ipc-securi...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org

            Duncan Mercer voted Commit-Queue+2

            Commit-Queue+2
            Open in Gerrit

            Related details

            Attention set is empty
            Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: I7e7e06819012fc3deef8ab13fc3ecb5e89f49bef
            Gerrit-Change-Number: 7688714
            Gerrit-PatchSet: 16
            Gerrit-Owner: Duncan Mercer <mer...@google.com>
            Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
            Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
            Gerrit-Comment-Date: Mon, 13 Apr 2026 14:38:49 +0000
            Gerrit-HasComments: No
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            open
            diffy

            chromium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

            unread,
            Apr 13, 2026, 11:44:26 AM (6 days ago) Apr 13
            to Duncan Mercer, Avi Drissman, Lily Chen, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, dullweb...@chromium.org, ipc-securi...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org

            chromiu...@luci-project-accounts.iam.gserviceaccount.com submitted the change

            Change information

            Commit message:
            [Lens / Cookies] Grant secure cookie exemptions for Lens side panel

            This change grants a temporary secure cookie exemption for the Lens untrusted side panel (chrome-untrusted://lens) to use SameSite cookies. It updates ContentBrowserClient to support origin-based first-party cookie checks and registers the Lens origin in ProfileNetworkContextService and ChromeContentRendererClient.
            Bug: b:483614998
            Change-Id: I7e7e06819012fc3deef8ab13fc3ecb5e89f49bef
            Reviewed-by: Lily Chen <chl...@chromium.org>
            Reviewed-by: Avi Drissman <a...@chromium.org>
            Commit-Queue: Duncan Mercer <mer...@google.com>
            Cr-Commit-Position: refs/heads/main@{#1613745}
            Files:
            • M chrome/browser/chrome_content_browser_client.cc
            • M chrome/browser/chrome_content_browser_client.h
            • M chrome/browser/net/profile_network_context_service.cc
            • M chrome/renderer/chrome_content_renderer_client.cc
            • M content/browser/devtools/devtools_url_loader_interceptor.cc
            • M content/browser/renderer_host/render_frame_host_impl.cc
            • M content/browser/renderer_host/render_frame_host_impl_browsertest.cc
            • M content/public/browser/content_browser_client.cc
            • M content/public/browser/content_browser_client.h
            Change size: M
            Delta: 9 files changed, 85 insertions(+), 31 deletions(-)
            Branch: refs/heads/main
            Submit Requirements:
            • requirement satisfiedCode-Review: +1 by Lily Chen, +1 by Avi Drissman
            Open in Gerrit
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: merged
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: I7e7e06819012fc3deef8ab13fc3ecb5e89f49bef
            Gerrit-Change-Number: 7688714
            Gerrit-PatchSet: 17
            Gerrit-Owner: Duncan Mercer <mer...@google.com>
            Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
            Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
            Gerrit-Reviewer: Lily Chen <chl...@chromium.org>
            open
            diffy
            satisfied_requirement
            Reply all
            Reply to author
            Forward
            0 new messages