[cleanup] Correctly mark config as ESM [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Nikolay Vitkov (Gerrit)
Nov 5, 2025, 7:40:33 AM (2 days ago) Nov 5
to Philip Pfaffe, devtools-rev...@chromium.org
Attention needed from Philip Pfaffe
Nikolay Vitkov voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Philip Pfaffe
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Pfaffe (Gerrit)
Nov 5, 2025, 7:49:10 AM (2 days ago) Nov 5
to Nikolay Vitkov, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Nikolay Vitkov
Philip Pfaffe voted![]( "Open in Gerrit")
Attention is currently required from:
- Nikolay Vitkov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikolay Vitkov (Gerrit)
Nov 5, 2025, 10:35:40 AM (2 days ago) Nov 5
to Philip Pfaffe, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Philip Pfaffe
Nikolay Vitkov voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Philip Pfaffe
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
Nov 5, 2025, 10:36:34 AM (2 days ago) Nov 5
to Nikolay Vitkov, Philip Pfaffe, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: extensions/cxx_debugging/src/CMakeLists.txt
Insertions: 1, Deletions: 1.
@@ -36,7 +36,7 @@
list(APPEND EXTENSION_BUNDLED_SOURCES ${CMAKE_CURRENT_BINARY_DIR}/${NAME_WE}.bundle.js)
endforeach()
-configure_file(rollup.config.in.js rollup.config.in.js @ONLY)
+configure_file(rollup.config.in.mjs rollup.config.in.mjs @ONLY)
file(GENERATE OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/rollup.config.mjs
INPUT ${CMAKE_CURRENT_BINARY_DIR}/rollup.config.in.mjs)
```
Change information
Commit message:
[cleanup] Correctly mark config as ESM
I noticed warning in the console related to this,
that were causing noise to my actual error.
Bug: none
Change-Id: Ifd5bacb9029cea84640a074c924fb16af35f1ea4
Auto-Submit: Nikolay Vitkov <nvi...@chromium.org>
Reviewed-by: Philip Pfaffe <pfa...@chromium.org>
Commit-Queue: Nikolay Vitkov <nvi...@chromium.org>
Files:
- M extensions/cxx_debugging/src/CMakeLists.txt
- R extensions/cxx_debugging/src/rollup.config.in.mjs
- M front_end/models/live-metrics/web-vitals-injected/README.md
Change size: S
Delta: 3 files changed, 5 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Philip Pfaffe
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages