Fix tabs not revealing correctly in narrow tab bar. [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Piotr Paulski (Gerrit)
Sep 23, 2025, 12:01:30 PM (2 days ago) Sep 23
to Ergün Erdoğmuş, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Ergün Erdoğmuş
Piotr Paulski voted and added 1 comment![]( "Open in Gerrit")
Votes added by Piotr Paulski
| Auto-Submit | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Piotr Paulski . resolved
Hopefully last fix related to flexible layout, PTAL :-)
Related details
Attention is currently required from:
- Ergün Erdoğmuş
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ergün Erdoğmuş (Gerrit)
Sep 24, 2025, 5:01:55 AM (22 hours ago) Sep 24
to Piotr Paulski, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Piotr Paulski
Ergün Erdoğmuş voted![]( "Open in Gerrit")
Attention is currently required from:
- Piotr Paulski
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
Sep 24, 2025, 5:03:22 AM (22 hours ago) Sep 24
to Piotr Paulski, Ergün Erdoğmuş, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix tabs not revealing correctly in narrow tab bar.
Initially the problem was detected for console panel reveal in drawer
caused by running a snippet from sources panel. Later confirmed to also
affect all other ways to reveal a panel in a narrow tab bar, except if
the action is triggered from dropdown menu.
Problem was caused by skipped check if the tab header is visible or
hidden in the overflow menu. Aligning selectTab behavior across all use
cases fixes the issue.
Fixed: 445900611
Change-Id: I6d3b9e2446f5fd0d5f80eb8efdb1eaa2ca69deeb
Commit-Queue: Ergün Erdoğmuş <erg...@chromium.org>
Reviewed-by: Ergün Erdoğmuş <erg...@chromium.org>
Auto-Submit: Piotr Paulski <piotrp...@chromium.org>
Files:
- M front_end/ui/legacy/TabbedPane.ts
Change size: XS
Delta: 1 file changed, 2 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ergün Erdoğmuş
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages