ChromeDriver: Reject mismatched element and shadow root references [chromium/src : main]
Julio Piubello (Gerrit)
New activity on the change![]( "Open in Gerrit")
Related details
- Alex Rudenko
- Maksim Sadym
- Rubens Rafael
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maksim Sadym (Gerrit)
Maksim Sadym added 1 comment![]( "Open in Gerrit")
[AI] Please add these footers to verify the updated WebDriver WPT expectations on CQ (`linux-blink-rel` and `android-15-chrome-blink-rel` are needed because of baseline changes; `linux-surface-embed-rel` because `take_element_screenshot` baseline was modified):\n\n```text\nCq-Include-Trybots: luci.chromium.try:linux-blink-rel,android-15-chrome-blink-rel,android-16-x64-rel,linux-surface-embed-rel\nInclude-Ci-Only-Tests: chromium.fyi:linux-surface-embed-rel|surface_embed_chrome_wpt_tests\n```
Related details
- Alex Rudenko
- Rubens Rafael
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Alex Rudenko voted Code-Review+1![]( "Open in Gerrit")
- Rubens Rafael
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maksim Sadym (Gerrit)
Maksim Sadym voted and added 2 comments![]( "Open in Gerrit")
Votes added by Maksim Sadym <sa...@chromium.org>
| Commit-Queue | +1 |
[AI] Please add these footers to verify the updated WebDriver WPT expectations on CQ (`linux-blink-rel` and `android-15-chrome-blink-rel` are needed because of baseline changes; `linux-surface-embed-rel` because `take_element_screenshot` baseline was modified):\n\n```text\nCq-Include-Trybots: luci.chromium.try:linux-blink-rel,android-15-chrome-blink-rel,android-16-x64-rel,linux-surface-embed-rel\nInclude-Ci-Only-Tests: chromium.fyi:linux-surface-embed-rel|surface_embed_chrome_wpt_tests\n```
Done
const INITIAL_ELEMENT_KEY = 'ELEMENT';[AI] `INITIAL_ELEMENT_KEY` is only needed because `callFunction()` reassigns `ELEMENT_KEY = W3C_ELEMENT_KEY` (line 411) before `resolveReferences()` runs. In W3C mode, `ELEMENT_KEY` then no longer matches the legacy `'ELEMENT'` key, which can still reach line 354 because `WebViewImpl::ResolveElementReferencesInPlace()` resolves both keys.
Consider making `ELEMENT_KEY` a real constant and choosing the output key where it is used (`w3cEnabled` is already set, but never read):
```js
const ELEMENT_KEY = 'ELEMENT';
// In preprocessResult():
let key = w3cEnabled ? W3C_ELEMENT_KEY : ELEMENT_KEY;
```
Then `callFunction()` only sets `w3cEnabled = true;`, line 354 and `call_function_test.html` can use `ELEMENT_KEY`, and `INITIAL_ELEMENT_KEY` can be removed.
Alex Rudenko (Gerrit)
Alex Rudenko voted and added 1 comment on change 8359688![]( "Open in Gerrit")
Votes added by Alex Rudenko <alexr...@chromium.org>
| Code-Review | +1 |
Related details
- Julio Piubello
- Rubens Rafael
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maksim Sadym (Gerrit)
Maksim Sadym voted and added 1 comment on change 8359688![]( "Open in Gerrit")
Votes added by Maksim Sadym <sa...@chromium.org>
| Code-Review | +1 |
| Commit-Queue | +1 |
1 comment
[AI] `INITIAL_ELEMENT_KEY` is only needed because `callFunction()` reassigns `ELEMENT_KEY = W3C_ELEMENT_KEY` (line 411) before `resolveReferences()` runs. In W3C mode, `ELEMENT_KEY` then no longer matches the legacy `'ELEMENT'` key, which can still reach line 354 because `WebViewImpl::ResolveElementReferencesInPlace()` resolves both keys.
Consider making `ELEMENT_KEY` a real constant and choosing the output key where it is used (`w3cEnabled` is already set, but never read):
```js
const ELEMENT_KEY = 'ELEMENT';// In preprocessResult():
let key = w3cEnabled ? W3C_ELEMENT_KEY : ELEMENT_KEY;
```Then `callFunction()` only sets `w3cEnabled = true;`, line 354 and `call_function_test.html` can use `ELEMENT_KEY`, and `INITIAL_ELEMENT_KEY` can be removed.
Done
Related details
- Julio Piubello
- Rubens Rafael
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maksim Sadym (Gerrit)
Maksim Sadym voted Commit-Queue+2 on change 8359688![]( "Open in Gerrit")
| Commit-Queue | +2 |
Blink W3C Test Autoroller (Gerrit)
Message from Blink W3C Test Autoroller on change 8359688![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/64034.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
- Julio Piubello
- Rubens Rafael
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
ChromeDriver: Reject mismatched element and shadow root references
ChromeDriver resolved WebDriver element and shadow-root IDs without
verifying that the supplied reference key matched the resulting node
type. A shadow root could therefore reach commands that require an
element, while a shadow-root command could receive an element or generic
DocumentFragment.
Validate reference types in the shared call_function.js deserializer
before checking node reachability. Preserve the native ShadowRoot
constructor during DevTools setup so page changes to the global
constructor do not affect serialization or deserialization. Continue to
accept Document nodes for internal script arguments.
Add unit and integration coverage for mismatched references, error
precedence, replaced constructors, and BiDi DocumentFragment shared IDs.
Update Linux and Android WPT baselines for the shared deserializer.
Overview doc: https://docs.google.com/document/d/1hH_O87bKywuQQV2_m4CzmgTcI7BmLXJojCxTTSTInR0/edit?tab=t.0
- M chrome/test/chromedriver/chrome/devtools_client_impl.cc
- M chrome/test/chromedriver/js/call_function.js
- M chrome/test/chromedriver/js/call_function_test.html
- M chrome/test/chromedriver/js/test.js
- M chrome/test/chromedriver/test/run_py_tests.py
- M third_party/blink/web_tests/external/wpt/webdriver/tests/interop/shared_id_node.py
- M third_party/blink/web_tests/platform/android/external/wpt/webdriver/tests/classic/element_send_keys/send_keys-expected.txt
- D third_party/blink/web_tests/platform/android/external/wpt/webdriver/tests/classic/get_computed_label/get-expected.txt
- D third_party/blink/web_tests/platform/android/external/wpt/webdriver/tests/classic/get_computed_role/get-expected.txt
- M third_party/blink/web_tests/platform/android/external/wpt/webdriver/tests/classic/get_element_css_value/get-expected.txt
- M third_party/blink/web_tests/platform/android/external/wpt/webdriver/tests/classic/get_element_rect/get-expected.txt
- M third_party/blink/web_tests/platform/android/external/wpt/webdriver/tests/classic/get_element_tag_name/get-expected.txt
- M third_party/blink/web_tests/platform/android/external/wpt/webdriver/tests/classic/get_element_text/get-expected.txt
- M third_party/blink/web_tests/platform/android/external/wpt/webdriver/tests/classic/is_element_selected/selected-expected.txt
- M third_party/blink/web_tests/platform/android/external/wpt/webdriver/tests/classic/take_element_screenshot/screenshot-expected.txt
- M third_party/blink/web_tests/platform/linux/external/wpt/webdriver/tests/classic/element_clear/clear-expected.txt
- M third_party/blink/web_tests/platform/linux/external/wpt/webdriver/tests/classic/element_send_keys/send_keys-expected.txt
- M third_party/blink/web_tests/platform/linux/external/wpt/webdriver/tests/classic/find_element_from_element/find-expected.txt
- M third_party/blink/web_tests/platform/linux/external/wpt/webdriver/tests/classic/find_elements_from_element/find-expected.txt
- M third_party/blink/web_tests/platform/linux/external/wpt/webdriver/tests/classic/find_elements_from_shadow_root/find-expected.txt
- D third_party/blink/web_tests/platform/linux/external/wpt/webdriver/tests/classic/get_computed_label/get-expected.txt
- D third_party/blink/web_tests/platform/linux/external/wpt/webdriver/tests/classic/get_computed_role/get-expected.txt
- M third_party/blink/web_tests/platform/linux/external/wpt/webdriver/tests/classic/get_element_attribute/get-expected.txt
- M third_party/blink/web_tests/platform/linux/external/wpt/webdriver/tests/classic/get_element_css_value/get-expected.txt
- M third_party/blink/web_tests/platform/linux/external/wpt/webdriver/tests/classic/get_element_property/get-expected.txt
- M third_party/blink/web_tests/platform/linux/external/wpt/webdriver/tests/classic/get_element_rect/get-expected.txt
- M third_party/blink/web_tests/platform/linux/external/wpt/webdriver/tests/classic/get_element_tag_name/get-expected.txt
- M third_party/blink/web_tests/platform/linux/external/wpt/webdriver/tests/classic/get_element_text/get-expected.txt
- M third_party/blink/web_tests/platform/linux/external/wpt/webdriver/tests/classic/is_element_enabled/enabled-expected.txt
- M third_party/blink/web_tests/platform/linux/external/wpt/webdriver/tests/classic/is_element_selected/selected-expected.txt
- M third_party/blink/web_tests/platform/linux/external/wpt/webdriver/tests/classic/take_element_screenshot/screenshot-expected.txt
Code-Review: +1 by Maksim Sadym, +1 by Alex Rudenko
Review-Enforcement: Code-Review+1 by Maksim Sadym, Code-Review+1 by Alex Rudenko
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/64034
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |