Migrate network-log.preserve-log setting to SettingDescriptor [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Simon Zünd (Gerrit)
7:02 AM (3 hours ago) 7:02 AM
to Alex Rudenko, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Alex Rudenko
Simon Zünd voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Alex Rudenko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
7:14 AM (3 hours ago) 7:14 AM
to Simon Zünd, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Simon Zünd
Alex Rudenko voted![]( "Open in Gerrit")
Attention is currently required from:
- Simon Zünd
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
8:12 AM (2 hours ago) 8:12 AM
to Simon Zünd, Alex Rudenko, devtools-rev...@chromium.org
devtools-fro...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Migrate network-log.preserve-log setting to SettingDescriptor
This CL migrates the `network-log.preserve-log` setting from a
SettingRegistration in `front_end/models/logs/logs-meta.ts` to a
SettingDescriptor in `SDKSettings.ts` and registers its UI descriptor
in `front_end/panels/network/network-meta.ts`.
Bug: 535451658
Change-Id: I0f13c86b005f64097e612afff09ab1cfe2f0480e
TAG=agy
CONV=be04dab5-6365-426e-a74b-e01f2db639bd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/8263634
Commit-Queue: Alex Rudenko <alexr...@chromium.org>
Auto-Submit: Simon Zünd <szu...@chromium.org>
Commit-Queue: Simon Zünd <szu...@chromium.org>
Reviewed-by: Alex Rudenko <alexr...@chromium.org>
Files:
- M front_end/core/sdk/NetworkManager.ts
- M front_end/core/sdk/SDKSettings.ts
- M front_end/models/logs/NetworkLog.test.ts
- M front_end/models/logs/NetworkLog.ts
- M front_end/models/logs/logs-meta.ts
- M front_end/panels/network/NetworkLogView.test.ts
- M front_end/panels/network/NetworkLogView.ts
- M front_end/panels/network/NetworkPanel.ts
- M front_end/panels/network/network-meta.ts
Change size: M
Delta: 9 files changed, 76 insertions(+), 70 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alex Rudenko
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages