var evaluation checks main cascade for variables not found in pseudo cascade [devtools/devtools-frontend : main]

0 views

Skip to first unread message

Eric Leese (Gerrit)

unread,

7:05 AM (16 hours ago) 7:05 AM

to Benedikt Meurer, Devtools-frontend LUCI CQ, AyeAye, devtools-rev...@chromium.org

Attention needed from Benedikt Meurer

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Benedikt Meurer

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Benedikt Meurer (Gerrit)

unread,

8:03 AM (16 hours ago) 8:03 AM

to Eric Leese, Devtools-frontend LUCI CQ, AyeAye, devtools-rev...@chromium.org

Attention needed from Eric Leese

Benedikt Meurer voted Code-Review+1

Code-Review

Open in Gerrit

Related details

Attention is currently required from:

Eric Leese

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Eric Leese (Gerrit)

unread,

8:04 AM (16 hours ago) 8:04 AM

to Devtools-frontend LUCI CQ, AyeAye, devtools-rev...@chromium.org

Eric Leese voted Commit-Queue+2

Commit-Queue

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,

8:05 AM (15 hours ago) 8:05 AM

to Eric Leese, Benedikt Meurer, AyeAye, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:

var evaluation checks main cascade for variables not found in pseudo cascade

Pseudo elements inherit var values from their DOM elements. Previously this
worked when inspecting a pseudo element but not when looking at the pseudo
element styles while inspecting the DOM element, because the pseudo elements
have their own cascades. With this change, pseudo element cascades fall back
to the main cascade and accumulate variables from it.

Bug: 40946024

Change-Id: Ibd3e3280cdc8584b6a570264aeed08b659955853

Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7359526

Reviewed-by: Benedikt Meurer <bme...@chromium.org>

Commit-Queue: Eric Leese <le...@chromium.org>

Files:

M front_end/core/sdk/CSSMatchedStyles.test.ts
M front_end/core/sdk/CSSMatchedStyles.ts

Change size: M

Delta: 2 files changed, 141 insertions(+), 10 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Benedikt Meurer

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages