[protocol] Remove Node URL patching [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Simon Zünd (Gerrit)
Nov 4, 2025, 4:22:49 AM (3 days ago) Nov 4
to Devtools-frontend LUCI CQ, Benedikt Meurer, devtools-rev...@chromium.org
Attention needed from Benedikt Meurer
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Benedikt Meurer
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benedikt Meurer (Gerrit)
Nov 4, 2025, 4:26:05 AM (3 days ago) Nov 4
to Simon Zünd, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Simon Zünd
Benedikt Meurer voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Simon Zünd
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Simon Zünd (Gerrit)
Nov 5, 2025, 3:06:44 AM (2 days ago) Nov 5
to Alex Rudenko, Benedikt Meurer, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Alex Rudenko and Benedikt Meurer
Simon Zünd voted and added 1 comment![]( "Open in Gerrit")
Votes added by Simon Zünd
| Auto-Submit | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Simon Zünd . resolved
Lost Benedikt's +1 and not sure if he is working today.
Related details
Attention is currently required from:
- Alex Rudenko
- Benedikt Meurer
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Nov 5, 2025, 3:07:24 AM (2 days ago) Nov 5
to Simon Zünd, Benedikt Meurer, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Benedikt Meurer and Simon Zünd
Alex Rudenko voted![]( "Open in Gerrit")
Attention is currently required from:
- Benedikt Meurer
- Simon Zünd
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
Nov 5, 2025, 3:29:11 AM (2 days ago) Nov 5
to Simon Zünd, Alex Rudenko, Benedikt Meurer, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[protocol] Remove Node URL patching
This CL removes the Node.js specific patching of CDP messages. The
SessionRouter would scan for "url" fields and turn file paths into
file URLs.
This was required back for Node 8, but is no longer required since
Node 10 so we remove it.
We keep the 'markAsNodejsTargetForTest' on the base target. It is
used by web tests to create node targets.
R=bme...@chromium.org
Bug: 453469270
Change-Id: If313a3ea50cf7bdc4623357aac034efc82c76b7c
Auto-Submit: Simon Zünd <szu...@chromium.org>
Commit-Queue: Alex Rudenko <alexr...@chromium.org>
Reviewed-by: Alex Rudenko <alexr...@chromium.org>
Files:
- M config/gni/devtools_grd_files.gni
- M front_end/core/protocol_client/BUILD.gn
- A front_end/core/protocol_client/Dummy.test.ts
- M front_end/core/protocol_client/InspectorBackend.ts
- D front_end/core/protocol_client/NodeURL.test.ts
- D front_end/core/protocol_client/NodeURL.ts
- M front_end/core/protocol_client/protocol_client.ts
- M front_end/core/sdk/DebuggerModel.ts
- M front_end/core/sdk/Target.ts
Change size: M
Delta: 9 files changed, 17 insertions(+), 164 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alex Rudenko
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages