[A11Y] Adding dump tests for APG Slider patterns [chromium/src : main]

0 views
Skip to first unread message

Aditya Batra (Gerrit)

unread,
Apr 13, 2026, 10:03:45 AM (2 days ago) Apr 13
to Kyra Seevers, David Tseng, Jerome Jiang, Mirko Bonadei, Kevin Babbitt, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, fgal...@chromium.org, chrome-intell...@chromium.org, devtools...@chromium.org, mar...@chromium.org, chrome-intelligence-te...@google.com, jz...@chromium.org, net-r...@chromium.org, penghuan...@chromium.org, cblume...@chromium.org, lucasrada...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, michaelchec...@google.com, nektar...@chromium.org, yongshun+...@google.com, yuzo+...@chromium.org
Attention needed from David Tseng and Kyra Seevers

Aditya Batra added 1 comment

Patchset-level comments
File-level comment, Patchset 15 (Latest):
Aditya Batra . resolved

This change is ready for review. Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • David Tseng
  • Kyra Seevers
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iee84911933263512d1ed588a9456f92df7758446
Gerrit-Change-Number: 7737301
Gerrit-PatchSet: 15
Gerrit-Owner: Aditya Batra <adib...@google.com>
Gerrit-Reviewer: Aditya Batra <adib...@google.com>
Gerrit-Reviewer: David Tseng <dts...@chromium.org>
Gerrit-Reviewer: Kyra Seevers <kyras...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Jerome Jiang <ji...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-Attention: Kyra Seevers <kyras...@chromium.org>
Gerrit-Attention: David Tseng <dts...@chromium.org>
Gerrit-Comment-Date: Mon, 13 Apr 2026 14:03:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kyra Seevers (Gerrit)

unread,
Apr 13, 2026, 11:43:47 AM (2 days ago) Apr 13
to Aditya Batra, David Tseng, Jerome Jiang, Mirko Bonadei, Kevin Babbitt, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, fgal...@chromium.org, chrome-intell...@chromium.org, devtools...@chromium.org, mar...@chromium.org, chrome-intelligence-te...@google.com, jz...@chromium.org, net-r...@chromium.org, penghuan...@chromium.org, cblume...@chromium.org, lucasrada...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, michaelchec...@google.com, nektar...@chromium.org, yongshun+...@google.com, yuzo+...@chromium.org
Attention needed from Aditya Batra and David Tseng

Kyra Seevers voted and added 2 comments

Votes added by Kyra Seevers

Code-Review+1

2 comments

Patchset-level comments
Kyra Seevers . resolved

Thanks for adding these slider tests!

File content/test/data/accessibility/aria/apg-patterns/aria-slider-color-viewer-expected-android.txt
Line 5, Patchset 15 (Latest):++++android.widget.SeekBar clickable focusable range interesting name='Red' item_index=50 item_count=100 range_max=255 range_current_value=128
Kyra Seevers . unresolved

I don't think that the item_index and item_count fields are strictly necessary here because it isn't what we are measuring, but I am fine with leaving them here if David would prefer to have more information in the test rather than less!

Open in Gerrit

Related details

Attention is currently required from:
  • Aditya Batra
  • David Tseng
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iee84911933263512d1ed588a9456f92df7758446
    Gerrit-Change-Number: 7737301
    Gerrit-PatchSet: 15
    Gerrit-Owner: Aditya Batra <adib...@google.com>
    Gerrit-Reviewer: Aditya Batra <adib...@google.com>
    Gerrit-Reviewer: David Tseng <dts...@chromium.org>
    Gerrit-Reviewer: Kyra Seevers <kyras...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Jerome Jiang <ji...@chromium.org>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
    Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
    Gerrit-Attention: Aditya Batra <adib...@google.com>
    Gerrit-Attention: David Tseng <dts...@chromium.org>
    Gerrit-Comment-Date: Mon, 13 Apr 2026 15:43:39 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    David Tseng (Gerrit)

    unread,
    Apr 13, 2026, 2:48:36 PM (2 days ago) Apr 13
    to Aditya Batra, Kyra Seevers, Jerome Jiang, Mirko Bonadei, Kevin Babbitt, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, fgal...@chromium.org, chrome-intell...@chromium.org, devtools...@chromium.org, mar...@chromium.org, chrome-intelligence-te...@google.com, jz...@chromium.org, net-r...@chromium.org, penghuan...@chromium.org, cblume...@chromium.org, lucasrada...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, michaelchec...@google.com, nektar...@chromium.org, yongshun+...@google.com, yuzo+...@chromium.org
    Attention needed from Aditya Batra

    David Tseng voted and added 1 comment

    David Tseng added votes with a message

    lgtm

    Code-Review+1

    1 comment

    File content/public/android/javatests/src/org/chromium/content/browser/accessibility/WebContentsAccessibilityTreeTest.java
    Line 1312, Patchset 15 (Latest): public void testAriaSliderMultithumb() {
    David Tseng . unresolved

    nit: worth alphabetizing these for easier lookup in the future.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Aditya Batra
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iee84911933263512d1ed588a9456f92df7758446
    Gerrit-Change-Number: 7737301
    Gerrit-PatchSet: 15
    Gerrit-Owner: Aditya Batra <adib...@google.com>
    Gerrit-Reviewer: Aditya Batra <adib...@google.com>
    Gerrit-Reviewer: David Tseng <dts...@chromium.org>
    Gerrit-Reviewer: Kyra Seevers <kyras...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Jerome Jiang <ji...@chromium.org>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
    Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
    Gerrit-Attention: Aditya Batra <adib...@google.com>
    Gerrit-Comment-Date: Mon, 13 Apr 2026 18:48:23 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    David Tseng (Gerrit)

    unread,
    Apr 13, 2026, 5:31:31 PM (2 days ago) Apr 13
    to Aditya Batra, Kyra Seevers, Jerome Jiang, Mirko Bonadei, Kevin Babbitt, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, fgal...@chromium.org, chrome-intell...@chromium.org, devtools...@chromium.org, mar...@chromium.org, chrome-intelligence-te...@google.com, jz...@chromium.org, net-r...@chromium.org, penghuan...@chromium.org, cblume...@chromium.org, lucasrada...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, michaelchec...@google.com, nektar...@chromium.org, yongshun+...@google.com, yuzo+...@chromium.org
    Attention needed from Aditya Batra and Kyra Seevers

    David Tseng voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Aditya Batra
    • Kyra Seevers
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iee84911933263512d1ed588a9456f92df7758446
      Gerrit-Change-Number: 7737301
      Gerrit-PatchSet: 16
      Gerrit-Owner: Aditya Batra <adib...@google.com>
      Gerrit-Reviewer: Aditya Batra <adib...@google.com>
      Gerrit-Reviewer: David Tseng <dts...@chromium.org>
      Gerrit-Reviewer: Kyra Seevers <kyras...@chromium.org>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: Jerome Jiang <ji...@chromium.org>
      Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
      Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
      Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
      Gerrit-Attention: Aditya Batra <adib...@google.com>
      Gerrit-Attention: Kyra Seevers <kyras...@chromium.org>
      Gerrit-Comment-Date: Mon, 13 Apr 2026 21:31:16 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages