Turn OriginMap into a widget [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Danil Somsikov (Gerrit)

unread,
Mar 23, 2026, 4:02:53 PM (16 hours ago) Mar 23
to Jack Franklin, Devtools-frontend LUCI CQ, AyeAye, devtools-rev...@chromium.org
Attention needed from Jack Franklin

Danil Somsikov voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jack Franklin
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I4dee372cb22e1fb8381b8e796d9cf940919bcdf1
Gerrit-Change-Number: 7694434
Gerrit-PatchSet: 1
Gerrit-Owner: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Jack Franklin <jacktf...@chromium.org>
Gerrit-Comment-Date: Mon, 23 Mar 2026 20:02:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jack Franklin (Gerrit)

unread,
5:20 AM (3 hours ago) 5:20 AM
to Danil Somsikov, Devtools-frontend LUCI CQ, AyeAye, devtools-rev...@chromium.org
Attention needed from Danil Somsikov

Jack Franklin voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Danil Somsikov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I4dee372cb22e1fb8381b8e796d9cf940919bcdf1
Gerrit-Change-Number: 7694434
Gerrit-PatchSet: 1
Gerrit-Owner: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Danil Somsikov <d...@chromium.org>
Gerrit-Comment-Date: Tue, 24 Mar 2026 09:20:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,
5:24 AM (3 hours ago) 5:24 AM
to Danil Somsikov, Jack Franklin, AyeAye, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:
Turn OriginMap into a widget

This change refactors the OriginMap component from a custom element wrapped in a WidgetElement to a standard widget. The FieldSettingsDialog now embeds the OriginMap widget using the widget directive.
Bug: 407751405
Change-Id: I4dee372cb22e1fb8381b8e796d9cf940919bcdf1
Auto-Submit: Danil Somsikov <d...@chromium.org>
Commit-Queue: Jack Franklin <jacktf...@chromium.org>
Reviewed-by: Jack Franklin <jacktf...@chromium.org>
Files:
  • M front_end/panels/timeline/components/FieldSettingsDialog.ts
  • M front_end/panels/timeline/components/OriginMap.test.ts
  • M front_end/panels/timeline/components/OriginMap.ts
Change size: M
Delta: 3 files changed, 26 insertions(+), 40 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Jack Franklin
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I4dee372cb22e1fb8381b8e796d9cf940919bcdf1
Gerrit-Change-Number: 7694434
Gerrit-PatchSet: 2
Gerrit-Owner: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages