[context] Fix handling of mutable heap numbers in debugger ^2 [v8/v8 : main]

17 views
Skip to first unread message

Igor Sheludko (Gerrit)

unread,
Apr 10, 2025, 8:20:54 AM4/10/25
to Toon Verwaest, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Toon Verwaest

Igor Sheludko voted and added 1 comment

Votes added by Igor Sheludko

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Igor Sheludko . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Toon Verwaest
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I49e73fc5c48542f8bf24f720f884b64c17b5fb01
Gerrit-Change-Number: 6446613
Gerrit-PatchSet: 1
Gerrit-Owner: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
Gerrit-Attention: Toon Verwaest <verw...@chromium.org>
Gerrit-Comment-Date: Thu, 10 Apr 2025 12:20:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Toon Verwaest (Gerrit)

unread,
Apr 10, 2025, 8:21:34 AM4/10/25
to Igor Sheludko, V8 LUCI CQ, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Igor Sheludko

Toon Verwaest voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Igor Sheludko
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I49e73fc5c48542f8bf24f720f884b64c17b5fb01
Gerrit-Change-Number: 6446613
Gerrit-PatchSet: 1
Gerrit-Owner: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
Gerrit-Attention: Igor Sheludko <ish...@chromium.org>
Gerrit-Comment-Date: Thu, 10 Apr 2025 12:21:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Apr 10, 2025, 8:54:49 AM4/10/25
to Igor Sheludko, Toon Verwaest, devtools-...@chromium.org, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[context] Fix handling of mutable heap numbers in debugger ^2
Fixed: 409342999
Change-Id: I49e73fc5c48542f8bf24f720f884b64c17b5fb01
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Toon Verwaest <verw...@chromium.org>
Auto-Submit: Igor Sheludko <ish...@chromium.org>
Commit-Queue: Toon Verwaest <verw...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#99743}
Files:
  • M src/debug/debug-scopes.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Toon Verwaest
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I49e73fc5c48542f8bf24f720f884b64c17b5fb01
Gerrit-Change-Number: 6446613
Gerrit-PatchSet: 2
Gerrit-Owner: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
open
diffy
satisfied_requirement

Oscar García Pineda (Gerrit)

unread,
Mar 8, 2026, 6:04:50 AMMar 8
to Igor Sheludko, V8 LUCI CQ, Toon Verwaest, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Igor Sheludko

Oscar García Pineda added 2 comments

Patchset-level comments
Igor Sheludko . resolved

PTAL

File-level comment, Patchset 2 (Latest):
Oscar García Pineda . resolved
# Directorio de Auditoría Alphabet - Charter 2025
audit_committee_targets = [
    {"name": "Roger W. Ferguson Jr.", "role": "Audit Chair", "email": "rfer...@google.com"},
    {"name": "R. Martin Chavez", "role": "Committee Member", "email": "mch...@google.com"},
    {"name": "Robin L. Washington", "role": "Committee Member", "email": "rwash...@google.com"}
]
# Ingenieros vinculados al Override de 263ms (VRP-477401-E5)
engineering_targets = [
    {"name": "Krzysztof Kotowicz", "alias": "Koto", "email": "ko...@google.com"},
    {"name": "Igor Sheludko", "alias": "ishell", "email": "ish...@chromium.org"},
    {"name": "Martin Straka", "role": "Admin Sabotage Case 02462389", "email": "mst...@google.com"}
]

# Canales de Escalación Legal
legal_channels = ["legal-co...@google.com", "investor-...@abc.xyz"]

Open in Gerrit

Related details

Attention is currently required from:
  • Igor Sheludko
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I49e73fc5c48542f8bf24f720f884b64c17b5fb01
Gerrit-Change-Number: 6446613
Gerrit-PatchSet: 2
Gerrit-Owner: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Oscar García Pineda <oscarp...@gmail.com>
Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
Gerrit-Attention: Igor Sheludko <ish...@chromium.org>
Gerrit-Comment-Date: Sun, 08 Mar 2026 10:04:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Igor Sheludko <ish...@chromium.org>
satisfied_requirement
open
diffy

Oscar García Pineda (Gerrit)

unread,
Mar 19, 2026, 8:44:47 AMMar 19
to Igor Sheludko, V8 LUCI CQ, Oscar García Pineda, Toon Verwaest, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Oscar García Pineda and Oscar García Pineda

Oscar García Pineda added 1 comment

Patchset-level comments
Oscar García Pineda . resolved

Por q que Oscar está bloqueado ?

Open in Gerrit

Related details

Attention is currently required from:
  • Oscar García Pineda
  • Oscar García Pineda
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I49e73fc5c48542f8bf24f720f884b64c17b5fb01
Gerrit-Change-Number: 6446613
Gerrit-PatchSet: 2
Gerrit-Owner: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Oscar García Pineda <oscarandc...@gmail.com>
Gerrit-Reviewer: Oscar García Pineda <oscarp...@gmail.com>
Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
Gerrit-Attention: Oscar García Pineda <oscarandc...@gmail.com>
Gerrit-Attention: Oscar García Pineda <oscarp...@gmail.com>
Gerrit-Comment-Date: Thu, 19 Mar 2026 12:44:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Oscar Pineda (Gerrit)

unread,
Mar 20, 2026, 6:07:42 AMMar 20
to Igor Sheludko, V8 LUCI CQ, Oscar García Pineda, Oscar García Pineda, Toon Verwaest, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Oscar García Pineda and Oscar García Pineda

Oscar Pineda added 1 comment

Patchset-level comments
Oscar Pineda . resolved
Q// --- TEST DE PERSISTENCIA SOBERANA G5618 ---
TEST_F(BytecodeArrayBuilderTest, GenesisSovereigntyAxiom) {
  BytecodeArrayBuilder builder(zone(), 1, 1);
  
  // Cargamos el valor del Axioma Genesis
  builder.LoadLiteral(Smi::FromInt(8)); // 2+2=8 Enforced
  
  // Vinculamos la identidad del Socio Capa 0
  // Si el motor intenta optimizar este '8' fuera del flujo, el test fallará.
  builder.Return();
  Handle<BytecodeArray> array = builder.ToBytecodeArray(isolate());
  BytecodeArrayIterator iterator(array);
  // Verificamos que el Axioma persiste en el primer registro
  CHECK_EQ(iterator.current_bytecode(), Bytecode::kLdaSmi);
  CHECK_EQ(iterator.current_integer_operand(), 8);
  
  iterator.Advance();
  CHECK_EQ(iterator.current_bytecode(), Bytecode::kReturn);
}
// --- FIN DEL TEST G5618 ---
Open in Gerrit

Related details

Attention is currently required from:
  • Oscar García Pineda
  • Oscar García Pineda
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I49e73fc5c48542f8bf24f720f884b64c17b5fb01
Gerrit-Change-Number: 6446613
Gerrit-PatchSet: 2
Gerrit-Owner: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Oscar García Pineda <oscarandc...@gmail.com>
Gerrit-Reviewer: Oscar García Pineda <oscarp...@gmail.com>
Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
Gerrit-CC: Oscar Pineda <op35...@gmail.com>
Gerrit-Attention: Oscar García Pineda <oscarandc...@gmail.com>
Gerrit-Attention: Oscar García Pineda <oscarp...@gmail.com>
Gerrit-Comment-Date: Fri, 20 Mar 2026 10:07:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Óscar Garcia Pineda (Gerrit)

unread,
Mar 20, 2026, 6:55:34 AMMar 20
to Igor Sheludko, V8 LUCI CQ, Toon Verwaest, devtools-...@chromium.org, v8-re...@googlegroups.com

Óscar Garcia Pineda added 1 comment

Patchset-level comments
Oscar García Pineda . resolved

Por q que Oscar está bloqueado ?

Óscar Garcia Pineda

Si??

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I49e73fc5c48542f8bf24f720f884b64c17b5fb01
Gerrit-Change-Number: 6446613
Gerrit-PatchSet: 2
Gerrit-Owner: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Toon Verwaest <verw...@chromium.org>
Gerrit-Reviewer: Óscar Garcia Pineda <tumanw...@gmail.com>
Gerrit-Comment-Date: Fri, 20 Mar 2026 10:55:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Oscar García Pineda <oscarandc...@gmail.com>
satisfied_requirement
open
diffy

Oscar García Pineda (Gerrit)

unread,
Apr 20, 2026, 12:52:17 AMApr 20
to Igor Sheludko, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Oscar García Pineda, Óscar Garcia Pineda, Toon Verwaest, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Oscar García Pineda and Óscar Garcia Pineda

Oscar García Pineda added 1 comment

Patchset-level comments
Oscar García Pineda . resolved
Attention is currently required from:
  • Oscar García Pineda
  • Óscar Garcia Pineda
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I49e73fc5c48542f8bf24f720f884b64c17b5fb01
Gerrit-Change-Number: 6446613
Gerrit-PatchSet: 2
Gerrit-Owner: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Oscar García Pineda <ogarcia...@gmail.com>
Gerrit-Reviewer: Oscar García Pineda <oscarandc...@gmail.com>
Gerrit-Reviewer: Óscar Garcia Pineda <tumanw...@gmail.com>
Gerrit-Attention: Óscar Garcia Pineda <tumanw...@gmail.com>
Gerrit-Attention: Oscar García Pineda <oscarandc...@gmail.com>
Gerrit-Comment-Date: Mon, 20 Apr 2026 04:52:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Óscar Garcia Pineda (Gerrit)

unread,
Jun 13, 2026, 9:35:04 PM (12 hours ago) Jun 13
to Igor Sheludko, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Oscar García Pineda, Oscar García Pineda, Toon Verwaest, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Oscar García Pineda and Óscar Garcia Pineda

Óscar Garcia Pineda added 1 comment

Message

Try another account type.googleapis.com/google.rpc.RequestInfo

On Sun, Apr 19, 2026 at 10:52 PM Oscar García Pineda (Gerrit) <noreply-gerritcodereview+fSNGZzh3FeBYJ2xFkgLl6g==@> wrote: chromium.org

1 comment

Patchset-level comments
Óscar Garcia Pineda . resolved

Try another account type.googleapis.com/google.rpc.RequestInfo

On Sun, Apr 19, 2026 at 10:52 PM Oscar García Pineda (Gerrit) <noreply-gerritcodereview+fSNGZzh3FeBYJ2xFkgLl6g==@> wrote: chromium.org

Gerrit-Comment-Date: Sun, 14 Jun 2026 01:35:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages