Delete remaining obsolete 3PCD-related enum values [chromium/src : main]

0 views
Skip to first unread message

Fiona Macintosh (Gerrit)

unread,
Apr 10, 2026, 1:02:57 PM (7 days ago) Apr 10
to chromium...@chromium.org, devtools...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, dullweb...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, omnibox-...@chromium.org

Fiona Macintosh voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id9f3ac6fc20334ade63e62bb01d823396ea30a01
Gerrit-Change-Number: 7749186
Gerrit-PatchSet: 1
Gerrit-Owner: Fiona Macintosh <fmaci...@google.com>
Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
Gerrit-Comment-Date: Fri, 10 Apr 2026 17:02:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Fiona Macintosh (Gerrit)

unread,
Apr 13, 2026, 12:17:21 PM (4 days ago) Apr 13
to Christian Dullweber, Arthur Sonzogni, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, dullweb...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, omnibox-...@chromium.org
Attention needed from Arthur Sonzogni and Christian Dullweber

Fiona Macintosh voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Arthur Sonzogni
  • Christian Dullweber
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id9f3ac6fc20334ade63e62bb01d823396ea30a01
Gerrit-Change-Number: 7749186
Gerrit-PatchSet: 2
Gerrit-Owner: Fiona Macintosh <fmaci...@google.com>
Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Christian Dullweber <dull...@chromium.org>
Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
Gerrit-Attention: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Attention: Christian Dullweber <dull...@chromium.org>
Gerrit-Comment-Date: Mon, 13 Apr 2026 16:17:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Arthur Sonzogni (Gerrit)

unread,
Apr 14, 2026, 4:08:43 AM (3 days ago) Apr 14
to Fiona Macintosh, Maks Orlovich, Judith Hemp, Christian Dullweber, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, dullweb...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, omnibox-...@chromium.org
Attention needed from Christian Dullweber, Fiona Macintosh, Judith Hemp and Maks Orlovich

Arthur Sonzogni voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Christian Dullweber
  • Fiona Macintosh
  • Judith Hemp
  • Maks Orlovich
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id9f3ac6fc20334ade63e62bb01d823396ea30a01
    Gerrit-Change-Number: 7749186
    Gerrit-PatchSet: 2
    Gerrit-Owner: Fiona Macintosh <fmaci...@google.com>
    Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Reviewer: Christian Dullweber <dull...@chromium.org>
    Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
    Gerrit-Reviewer: Judith Hemp <hempj...@google.com>
    Gerrit-Reviewer: Maks Orlovich <morl...@chromium.org>
    Gerrit-Attention: Fiona Macintosh <fmaci...@google.com>
    Gerrit-Attention: Judith Hemp <hempj...@google.com>
    Gerrit-Attention: Maks Orlovich <morl...@chromium.org>
    Gerrit-Attention: Christian Dullweber <dull...@chromium.org>
    Gerrit-Comment-Date: Tue, 14 Apr 2026 08:08:31 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Christian Dullweber (Gerrit)

    unread,
    Apr 14, 2026, 4:55:47 AM (3 days ago) Apr 14
    to Fiona Macintosh, Arthur Sonzogni, Maks Orlovich, Judith Hemp, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, dullweb...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, omnibox-...@chromium.org
    Attention needed from Fiona Macintosh, Judith Hemp and Maks Orlovich

    Christian Dullweber voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    Gerrit-Comment-Date: Tue, 14 Apr 2026 08:55:35 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Maks Orlovich (Gerrit)

    unread,
    Apr 14, 2026, 9:30:27 AM (3 days ago) Apr 14
    to Fiona Macintosh, Christian Dullweber, Arthur Sonzogni, Judith Hemp, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, dullweb...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, omnibox-...@chromium.org
    Attention needed from Fiona Macintosh and Judith Hemp

    Maks Orlovich voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Fiona Macintosh
    • Judith Hemp
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id9f3ac6fc20334ade63e62bb01d823396ea30a01
    Gerrit-Change-Number: 7749186
    Gerrit-PatchSet: 2
    Gerrit-Owner: Fiona Macintosh <fmaci...@google.com>
    Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Reviewer: Christian Dullweber <dull...@chromium.org>
    Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
    Gerrit-Reviewer: Judith Hemp <hempj...@google.com>
    Gerrit-Reviewer: Maks Orlovich <morl...@chromium.org>
    Gerrit-Attention: Fiona Macintosh <fmaci...@google.com>
    Gerrit-Attention: Judith Hemp <hempj...@google.com>
    Gerrit-Comment-Date: Tue, 14 Apr 2026 13:30:14 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Judith Hemp (Gerrit)

    unread,
    Apr 15, 2026, 3:44:47 AM (2 days ago) Apr 15
    to Fiona Macintosh, Maks Orlovich, Christian Dullweber, Arthur Sonzogni, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, dullweb...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, omnibox-...@chromium.org
    Attention needed from Fiona Macintosh

    Judith Hemp voted

    Code-Review+1
    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Fiona Macintosh
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id9f3ac6fc20334ade63e62bb01d823396ea30a01
    Gerrit-Change-Number: 7749186
    Gerrit-PatchSet: 2
    Gerrit-Owner: Fiona Macintosh <fmaci...@google.com>
    Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Reviewer: Christian Dullweber <dull...@chromium.org>
    Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
    Gerrit-Reviewer: Judith Hemp <hempj...@google.com>
    Gerrit-Reviewer: Maks Orlovich <morl...@chromium.org>
    Gerrit-Attention: Fiona Macintosh <fmaci...@google.com>
    Gerrit-Comment-Date: Wed, 15 Apr 2026 07:44:26 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    chromium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

    unread,
    Apr 15, 2026, 4:49:58 AM (2 days ago) Apr 15
    to Fiona Macintosh, Judith Hemp, Maks Orlovich, Christian Dullweber, Arthur Sonzogni, chromium...@chromium.org, devtools...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, dullweb...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, omnibox-...@chromium.org

    chromiu...@luci-project-accounts.iam.gserviceaccount.com submitted the change

    Change information

    Commit message:
    Delete remaining obsolete 3PCD-related enum values

    Removes k3PCDMetadata, kTpcdGrant, kEnforcedByTpcdGrant
    Change-Id: Id9f3ac6fc20334ade63e62bb01d823396ea30a01
    Reviewed-by: Arthur Sonzogni <arthurs...@chromium.org>
    Commit-Queue: Judith Hemp <hempj...@google.com>
    Reviewed-by: Judith Hemp <hempj...@google.com>
    Auto-Submit: Fiona Macintosh <fmaci...@google.com>
    Reviewed-by: Maks Orlovich <morl...@chromium.org>
    Reviewed-by: Christian Dullweber <dull...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1615003}
    Files:
    • M chrome/browser/ui/cookie_controls/cookie_controls_controller_unittest.cc
    • M chrome/browser/ui/views/location_bar/cookie_controls/cookie_controls_bubble_view_controller.cc
    • M components/content_settings/browser/ui/cookie_controls_controller.cc
    • M components/content_settings/browser/ui/cookie_controls_util.cc
    • M components/content_settings/core/common/content_settings.h
    • M components/content_settings/core/common/cookie_controls_enforcement.h
    • M components/permissions/permission_uma_util.cc
    • M content/browser/devtools/devtools_instrumentation.cc
    • M content/browser/devtools/protocol/network_handler.cc
    • M content/browser/renderer_host/cookie_utils.cc
    • M net/cookies/cookie_inclusion_status.cc
    • M net/cookies/cookie_inclusion_status.h
    • M net/cookies/cookie_inclusion_status_unittest.cc
    • M net/cookies/cookie_util.h
    • M services/network/public/cpp/cookie_manager_shared_mojom_traits.cc
    • M services/network/public/cpp/cookie_manager_shared_mojom_traits_unittest.cc
    • M services/network/public/mojom/cookie_manager.mojom
    Change size: M
    Delta: 17 files changed, 12 insertions(+), 49 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Christian Dullweber, +1 by Judith Hemp, +1 by Maks Orlovich, +1 by Arthur Sonzogni
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id9f3ac6fc20334ade63e62bb01d823396ea30a01
    Gerrit-Change-Number: 7749186
    Gerrit-PatchSet: 3
    Gerrit-Owner: Fiona Macintosh <fmaci...@google.com>
    Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Reviewer: Christian Dullweber <dull...@chromium.org>
    Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>
    Gerrit-Reviewer: Judith Hemp <hempj...@google.com>
    Gerrit-Reviewer: Maks Orlovich <morl...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages