Bookmark shortcut to reval topchrome in immersive fullscreen on CrOS [chromium/src : main]
0 views
Skip to first unread message
Mitsuru Oshima (Gerrit)
Apr 13, 2026, 2:47:49 PM (4 days ago) Apr 13
to android-bu...@system.gserviceaccount.com, Dana Fried, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, chrome-intelligence-te...@google.com, devtools...@chromium.org, browser-comp...@chromium.org, penghuan...@chromium.org, cblume...@chromium.org, chrome-intell...@chromium.org, oshima...@chromium.org
Attention needed from Dana Fried
Mitsuru Oshima voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Dana Fried
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mitsuru Oshima (Gerrit)
Apr 13, 2026, 3:20:24 PM (4 days ago) Apr 13
to android-bu...@system.gserviceaccount.com, Dana Fried, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, chrome-intelligence-te...@google.com, devtools...@chromium.org, browser-comp...@chromium.org, penghuan...@chromium.org, cblume...@chromium.org, chrome-intell...@chromium.org, oshima...@chromium.org
Attention needed from Dana Fried
Mitsuru Oshima voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Dana Fried
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mitsuru Oshima (Gerrit)
Apr 13, 2026, 5:28:29 PM (4 days ago) Apr 13
to android-bu...@system.gserviceaccount.com, Dana Fried, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, chrome-intelligence-te...@google.com, devtools...@chromium.org, browser-comp...@chromium.org, penghuan...@chromium.org, cblume...@chromium.org, chrome-intell...@chromium.org, oshima...@chromium.org
Attention needed from Dana Fried
Mitsuru Oshima voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Dana Fried
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mitsuru Oshima (Gerrit)
Apr 13, 2026, 8:10:41 PM (3 days ago) Apr 13
to android-bu...@system.gserviceaccount.com, Dana Fried, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, chrome-intelligence-te...@google.com, devtools...@chromium.org, browser-comp...@chromium.org, penghuan...@chromium.org, cblume...@chromium.org, chrome-intell...@chromium.org, oshima...@chromium.org
Attention needed from Dana Fried
Mitsuru Oshima voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Dana Fried
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mitsuru Oshima (Gerrit)
Apr 14, 2026, 12:45:28 AM (3 days ago) Apr 14
to android-bu...@system.gserviceaccount.com, Dana Fried, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, chrome-intelligence-te...@google.com, devtools...@chromium.org, browser-comp...@chromium.org, penghuan...@chromium.org, cblume...@chromium.org, chrome-intell...@chromium.org, oshima...@chromium.org
Attention needed from Dana Fried
Mitsuru Oshima voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Dana Fried
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mitsuru Oshima (Gerrit)
Apr 14, 2026, 2:03:45 AM (3 days ago) Apr 14
to android-bu...@system.gserviceaccount.com, Dana Fried, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, chrome-intelligence-te...@google.com, devtools...@chromium.org, browser-comp...@chromium.org, penghuan...@chromium.org, cblume...@chromium.org, chrome-intell...@chromium.org, oshima...@chromium.org
Attention needed from Dana Fried
Mitsuru Oshima voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Dana Fried
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mitsuru Oshima (Gerrit)
Apr 14, 2026, 11:34:06 AM (3 days ago) Apr 14
to android-bu...@system.gserviceaccount.com, Dana Fried, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, chrome-intelligence-te...@google.com, devtools...@chromium.org, browser-comp...@chromium.org, penghuan...@chromium.org, cblume...@chromium.org, chrome-intell...@chromium.org, oshima...@chromium.org
Attention needed from Dana Fried
Mitsuru Oshima added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 19 (Latest):
Mitsuru Oshima . resolved
This is ready for review. It was failing on CQ due to field trial, that hides the tab groups button, which was necessary to focus on Bookmark Bar. I explicitly created a bookmark item instead in new patch. PTAL.
Related details
Attention is currently required from:
- Dana Fried
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dana Fried (Gerrit)
Apr 16, 2026, 10:55:27 AM (19 hours ago) Apr 16
to Mitsuru Oshima, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chrome-intelligence-te...@google.com, devtools...@chromium.org, browser-comp...@chromium.org, penghuan...@chromium.org, cblume...@chromium.org, chrome-intell...@chromium.org, oshima...@chromium.org
Attention needed from Mitsuru Oshima
Dana Fried voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dana Fried
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 6:
Dana Fried . resolved
Mitsuru OshimaTests are failing; please resolve this comment when you have them fixed.
Dana FriedLooks like updating to WIP CL doesn't remove attention bit, sorry about that.
I'll ping you once the issues are resolved.
Acknowledged
Related details
Attention is currently required from:
- Mitsuru Oshima
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mitsuru Oshima (Gerrit)
Apr 16, 2026, 11:03:50 AM (19 hours ago) Apr 16
to Dana Fried, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chrome-intelligence-te...@google.com, devtools...@chromium.org, browser-comp...@chromium.org, penghuan...@chromium.org, cblume...@chromium.org, chrome-intell...@chromium.org, oshima...@chromium.org
Attention needed from Dana Fried
Mitsuru Oshima voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mitsuru Oshima
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 20 (Latest):
Mitsuru Oshima . resolved
I had to resolve conflict. Could you +1 again?
Related details
Attention is currently required from:
- Dana Fried
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dana Fried (Gerrit)
Apr 16, 2026, 11:07:58 AM (19 hours ago) Apr 16
to Mitsuru Oshima, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chrome-intelligence-te...@google.com, devtools...@chromium.org, browser-comp...@chromium.org, penghuan...@chromium.org, cblume...@chromium.org, chrome-intell...@chromium.org, oshima...@chromium.org
Attention needed from Mitsuru Oshima
Dana Fried voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Mitsuru Oshima
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mitsuru Oshima (Gerrit)
Apr 16, 2026, 11:08:34 AM (19 hours ago) Apr 16
to Dana Fried, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chrome-intelligence-te...@google.com, devtools...@chromium.org, browser-comp...@chromium.org, penghuan...@chromium.org, cblume...@chromium.org, chrome-intell...@chromium.org, oshima...@chromium.org
Mitsuru Oshima voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mitsuru Oshima
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 16, 2026, 1:05:42 PM (17 hours ago) Apr 16
to Mitsuru Oshima, Dana Fried, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chrome-intelligence-te...@google.com, devtools...@chromium.org, browser-comp...@chromium.org, penghuan...@chromium.org, cblume...@chromium.org, chrome-intell...@chromium.org, oshima...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Bookmark shortcut to reval topchrome in immersive fullscreen on CrOS
This is follow up for crrev.com/c/7224541. The bookmark bar shortcut
was wrong, and wasn't included. (it does passed because
ctrl-d - bookmark current page, does set the focus to omnibox).
1) make bookmark bar visible in immersive fullscreen so that it can
be focused and also trigger the reveal.
2) Added "focus bookmark" shortcut. This requires manually adding
a bookmark item, because "tab groups button" on bookmark bar is
not available due to field trial config.
Bug: 464354169
Test: covered by unittests
Change-Id: Ib174f5e32d9cf9c916fa8b8f4031985b1b2bd2b3
Commit-Queue: Mitsuru Oshima <osh...@chromium.org>
Reviewed-by: Dana Fried <dfr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1615963}
Files:
- M chrome/browser/ui/browser_command_controller.cc
- M chrome/browser/ui/views/frame/browser_frame_view_chromeos_browsertest.cc
- M chrome/browser/ui/views/frame/browser_view.cc
- M chrome/browser/ui/views/frame/browser_view_interactive_uitest.cc
Change size: M
Delta: 4 files changed, 102 insertions(+), 22 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dana Fried
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages