Support running a describe block in DevTools tests [devtools/devtools-frontend : main]
Eric Leese (Gerrit)
Eric Leese voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
- Alex Rudenko
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Alex Rudenko added 1 comment![]( "Open in Gerrit")
I think we on purpose excluded this to avoid this being similar to grep. The test IDs have to match exactly. Would it be possible to instead find all test IDs for a describe block using the script like the one @pfa...@chromium.org created?
Related details
- Eric Leese
- Philip Pfaffe
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eric Leese (Gerrit)
Eric Leese added 1 comment![]( "Open in Gerrit")
I think we on purpose excluded this to avoid this being similar to grep. The test IDs have to match exactly. Would it be possible to instead find all test IDs for a describe block using the script like the one @pfa...@chromium.org created?
That would require considerably more work on the Cider extension side. The design at many layers assumes exactly one test filter. Also it doesn't always detect nested blocks, and there can be things like parameterized tests that we can't parse, so it isn't going to be as reliable.
Related details
- Alex Rudenko
- Philip Pfaffe
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Alex Rudenko added 1 comment![]( "Open in Gerrit")
Eric LeeseI think we on purpose excluded this to avoid this being similar to grep. The test IDs have to match exactly. Would it be possible to instead find all test IDs for a describe block using the script like the one @pfa...@chromium.org created?
That would require considerably more work on the Cider extension side. The design at many layers assumes exactly one test filter. Also it doesn't always detect nested blocks, and there can be things like parameterized tests that we can't parse, so it isn't going to be as reliable.
- Eric Leese
- Philip Pfaffe
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Alex Rudenko voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alex Rudenko
| Code-Review | +1 |
1 comment
Eric LeeseI think we on purpose excluded this to avoid this being similar to grep. The test IDs have to match exactly. Would it be possible to instead find all test IDs for a describe block using the script like the one @pfa...@chromium.org created?
Alex RudenkoThat would require considerably more work on the Cider extension side. The design at many layers assumes exactly one test filter. Also it doesn't always detect nested blocks, and there can be things like parameterized tests that we can't parse, so it isn't going to be as reliable.
cc @pfa...@chromium.org wdyt?
I think since we ensure : is a delimiter it should be fine. I wonder if we should optimize the check in any way but I suspect we do not pass that many test IDs.
Related details
- Eric Leese
- Philip Pfaffe
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Pfaffe (Gerrit)
Philip Pfaffe voted and added 1 comment![]( "Open in Gerrit")
Votes added by Philip Pfaffe
| Code-Review | +1 |
1 comment
const testIds = TestConfig.tests.filter(testId => TEST_ID_REGEX.test(testId));Can we keep the set?
Related details
- Eric Leese
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eric Leese (Gerrit)
Eric Leese voted and added 1 comment![]( "Open in Gerrit")
Votes added by Eric Leese
| Auto-Submit | +1 |
1 comment
const testIds = TestConfig.tests.filter(testId => TEST_ID_REGEX.test(testId));Can we keep the set?
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eric Leese (Gerrit)
Eric Leese voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eric Leese (Gerrit)
Eric Leese voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
devtools-fro...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: test/shared/run-mocha.ts
Insertions: 4, Deletions: 2.
The diff is too large to show. Please review the diff.
```
```
The name of the file: test/unit/mocha-adapter-browser.ts
Insertions: 2, Deletions: 2.
The diff is too large to show. Please review the diff.
```
Change information
Support running a describe block in DevTools tests
In addition to being able to specify a test file or an individual test
case, you can now specify the id of a describe block to run all tests
within it.
- M test/shared/run-mocha.ts
- M test/unit/mocha-adapter-browser.ts
Code-Review: +1 by Alex Rudenko, +1 by Philip Pfaffe
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |