[A11y] Add Home/End keyboard navigation in shortcut list [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Guangyue Xu (Gerrit)
Feb 5, 2026, 7:47:16 PMFeb 5
to Kim-Anh Tran, Nikolay Vitkov, devtools-rev...@chromium.org
Attention needed from Kim-Anh Tran and Nikolay Vitkov
Guangyue Xu added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Guangyue Xu . resolved
Hi Kim and Nikolay, please help review one more A11y fix. Thanks.
Related details
Attention is currently required from:
- Kim-Anh Tran
- Nikolay Vitkov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kim-Anh Tran (Gerrit)
Feb 9, 2026, 3:39:02 AMFeb 9
to Guangyue Xu, Nikolay Vitkov, devtools-rev...@chromium.org
Attention needed from Guangyue Xu and Nikolay Vitkov
Kim-Anh Tran added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File front_end/panels/settings/KeybindsSettingsTab.ts
Line 227, Patchset 2 (Latest):
return typeof item !== 'string';Kim-Anh Tran . unresolved
Is it possible to use the exact type here? I assume you mean `UI.ActionRegistration.ActionCategory`?
Related details
Attention is currently required from:
- Guangyue Xu
- Nikolay Vitkov
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Guangyue Xu (Gerrit)
Feb 9, 2026, 4:43:45 PMFeb 9
to Kim-Anh Tran, Nikolay Vitkov, devtools-rev...@chromium.org
Attention needed from Kim-Anh Tran and Nikolay Vitkov
Guangyue Xu added 1 comment![]( "Open in Gerrit")
File front_end/panels/settings/KeybindsSettingsTab.ts
Line 227, Patchset 2:
return typeof item !== 'string';Kim-Anh Tran . unresolved
Is it possible to use the exact type here? I assume you mean `UI.ActionRegistration.ActionCategory`?
Attention is currently required from:
- Kim-Anh Tran
- Nikolay Vitkov
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kim-Anh Tran (Gerrit)
Feb 10, 2026, 3:16:26 AMFeb 10
to Guangyue Xu, Nikolay Vitkov, devtools-rev...@chromium.org
Attention needed from Guangyue Xu and Nikolay Vitkov
Kim-Anh Tran voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kim-Anh Tran
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Guangyue Xu
- Nikolay Vitkov
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikolay Vitkov (Gerrit)
Feb 10, 2026, 4:34:19 AMFeb 10
to Guangyue Xu, Kim-Anh Tran, devtools-rev...@chromium.org
Attention needed from Guangyue Xu
Nikolay Vitkov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nikolay Vitkov
| Code-Review | +1 |
1 comment
File front_end/panels/settings/KeybindsSettingsTab.ts
Line 227, Patchset 2:
return typeof item !== 'string';Kim-Anh Tran . resolved
Guangyue XuIs it possible to use the exact type here? I assume you mean `UI.ActionRegistration.ActionCategory`?
Replaced `string` with `UI.ActionRegistration.Action`.
Nikolay Vitkov
Done
Related details
Attention is currently required from:
- Guangyue Xu
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikolay Vitkov (Gerrit)
Feb 10, 2026, 4:34:22 AMFeb 10
to Guangyue Xu, Kim-Anh Tran, devtools-rev...@chromium.org
Attention needed from Guangyue Xu
Nikolay Vitkov voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Guangyue Xu
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
Feb 10, 2026, 5:52:39 AMFeb 10
to Guangyue Xu, Nikolay Vitkov, Kim-Anh Tran, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[A11y] Add Home/End keyboard navigation in shortcut list
After the fix:
Press Home key or Fn + left arrow key in Mac to navigate to the
first item of the shortcut list.
Press End key or Fn + right arrow key in Mac to navigate to the
last item of the shortcut list.
Removed keyboard focus for the header items, e.g., "Background
Services", "Console" etc, in the shortcut list.
Bug: 481747256
Change-Id: I928c000c36ef4dec8e0e0dc19b02c473b29fa679
Reviewed-by: Nikolay Vitkov <nvi...@chromium.org>
Commit-Queue: Nikolay Vitkov <nvi...@chromium.org>
Reviewed-by: Kim-Anh Tran <kim...@chromium.org>
Files:
- M front_end/panels/settings/KeybindsSettingsTab.ts
- M front_end/ui/legacy/ListControl.ts
Change size: S
Delta: 2 files changed, 32 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kim-Anh Tran, +1 by Nikolay Vitkov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages