[Lighthouse] Add agentic browsing category [devtools/devtools-frontend : main]
Alex Rudenko (Gerrit)
Alex Rudenko voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alex Rudenko
| Code-Review | +1 |
1 comment
agenticBrowsing: 'Agentic Browsing',```suggestion
agenticBrowsing: 'Agentic browsing',
```
I think per UX writing guidelines it should start with a lowercase letter. Feel free to ignore the suggestion if the title was approved elsewhere with the capital Browsing.
Related details
- Lusa Zhan
- Paul Irish
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lusa Zhan (Gerrit)
Lusa Zhan added 1 comment![]( "Open in Gerrit")
```suggestion
agenticBrowsing: 'Agentic browsing',
```I think per UX writing guidelines it should start with a lowercase letter. Feel free to ignore the suggestion if the title was approved elsewhere with the capital Browsing.
- Alex Rudenko
- Paul Irish
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Irish (Gerrit)
Paul Irish added 1 comment![]( "Open in Gerrit")
if (!config && categoryIDs.includes('agentic-browsing')) {something is weird with this.
so we have 'self.createConfig' which is exposed manually and gets used here in the worker: https://source.chromium.org/chromium/chromium/src/+/main:third_party/devtools-frontend/src/front_end/entrypoints/lighthouse_worker/LighthouseWorkerService.ts;l=79?q=f:lighthouse%20config%20-f:locales&ss=chromium%2Fchromium%2Fsrc:third_party%2Fdevtools-frontend%2Fsrc%2Ffront_end%2F
with that.. we should just need to pass the categoryid here from protocolservice over to workerservice and then everything _should_ work.
if agenticbrowsing still requires custom config... then.. that complicates this scenario. (but even if so.. i'm sure there's another solution than defining the category again outside of the LH codebase)
Related details
- Alex Rudenko
- Lusa Zhan
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |