Update privacy disclaimer text for code completion [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Samiya Caur (Gerrit)

unread,
Dec 29, 2025, 12:59:03 PM (yesterday) Dec 29
to Ergün Erdoğmuş, devtools-rev...@chromium.org
Attention needed from Ergün Erdoğmuş

Samiya Caur voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ergün Erdoğmuş
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I7130e964cc6c376a749814337e018c20f59e3b92
Gerrit-Change-Number: 7319953
Gerrit-PatchSet: 1
Gerrit-Owner: Samiya Caur <sam...@chromium.org>
Gerrit-Reviewer: Ergün Erdoğmuş <erg...@chromium.org>
Gerrit-Reviewer: Samiya Caur <sam...@chromium.org>
Gerrit-Attention: Ergün Erdoğmuş <erg...@chromium.org>
Gerrit-Comment-Date: Mon, 29 Dec 2025 17:58:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Ergün Erdoğmuş (Gerrit)

unread,
7:09 AM (16 hours ago) 7:09 AM
to Samiya Caur, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Samiya Caur

Ergün Erdoğmuş added 1 comment

File front_end/panels/common/AiCodeCompletionDisclaimer.ts
Line 82, Patchset 1 (Latest): panel?: AiCodeCompletion.AiCodeCompletion.ContextFlavor;
Ergün Erdoğmuş . unresolved

Let's not use `ContextFlavor` here for this too. We can define a `variant` or a separate enum in the `AiCodeCompletionDisclaimer` for selecting the text and use that `variant` in the respective places instead of using `ContextFlavor`.

The `ContextFlavor` is introduced initially to be able to modify the behavior of the `AiCodeCompletion` model calls with adding file context, and re-using it for this cause does not seem correct to me as now this presentational component depends on the model itself just for referencing the `ContextFlavor` enum.

Open in Gerrit

Related details

Attention is currently required from:
  • Samiya Caur
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: devtools/devtools-frontend
    Gerrit-Branch: main
    Gerrit-Change-Id: I7130e964cc6c376a749814337e018c20f59e3b92
    Gerrit-Change-Number: 7319953
    Gerrit-PatchSet: 1
    Gerrit-Owner: Samiya Caur <sam...@chromium.org>
    Gerrit-Reviewer: Ergün Erdoğmuş <erg...@chromium.org>
    Gerrit-Reviewer: Samiya Caur <sam...@chromium.org>
    Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Attention: Samiya Caur <sam...@chromium.org>
    Gerrit-Comment-Date: Tue, 30 Dec 2025 12:09:46 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Samiya Caur (Gerrit)

    unread,
    7:43 AM (16 hours ago) 7:43 AM
    to Devtools-frontend LUCI CQ, Ergün Erdoğmuş, devtools-rev...@chromium.org
    Attention needed from Ergün Erdoğmuş

    Samiya Caur voted and added 1 comment

    Votes added by Samiya Caur

    Auto-Submit+1

    1 comment

    File front_end/panels/common/AiCodeCompletionDisclaimer.ts
    Line 82, Patchset 1: panel?: AiCodeCompletion.AiCodeCompletion.ContextFlavor;
    Ergün Erdoğmuş . resolved

    Let's not use `ContextFlavor` here for this too. We can define a `variant` or a separate enum in the `AiCodeCompletionDisclaimer` for selecting the text and use that `variant` in the respective places instead of using `ContextFlavor`.

    The `ContextFlavor` is introduced initially to be able to modify the behavior of the `AiCodeCompletion` model calls with adding file context, and re-using it for this cause does not seem correct to me as now this presentational component depends on the model itself just for referencing the `ContextFlavor` enum.

    Samiya Caur

    As discussed offline, added TODO and linked to the bug - b/472268298

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ergün Erdoğmuş
    Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: devtools/devtools-frontend
      Gerrit-Branch: main
      Gerrit-Change-Id: I7130e964cc6c376a749814337e018c20f59e3b92
      Gerrit-Change-Number: 7319953
      Gerrit-PatchSet: 2
      Gerrit-Owner: Samiya Caur <sam...@chromium.org>
      Gerrit-Reviewer: Ergün Erdoğmuş <erg...@chromium.org>
      Gerrit-Reviewer: Samiya Caur <sam...@chromium.org>
      Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Attention: Ergün Erdoğmuş <erg...@chromium.org>
      Gerrit-Comment-Date: Tue, 30 Dec 2025 12:43:10 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Ergün Erdoğmuş <erg...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Ergün Erdoğmuş (Gerrit)

      unread,
      8:34 AM (15 hours ago) 8:34 AM
      to Samiya Caur, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
      Attention needed from Samiya Caur

      Ergün Erdoğmuş voted

      Code-Review+1
      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Samiya Caur
      Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: devtools/devtools-frontend
      Gerrit-Branch: main
      Gerrit-Change-Id: I7130e964cc6c376a749814337e018c20f59e3b92
      Gerrit-Change-Number: 7319953
      Gerrit-PatchSet: 2
      Gerrit-Owner: Samiya Caur <sam...@chromium.org>
      Gerrit-Reviewer: Ergün Erdoğmuş <erg...@chromium.org>
      Gerrit-Reviewer: Samiya Caur <sam...@chromium.org>
      Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Attention: Samiya Caur <sam...@chromium.org>
      Gerrit-Comment-Date: Tue, 30 Dec 2025 13:34:53 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Devtools-frontend LUCI CQ (Gerrit)

      unread,
      9:20 AM (14 hours ago) 9:20 AM
      to Samiya Caur, Ergün Erdoğmuş, devtools-rev...@chromium.org

      Devtools-frontend LUCI CQ submitted the change

      Change information

      Commit message:
      Update privacy disclaimer text for code completion

      Currently the same privacy disclaimer text is shown in Console & Sources panel
      Bug: 471185310
      Change-Id: I7130e964cc6c376a749814337e018c20f59e3b92
      Reviewed-by: Ergün Erdoğmuş <erg...@chromium.org>
      Commit-Queue: Ergün Erdoğmuş <erg...@chromium.org>
      Auto-Submit: Samiya Caur <sam...@chromium.org>
      Commit-Queue: Samiya Caur <sam...@chromium.org>
      Files:
      • M front_end/panels/common/AiCodeCompletionDisclaimer.ts
      • M front_end/panels/common/AiCodeCompletionSummaryToolbar.test.ts
      • M front_end/panels/common/AiCodeCompletionSummaryToolbar.ts
      • M front_end/panels/console/ConsoleView.ts
      • M front_end/panels/sources/AiCodeCompletionPlugin.ts
      Change size: M
      Delta: 5 files changed, 57 insertions(+), 9 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Ergün Erdoğmuş
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: devtools/devtools-frontend
      Gerrit-Branch: main
      Gerrit-Change-Id: I7130e964cc6c376a749814337e018c20f59e3b92
      Gerrit-Change-Number: 7319953
      Gerrit-PatchSet: 3
      Gerrit-Owner: Samiya Caur <sam...@chromium.org>
      Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages