[node] Add regression test for node_app breakage [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Simon Zünd (Gerrit)
Nov 4, 2025, 3:18:45 AM (2 days ago) Nov 4
to Devtools-frontend LUCI CQ, Benedikt Meurer, devtools-rev...@chromium.org
Attention needed from Benedikt Meurer
Simon Zünd voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Benedikt Meurer
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Nov 4, 2025, 4:11:16 AM (2 days ago) Nov 4
to Simon Zünd, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Simon Zünd
Alex Rudenko voted![]( "Open in Gerrit")
Attention is currently required from:
- Simon Zünd
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Simon Zünd (Gerrit)
Nov 4, 2025, 4:20:59 AM (2 days ago) Nov 4
to Alex Rudenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Alex Rudenko
Simon Zünd voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Alex Rudenko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
Nov 4, 2025, 4:22:36 AM (2 days ago) Nov 4
to Simon Zünd, Alex Rudenko, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[node] Add regression test for node_app breakage
This CL adds a regression unit test for crbug.com/457549946.
The CL has to restructure `node_app` a bit: `node_app.ts` runs MainImpl
as a side-effect, which essentially boots up all of DevTools.
To prevent that, this Cl splits the two files into a separate bundle
and keeps the entrypoint separate. This way, we can unit test the
two files without booting up DevTools as a side-effect.
R=bme...@chromium.org
Bypass-Check-License: Moved files.
Fixed: 457549946
Change-Id: Ib107b99a8531372f608bc1ad692d5f4786495fba
Commit-Queue: Simon Zünd <szu...@chromium.org>
Auto-Submit: Simon Zünd <szu...@chromium.org>
Reviewed-by: Alex Rudenko <alexr...@chromium.org>
Files:
- M config/gni/devtools_grd_files.gni
- M front_end/BUILD.gn
- M front_end/entrypoints/node_app/BUILD.gn
- A front_end/entrypoints/node_app/app/BUILD.gn
- R front_end/entrypoints/node_app/app/NodeConnectionsPanel.ts
- A front_end/entrypoints/node_app/app/NodeMain.test.ts
- R front_end/entrypoints/node_app/app/NodeMain.ts
- A front_end/entrypoints/node_app/app/app.ts
- R front_end/entrypoints/node_app/app/nodeConnectionsPanel.css
- M front_end/entrypoints/node_app/node_app.ts
Change size: M
Delta: 10 files changed, 130 insertions(+), 50 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alex Rudenko
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages