Add visual logging contexts to Layers panel for comment anchoring [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Alex Rudenko (Gerrit)
Aug 18, 2026, 3:43:36 AM (yesterday) Aug 18
to devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, devtools-rev...@chromium.org
Alex Rudenko voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Aug 18, 2026, 3:57:50 AM (yesterday) Aug 18
to devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, devtools-rev...@chromium.org
Alex Rudenko added 2 comments![]( "Open in Gerrit")
File front_end/panels/layer_viewer/LayerDetailsView.ts
Line 224, Patchset 2 (Latest):
data-backend-node-id=${domNode ? domNode.id : nothing}Alex Rudenko . unresolved
`domNode.id` returns the `NodeId`. Since the attribute is named `data-backend-node-id`, you likely want to use `domNode.backendNodeId()` instead.
File front_end/panels/layer_viewer/LayerTreeOutline.ts
Line 83, Patchset 2 (Latest):
data-backend-node-id=${domNode ? domNode.id : nothing}Alex Rudenko . unresolved
`domNode.id` returns the `NodeId`. You probably want to use `domNode.backendNodeId()` here to match the attribute name.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Aug 18, 2026, 12:12:21 PM (22 hours ago) Aug 18
to devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, devtools-rev...@chromium.org
Alex Rudenko added 2 comments![]( "Open in Gerrit")
File front_end/panels/layer_viewer/LayerDetailsView.ts
`domNode.id` returns the `NodeId`. Since the attribute is named `data-backend-node-id`, you likely want to use `domNode.backendNodeId()` instead.
Alex Rudenko
Done
File front_end/panels/layer_viewer/LayerTreeOutline.ts
`domNode.id` returns the `NodeId`. You probably want to use `domNode.backendNodeId()` here to match the attribute name.
Alex Rudenko
Done
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
8:22 AM (1 hour ago) 8:22 AM
to Yulun Zeng, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Yulun Zeng
Alex Rudenko voted Commit-Queue+1![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yulun Zeng (Gerrit)
9:03 AM (1 hour ago) 9:03 AM
to Alex Rudenko, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Alex Rudenko
Yulun Zeng voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alex Rudenko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
9:04 AM (1 hour ago) 9:04 AM
to Yulun Zeng, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, devtools-rev...@chromium.org
Alex Rudenko voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
9:07 AM (1 hour ago) 9:07 AM
to Alex Rudenko, Yulun Zeng, android-bu...@system.gserviceaccount.com, devtools-rev...@chromium.org
devtools-fro...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add visual logging contexts to Layers panel for comment anchoring
Add jslog contexts and data-backend-node-id to LayerTreeOutline
('layer-item') and LayerDetailsView ('layer-details' section and
'detail-row' rows) to support CommentAnchorResolver.
Bug: 542928776
Change-Id: I2cbb05c985137d30973028b8d769429da48d2b79
TAG=agy
CONV=fdf66637-1abc-41a3-afd9-c4f8272a49c8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/8257559
Reviewed-by: Yulun Zeng <yul...@chromium.org>
Commit-Queue: Alex Rudenko <alexr...@chromium.org>
Files:
- M front_end/panels/layer_viewer/LayerDetailsView.ts
- M front_end/panels/layer_viewer/LayerTreeOutline.ts
- M front_end/ui/visual_logging/KnownContextValues.ts
Change size: S
Delta: 3 files changed, 15 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yulun Zeng
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages