Implement prerender-until-script to full prerender upgrade [chromium/src : main]

0 views
Skip to first unread message

Viktoria Zlatinova (Gerrit)

unread,
Mar 31, 2026, 5:52:04 PMMar 31
to Chromium LUCI CQ, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, prerendering-reviews, alexmo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, tburkar...@chromium.org
Attention needed from Viktoria Zlatinova

Message from Viktoria Zlatinova

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • Viktoria Zlatinova
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ide4dd677dd4d121d90355d76c549c6a11358ea81
Gerrit-Change-Number: 7712783
Gerrit-PatchSet: 2
Gerrit-Owner: Viktoria Zlatinova <vizl...@microsoft.com>
Gerrit-Reviewer: Viktoria Zlatinova <vizl...@microsoft.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Viktoria Zlatinova <vizl...@microsoft.com>
Gerrit-Comment-Date: Tue, 31 Mar 2026 21:51:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Viktoria Zlatinova (Gerrit)

unread,
Apr 13, 2026, 12:54:41 PM (6 days ago) Apr 13
to Lingqi Chi, Hiroki Nakagawa, chromiu...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, prerendering-reviews, alexmo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, tburkar...@chromium.org
Attention needed from Hiroki Nakagawa and Lingqi Chi

Viktoria Zlatinova voted and added 1 comment

Votes added by Viktoria Zlatinova

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 3:
Viktoria Zlatinova . unresolved

PTAL when you have a chance, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Hiroki Nakagawa
  • Lingqi Chi
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ide4dd677dd4d121d90355d76c549c6a11358ea81
    Gerrit-Change-Number: 7712783
    Gerrit-PatchSet: 6
    Gerrit-Owner: Viktoria Zlatinova <vizl...@microsoft.com>
    Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-Reviewer: Lingqi Chi <lin...@chromium.org>
    Gerrit-Reviewer: Viktoria Zlatinova <vizl...@microsoft.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Lingqi Chi <lin...@chromium.org>
    Gerrit-Attention: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-Comment-Date: Mon, 13 Apr 2026 16:54:28 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Viktoria Zlatinova (Gerrit)

    unread,
    Apr 13, 2026, 2:33:06 PM (6 days ago) Apr 13
    to Lingqi Chi, Hiroki Nakagawa, chromiu...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, prerendering-reviews, alexmo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, tburkar...@chromium.org
    Attention needed from Hiroki Nakagawa and Lingqi Chi

    Viktoria Zlatinova added 1 comment

    Patchset-level comments
    File-level comment, Patchset 3:
    Viktoria Zlatinova . resolved

    PTAL when you have a chance, thanks!

    Viktoria Zlatinova

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Hiroki Nakagawa
    • Lingqi Chi
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ide4dd677dd4d121d90355d76c549c6a11358ea81
      Gerrit-Change-Number: 7712783
      Gerrit-PatchSet: 7
      Gerrit-Owner: Viktoria Zlatinova <vizl...@microsoft.com>
      Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
      Gerrit-Reviewer: Lingqi Chi <lin...@chromium.org>
      Gerrit-Reviewer: Viktoria Zlatinova <vizl...@microsoft.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
      Gerrit-Attention: Lingqi Chi <lin...@chromium.org>
      Gerrit-Attention: Hiroki Nakagawa <nhi...@chromium.org>
      Gerrit-Comment-Date: Mon, 13 Apr 2026 18:32:57 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Viktoria Zlatinova <vizl...@microsoft.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Hiroki Nakagawa (Gerrit)

      unread,
      Apr 17, 2026, 10:56:55 AM (2 days ago) Apr 17
      to Viktoria Zlatinova, Lingqi Chi, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, prerendering-reviews, alexmo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, tburkar...@chromium.org
      Attention needed from Lingqi Chi and Viktoria Zlatinova

      Hiroki Nakagawa voted and added 10 comments

      Votes added by Hiroki Nakagawa

      Code-Review+1

      10 comments

      Patchset-level comments
      File-level comment, Patchset 8 (Latest):
      Hiroki Nakagawa . resolved

      Sorry for the late review. Overall looks very good to me. I'll defer to lingqi@ for more detailed reviews.

      (sorry for nitpicky comments)

      File content/browser/preloading/prerender/prerender_handle_impl.cc
      Line 146, Patchset 8 (Latest): // The PUS host was upgraded to full prerender.
      Hiroki Nakagawa . unresolved

      I'd like to avoid using "PUS" in codebase without explicit clarification. Can we change this to "prerender-until-script host"?

      File content/browser/preloading/prerender/prerender_host.h
      Line 576, Patchset 8 (Latest): // speculation_action() without modifying the const attributes_.
      Hiroki Nakagawa . unresolved

      \`speculation_action()\` and \`attributes_\`

      Line 575, Patchset 8 (Latest): // This changes the behavior of should_pause_javascript_execution() and
      Hiroki Nakagawa . unresolved

      \`should_pause_javascript_execution()\` (adding back-quotes for code search)

      Line 574, Patchset 8 (Latest): // Set to true when this PUS host has been upgraded to a full prerender.
      Hiroki Nakagawa . unresolved

      Ditto: prerender-until-script

      File content/browser/preloading/prerender/prerender_host.cc
      Line 1976, Patchset 8 (Latest): // crashed or the frame was destroyed, keep the host in PUS state (JS
      Hiroki Nakagawa . unresolved

      prerender-until-script

      Line 1987, Patchset 8 (Latest): // Notify DevTools that the PUS attempt has been upgraded.
      Hiroki Nakagawa . unresolved

      prerender-until-script

      File content/browser/preloading/prerenderer_impl.cc
      Line 173, Patchset 8 (Latest): // the existing PUS host will be upgraded to a full prerender.
      Hiroki Nakagawa . unresolved

      prerender-until-script

      Line 282, Patchset 8 (Latest): // same URL and the PUS host was started in an earlier update.
      Hiroki Nakagawa . unresolved

      prerender-until-script

      Line 410, Patchset 8 (Latest): // Check if we should upgrade an existing PUS host to full prerender.
      Hiroki Nakagawa . unresolved

      existing prerender-until-script (PUS) host

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Lingqi Chi
      • Viktoria Zlatinova
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ide4dd677dd4d121d90355d76c549c6a11358ea81
        Gerrit-Change-Number: 7712783
        Gerrit-PatchSet: 8
        Gerrit-Owner: Viktoria Zlatinova <vizl...@microsoft.com>
        Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
        Gerrit-Reviewer: Lingqi Chi <lin...@chromium.org>
        Gerrit-Reviewer: Viktoria Zlatinova <vizl...@microsoft.com>
        Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
        Gerrit-Attention: Viktoria Zlatinova <vizl...@microsoft.com>
        Gerrit-Attention: Lingqi Chi <lin...@chromium.org>
        Gerrit-Comment-Date: Fri, 17 Apr 2026 14:56:16 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Hiroki Nakagawa (Gerrit)

        unread,
        Apr 17, 2026, 11:05:24 AM (2 days ago) Apr 17
        to Viktoria Zlatinova, Lingqi Chi, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, prerendering-reviews, alexmo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, tburkar...@chromium.org
        Attention needed from Lingqi Chi and Viktoria Zlatinova

        Hiroki Nakagawa added 2 comments

        Commit Message
        Line 7, Patchset 8 (Latest):Implement prerender-until-script to full prerender upgrade
        Hiroki Nakagawa . unresolved

        In a follow-up CL, can you add WPTs?

        File content/browser/preloading/prerender/devtools_prerender_attempt.cc
        Line 47, Patchset 8 (Latest): PrerenderFinalStatus::kUpgradedToFullPrerender,
        Hiroki Nakagawa . unresolved

        Will the DevTools backend check the final status to determine if this is PUS upgrade and then update the UI?

        I'm slightly concerned about this pattern, because actually `kUpgradedToFullPrerender` is not a final status, but it's just used for notifying the DevTools of the upgrade. Instead of that, I wonder if we should add a separate parameter.

        To isolate the discussion about the DevTools protocol from this CL, can we move changes for DevTools to a follow-up CL, and leave TODO comments in this CL?

        Gerrit-Comment-Date: Fri, 17 Apr 2026 15:04:47 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages