[iOS tracing] Move Perfetto data source names from mojom to C++ header [chromium/src : main]
0 views
Skip to first unread message
Justin Novosad (Gerrit)
Apr 10, 2026, 5:42:22 PM (7 days ago) Apr 10
to Dave Tapuska, Hidehiko Abe, Etienne Pierre-Doray, Chromium IPC Reviews, android-bu...@system.gserviceaccount.com, Justin Cohen, Chromium LUCI CQ, chromium...@chromium.org, arc-review...@google.com, yhanada+...@chromium.org, hidehik...@chromium.org, devtools...@chromium.org, chrome-gr...@chromium.org, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Dave Tapuska, Etienne Pierre-Doray, Hidehiko Abe and Justin Novosad
Justin Novosad voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Dave Tapuska
- Etienne Pierre-Doray
- Hidehiko Abe
- Justin Novosad
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hidehiko Abe (Gerrit)
Apr 12, 2026, 10:49:05 PM (4 days ago) Apr 12
to Justin Novosad, Justin Cohen, Dave Tapuska, Etienne Pierre-Doray, Chromium IPC Reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, arc-review...@google.com, yhanada+...@chromium.org, hidehik...@chromium.org, devtools...@chromium.org, chrome-gr...@chromium.org, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Dave Tapuska, Etienne Pierre-Doray, Justin Cohen and Justin Novosad
Hidehiko Abe added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 13 (Latest):
Hidehiko Abe . resolved
the direction looking good, but could you fix bot failures?
Related details
Attention is currently required from:
- Dave Tapuska
- Etienne Pierre-Doray
- Justin Cohen
- Justin Novosad
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Apr 13, 2026, 10:58:00 AM (4 days ago) Apr 13
to Justin Novosad, Justin Cohen, Dave Tapuska, Hidehiko Abe, Chromium IPC Reviews, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, yhanada+...@chromium.org, hidehik...@chromium.org, devtools...@chromium.org, chrome-gr...@chromium.org, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Dave Tapuska, Justin Cohen and Justin Novosad
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Dave Tapuska
- Justin Cohen
- Justin Novosad
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Mason (Gerrit)
Apr 13, 2026, 5:49:02 PM (4 days ago) Apr 13
to Justin Novosad, Justin Cohen, Etienne Pierre-Doray, Dave Tapuska, Hidehiko Abe, Chromium IPC Reviews, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, yhanada+...@chromium.org, hidehik...@chromium.org, devtools...@chromium.org, chrome-gr...@chromium.org, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Dave Tapuska, Hidehiko Abe, Justin Cohen and Justin Novosad
Joe Mason voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Dave Tapuska
- Hidehiko Abe
- Justin Cohen
- Justin Novosad
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dave Tapuska (Gerrit)
Apr 13, 2026, 7:06:56 PM (3 days ago) Apr 13
to Justin Novosad, Justin Cohen, Etienne Pierre-Doray, Hidehiko Abe, Chromium IPC Reviews, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, yhanada+...@chromium.org, hidehik...@chromium.org, devtools...@chromium.org, chrome-gr...@chromium.org, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Hidehiko Abe, Justin Cohen and Justin Novosad
Dave Tapuska voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
Justin Novosad (Gerrit)
Apr 14, 2026, 10:47:27 AM (3 days ago) Apr 14
to Justin Cohen, Dave Tapuska, Etienne Pierre-Doray, Hidehiko Abe, Chromium IPC Reviews, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, yhanada+...@chromium.org, hidehik...@chromium.org, devtools...@chromium.org, chrome-gr...@chromium.org, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Hidehiko Abe and Justin Cohen
Justin Novosad voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Hidehiko Abe
- Justin Cohen
Yury Khmel (Gerrit)
Apr 14, 2026, 2:41:48 PM (3 days ago) Apr 14
to Justin Novosad, Justin Cohen, Dave Tapuska, Etienne Pierre-Doray, Hidehiko Abe, Chromium IPC Reviews, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, yhanada+...@chromium.org, hidehik...@chromium.org, devtools...@chromium.org, chrome-gr...@chromium.org, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Hidehiko Abe, Justin Cohen and Justin Novosad
Yury Khmel voted![]( "Open in Gerrit")
Attention is currently required from:
- Hidehiko Abe
- Justin Cohen
- Justin Novosad
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Apr 14, 2026, 6:00:25 PM (3 days ago) Apr 14
to Justin Novosad, Justin Cohen, Yury Khmel, Dave Tapuska, Etienne Pierre-Doray, Hidehiko Abe, Chromium IPC Reviews, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, yhanada+...@chromium.org, hidehik...@chromium.org, devtools...@chromium.org, chrome-gr...@chromium.org, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
chromiu...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS tracing] Move Perfetto data source names from mojom to C++ header
This CL relocates Perfetto data source and producer string constants
out of `perfetto_service.mojom` and into a new standalone C++ header
`perfetto_data_source_names.h`.
Moving these constants into a C++ header removes unnecessary Mojo
dependencies for consumers that only need the raw string constants to
identify data sources or tracks (such as on platforms like iOS where the
full Mojo-based tracing service is not built).
This CL was written in response to this review comment:
https://chromium-review.googlesource.com/c/chromium/src/+/7700720/comment/9a2f9535_3336d7dd/
Bug: 495937056
Low-Coverage-Reason: TRIVIAL_CHANGE in low coverage file services/tracing/public/cpp/perfetto/java_heap_profiler/java_heap_profiler_android.cc
Change-Id: I02a084e9dbcd7c01e3770151adb2d781b4e50fca
Reviewed-by: Joe Mason <joenot...@google.com>
Reviewed-by: Dave Tapuska <dtap...@chromium.org>
Reviewed-by: Yury Khmel <kh...@chromium.org>
Auto-Submit: Justin Novosad <ju...@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
Commit-Queue: Yury Khmel <kh...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1614733}
Files:
- M chrome/browser/ash/arc/tracing/arc_tracing_bridge.cc
- M content/browser/devtools/protocol/tracing_handler.cc
- M content/browser/tracing/cast_tracing_agent.cc
- M content/browser/tracing/cros_tracing_agent.cc
- M content/browser/tracing/tracing_end_to_end_browsertest.cc
- M services/resource_coordinator/public/cpp/memory_instrumentation/tracing_observer.cc
- M services/tracing/perfetto/consumer_host_unittest.cc
- M services/tracing/perfetto/perfetto_service.cc
- M services/tracing/public/cpp/BUILD.gn
- M services/tracing/public/cpp/perfetto/histogram_samples_data_source.cc
- M services/tracing/public/cpp/perfetto/java_heap_profiler/java_heap_profiler_android.cc
- M services/tracing/public/cpp/perfetto/metadata_data_source.cc
- M services/tracing/public/cpp/perfetto/perfetto_config.cc
- A services/tracing/public/cpp/perfetto/perfetto_data_source_names.h
- M services/tracing/public/cpp/stack_sampling/tracing_sampler_profiler.cc
- M services/tracing/public/cpp/stack_sampling/tracing_sampler_profiler_unittest.cc
- M services/tracing/public/cpp/system_metrics_sampler.cc
- M services/tracing/public/cpp/trace_startup_config.cc
- M services/tracing/public/mojom/perfetto_service.mojom
Change size: M
Delta: 19 files changed, 111 insertions(+), 93 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Joe Mason, +1 by Yury Khmel, +1 by Etienne Pierre-Doray, +1 by Dave Tapuska
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages